Re: [PATCH v2 0/4] ArmPkg/ArmMmuLib: fixes and cleanups

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Sep 09, 2016 at 11:48:36AM +0100, Ard Biesheuvel wrote:
> Patch #1 replaces the needlessly complex routine to determine the number of
> translation levels and the size and alignment of the root table based on the
> T0SZ setting.
> 
> Patch #2 fixes the fix for allocating page aligned pages, which is a truism
> and as such does not require any special care to begin with.
> 
> Patch #3 switches to a suitably aligned pool allocation for the root table
> if its size is much smaller than a page.
> 
> Patch #4 makes the size of the VA space in the VM registers equal to the
> GCD memory map size.

Right, took a while to get my head around some of your cleverer
arithmetic, but:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Ard Biesheuvel (4):
>   ArmPkg/ArmMmuLib: deobfuscate GetRootTranslationTableInfo ()
>   ArmPkg/ArmMmuLib: remove bogus alignment of page allocations
>   ArmPkg/ArmMmuLib: use a pool allocation for the root table
>   ArmPkg/ArmMmuLib: base page table VA size on GCD memory map size
> 
>  ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 82 +++++++-------------
>  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf       |  4 +
>  ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf        |  4 +
>  3 files changed, 38 insertions(+), 52 deletions(-)
> 
> -- 
> 2.7.4
>