From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B45991A1DEA for ; Tue, 13 Sep 2016 03:40:08 -0700 (PDT) Received: by mail-wm0-x236.google.com with SMTP id 1so193100925wmz.1 for ; Tue, 13 Sep 2016 03:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/ZoaZlQvvF9OsifU2DCr1t59wZkHzxV6uG51WR7SMzs=; b=TyFqjufGlafbdgEyvRuvMKhAtkRxv/5p4M0T0bI9CmXW80arPFd9QboBt4yF8tj1nJ iXwd8LuRQZpiRIo+u3mI5vhe+LwRyxHR/Wa4Aua/mwawqp55g6p4eYih0voXv4+4HRak pT4McK1hsSJbS0QOKLZQ1AyVw2P4HvZpBynKI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/ZoaZlQvvF9OsifU2DCr1t59wZkHzxV6uG51WR7SMzs=; b=Hie4j9BXixFf3pxUszDwbMUhK6v1GPhIfkIKoA6A5vhXjh0V6sBzhj7tZq3sCQXZU0 RFUDLLjltTUymsQdFoH+wlShL3IcanrL1zgmUzd/vQqsfqPtnDZMePOFsiDlzbMZjZ8r IDM5k86O2nuscMNJI9JVIy+/k2DkdyHxor288523jKYQdGj0TUBZ1CddD0A36yXeC2Py h6OKTatjVcpPauR4ckftZnJ0Pxm+CqbRRvx4jF6urJ6daY81WPx5bXI3KX1YYXV6Oo9j N0SVPt7K8yPe8+3WdWPxOaotm6mWkAj1g4c1qNtLYgNgCtFEw3rwUngQMY5UeM5p8DOk RJCg== X-Gm-Message-State: AE9vXwPLkiQsNdID458xs9Bk2T4b+C3ifok6sZMoRdsTbPXCiYNrIjuOl9Iv8XxQlp9GIyYr X-Received: by 10.194.235.166 with SMTP id un6mr18828855wjc.169.1473763206666; Tue, 13 Sep 2016 03:40:06 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m68sm9409423wmg.6.2016.09.13.03.40.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 03:40:06 -0700 (PDT) Date: Tue, 13 Sep 2016 11:40:04 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, eugene@hp.com, heyi.guo@linaro.org Message-ID: <20160913104004.GT16080@bivouac.eciton.net> References: <1473418120-31410-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1473418120-31410-1-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2 0/4] ArmPkg/ArmMmuLib: fixes and cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 10:40:09 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 09, 2016 at 11:48:36AM +0100, Ard Biesheuvel wrote: > Patch #1 replaces the needlessly complex routine to determine the number of > translation levels and the size and alignment of the root table based on the > T0SZ setting. > > Patch #2 fixes the fix for allocating page aligned pages, which is a truism > and as such does not require any special care to begin with. > > Patch #3 switches to a suitably aligned pool allocation for the root table > if its size is much smaller than a page. > > Patch #4 makes the size of the VA space in the VM registers equal to the > GCD memory map size. Right, took a while to get my head around some of your cleverer arithmetic, but: Reviewed-by: Leif Lindholm > Ard Biesheuvel (4): > ArmPkg/ArmMmuLib: deobfuscate GetRootTranslationTableInfo () > ArmPkg/ArmMmuLib: remove bogus alignment of page allocations > ArmPkg/ArmMmuLib: use a pool allocation for the root table > ArmPkg/ArmMmuLib: base page table VA size on GCD memory map size > > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 82 +++++++------------- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 + > ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf | 4 + > 3 files changed, 38 insertions(+), 52 deletions(-) > > -- > 2.7.4 >