From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andrew Fish <afish@apple.com>, edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: improve formatting of backtrace
Date: Wed, 14 Sep 2016 14:35:23 +0100 [thread overview]
Message-ID: <20160914133523.GC16080@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu9kZwrmP1iaNMbw1bDUhQXQGQbeWENEf1CGZjCNUTO=fw@mail.gmail.com>
On Wed, Sep 14, 2016 at 02:28:37PM +0100, Ard Biesheuvel wrote:
> On 12 September 2016 at 09:32, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > On 10 September 2016 at 01:23, Andrew Fish <afish@apple.com> wrote:
> >>
> >>
> >>> On Sep 9, 2016, at 11:00 AM, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >>>
> >>> Implement the backtrace formattting suggested by Andrew, i.e.,
> >>>
> >>> IRQ Exception at 0x000000005BE182B0
> >>> PC 0x00005BE182B0 (0x00005BE14000+0x000042B0) [ 0] ArmCpuDxe.dll
> >>> PC 0x00005BE15770 (0x00005BE14000+0x00001770) [ 0] ArmCpuDxe.dll
> >>> PC 0x00005EF08CC8 (0x00005EEEB000+0x0001DCC8) [ 1] DxeCore.dll
> >>> PC 0x00005EF09008 (0x00005EEEB000+0x0001E008) [ 1] DxeCore.dll
> >>> PC 0x00005EEF6ACC (0x00005EEEB000+0x0000BACC) [ 1] DxeCore.dll
> >>> PC 0x00005EF0963C (0x00005EEEB000+0x0001E63C) [ 1] DxeCore.dll
> >>> PC 0x00005EF09A38 (0x00005EEEB000+0x0001EA38) [ 1] DxeCore.dll
> >>> PC 0x00005EF01560 (0x00005EEEB000+0x00016560) [ 1] DxeCore.dll
> >>> PC 0x00005EF02FB4 (0x00005EEEB000+0x00017FB4) [ 1] DxeCore.dll
> >>> PC 0x00005EF03098 (0x00005EEEB000+0x00018098) [ 1] DxeCore.dll
> >>> PC 0x00005EF0460C (0x00005EEEB000+0x0001960C) [ 1] DxeCore.dll
> >>> PC 0x00005EF005C4 (0x00005EEEB000+0x000155C4) [ 1] DxeCore.dll
> >>> PC 0x00005EF00360 (0x00005EEEB000+0x00015360) [ 1] DxeCore.dll
> >>> PC 0x00005EF003C8 (0x00005EEEB000+0x000153C8) [ 1] DxeCore.dll
> >>> PC 0x00005EF128D0 (0x00005EEEB000+0x000278D0) [ 1] DxeCore.dll
> >>> PC 0x00005EF12930 (0x00005EEEB000+0x00027930) [ 1] DxeCore.dll
> >>> PC 0x00005EEEF594 (0x00005EEEB000+0x00004594) [ 1] DxeCore.dll
> >>> PC 0x00005EF0CF18 (0x00005EEEB000+0x00021F18) [ 1] DxeCore.dll
> >>> PC 0x00005EF1A310 (0x00005EEEB000+0x0002F310) [ 1] DxeCore.dll
> >>> PC 0x00005EEF1808 (0x00005EEEB000+0x00006808) [ 1] DxeCore.dll
> >>> PC 0x00005EEF1E48 (0x00005EEEB000+0x00006E48) [ 1] DxeCore.dll
> >>> PC 0x00005EF0A838 (0x00005EEEB000+0x0001F838) [ 1] DxeCore.dll
> >>> PC 0x00005EEED70C (0x00005EEEB000+0x0000270C) [ 1] DxeCore.dll
> >>> PC 0x00005EEEC93C (0x00005EEEB000+0x0000193C) [ 1] DxeCore.dll
> >>> PC 0x00005EEEC024 (0x00005EEEB000+0x00001024) [ 1] DxeCore.dll
> >>>
> >>> [ 0] /home/ard/build/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/ArmPkg/Drivers/CpuDxe/CpuDxe/DEBUG/ArmCpuDxe.dll
> >>> [ 1] /home/ard/build/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/MdeModulePkg/Core/Dxe/DxeMain/DEBUG/DxeCore.dll
> >>>
> >>
>
> Leif: any comments?
Was just hanging back to see if there was more discussion forthcoming.
Looks good to me:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
prev parent reply other threads:[~2016-09-14 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 18:00 [PATCH] ArmPkg/DefaultExceptionHandlerLib: improve formatting of backtrace Ard Biesheuvel
2016-09-10 0:23 ` Andrew Fish
2016-09-12 8:32 ` Ard Biesheuvel
2016-09-14 13:28 ` Ard Biesheuvel
2016-09-14 13:35 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914133523.GC16080@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox