From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7EF321A1E82 for ; Wed, 14 Sep 2016 06:35:27 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id k186so7651299wmd.0 for ; Wed, 14 Sep 2016 06:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=++ecV7a8gARH/BzmPYyJ7aPeeqp+FDCB63/+XNNg4QE=; b=UN5y1W/I66Zk0yLr0cVnFYWzq6H61mnsacXjOJDP/yhmI0c+OvWU0vGLx8sOs1ghji DKsFFPkuOBhAAYlFpj/bwoBgTFdij3rPcmW7PWtM84ohKbDUV8SAe4Tjh3t/0I1Xmu5Y oHvKVLCCNOKNl8aZ5oIna1n3RhXyFHUhCKiaM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=++ecV7a8gARH/BzmPYyJ7aPeeqp+FDCB63/+XNNg4QE=; b=POtMhyjSn3rzas9Ms2+qmskT7F30VHLjqqAPn9EFdyWBa3KzDvCO2x5Ln3TcZesCiv 5KL7Dyq3OPXC+Rc7+Obvv6MjuEV5ZOR4dtNd30BuqYn+c7cpGr8hdOQ4rq+Q8K4YiOET u3CfvX3NBQ4dA/WKa8Vcqp1VL6bL81GlM9eMURIuq3c6ly0v+mn4HenW+FzTb/7jKh7L erCFFYKU18U8+LC7/wBT652IwzH5lRhbs9yu4evbz5BnShnOSNNZ8MYvFNs4evSKO73p v6Il9RepGYuUY5+jm7BmrWl++VETP+iy29ym8HBsuNwu1dE9ldmcYbcF+myOU71rAfxX /HaA== X-Gm-Message-State: AE9vXwPW8fWuUcu2X1+GRIFCF3rba/1X+CAzZLg8Cp4YD9GGJS+Rr/Qf7jLXmQkatK7Pg00v X-Received: by 10.28.99.137 with SMTP id x131mr3303734wmb.64.1473860125904; Wed, 14 Sep 2016 06:35:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w129sm4254600wmd.9.2016.09.14.06.35.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 06:35:25 -0700 (PDT) Date: Wed, 14 Sep 2016 14:35:23 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Andrew Fish , edk2-devel-01 Message-ID: <20160914133523.GC16080@bivouac.eciton.net> References: <1473444037-15016-1-git-send-email-ard.biesheuvel@linaro.org> <4F48B3E6-DE76-4142-88D1-F7B99E59DEF0@apple.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: improve formatting of backtrace X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2016 13:35:27 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 14, 2016 at 02:28:37PM +0100, Ard Biesheuvel wrote: > On 12 September 2016 at 09:32, Ard Biesheuvel wrote: > > On 10 September 2016 at 01:23, Andrew Fish wrote: > >> > >> > >>> On Sep 9, 2016, at 11:00 AM, Ard Biesheuvel wrote: > >>> > >>> Implement the backtrace formattting suggested by Andrew, i.e., > >>> > >>> IRQ Exception at 0x000000005BE182B0 > >>> PC 0x00005BE182B0 (0x00005BE14000+0x000042B0) [ 0] ArmCpuDxe.dll > >>> PC 0x00005BE15770 (0x00005BE14000+0x00001770) [ 0] ArmCpuDxe.dll > >>> PC 0x00005EF08CC8 (0x00005EEEB000+0x0001DCC8) [ 1] DxeCore.dll > >>> PC 0x00005EF09008 (0x00005EEEB000+0x0001E008) [ 1] DxeCore.dll > >>> PC 0x00005EEF6ACC (0x00005EEEB000+0x0000BACC) [ 1] DxeCore.dll > >>> PC 0x00005EF0963C (0x00005EEEB000+0x0001E63C) [ 1] DxeCore.dll > >>> PC 0x00005EF09A38 (0x00005EEEB000+0x0001EA38) [ 1] DxeCore.dll > >>> PC 0x00005EF01560 (0x00005EEEB000+0x00016560) [ 1] DxeCore.dll > >>> PC 0x00005EF02FB4 (0x00005EEEB000+0x00017FB4) [ 1] DxeCore.dll > >>> PC 0x00005EF03098 (0x00005EEEB000+0x00018098) [ 1] DxeCore.dll > >>> PC 0x00005EF0460C (0x00005EEEB000+0x0001960C) [ 1] DxeCore.dll > >>> PC 0x00005EF005C4 (0x00005EEEB000+0x000155C4) [ 1] DxeCore.dll > >>> PC 0x00005EF00360 (0x00005EEEB000+0x00015360) [ 1] DxeCore.dll > >>> PC 0x00005EF003C8 (0x00005EEEB000+0x000153C8) [ 1] DxeCore.dll > >>> PC 0x00005EF128D0 (0x00005EEEB000+0x000278D0) [ 1] DxeCore.dll > >>> PC 0x00005EF12930 (0x00005EEEB000+0x00027930) [ 1] DxeCore.dll > >>> PC 0x00005EEEF594 (0x00005EEEB000+0x00004594) [ 1] DxeCore.dll > >>> PC 0x00005EF0CF18 (0x00005EEEB000+0x00021F18) [ 1] DxeCore.dll > >>> PC 0x00005EF1A310 (0x00005EEEB000+0x0002F310) [ 1] DxeCore.dll > >>> PC 0x00005EEF1808 (0x00005EEEB000+0x00006808) [ 1] DxeCore.dll > >>> PC 0x00005EEF1E48 (0x00005EEEB000+0x00006E48) [ 1] DxeCore.dll > >>> PC 0x00005EF0A838 (0x00005EEEB000+0x0001F838) [ 1] DxeCore.dll > >>> PC 0x00005EEED70C (0x00005EEEB000+0x0000270C) [ 1] DxeCore.dll > >>> PC 0x00005EEEC93C (0x00005EEEB000+0x0000193C) [ 1] DxeCore.dll > >>> PC 0x00005EEEC024 (0x00005EEEB000+0x00001024) [ 1] DxeCore.dll > >>> > >>> [ 0] /home/ard/build/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/ArmPkg/Drivers/CpuDxe/CpuDxe/DEBUG/ArmCpuDxe.dll > >>> [ 1] /home/ard/build/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/MdeModulePkg/Core/Dxe/DxeMain/DEBUG/DxeCore.dll > >>> > >> > > Leif: any comments? Was just hanging back to see if there was more discussion forthcoming. Looks good to me: Reviewed-by: Leif Lindholm