public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeff Fan <jeff.fan@intel.com>
To: edk2-devel@ml01.01.org
Cc: Steven Shi <Steven.shi@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Kelly Steele <kelly.steele@intel.com>,
	Feng Tian <feng.tian@intel.com>
Subject: [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S
Date: Tue, 20 Sep 2016 16:29:09 +0800	[thread overview]
Message-ID: <20160920082911.6908-2-jeff.fan@intel.com> (raw)
In-Reply-To: <20160920082911.6908-1-jeff.fan@intel.com>

ESP should be set to top of eSRAM range that aligns with Flat32.asm. Because CPU
BIST data will be located at top of STACK, this issue leads Platform Sec Lib
cannot get the correct CPU BIST information.

This fix is to address below issue:
  https://tianocore.acgmultimedia.com/show_bug.cgi?id=123

Cc: Steven Shi <Steven.shi@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
 QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S
index 2bb503f..f35dbcf 100644
--- a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S
+++ b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S
@@ -1,6 +1,6 @@
 #------------------------------------------------------------------------------
 #
-# Copyright (c) 2013 - 2015 Intel Corporation.
+# Copyright (c) 2013 - 2016 Intel Corporation.
 #
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
@@ -263,7 +263,7 @@ L0:
   # Set up stack pointer
   #
   movl    ASM_PFX(PcdGet32(PcdEsramStage1Base)), %esp
-  movl    $QUARK_STACK_SIZE_BYTES, %esi
+  movl    $QUARK_ESRAM_MEM_SIZE_BYTES, %esi
   addl    %esi, %esp                          # ESP = top of stack (stack grows downwards).
 
   #
-- 
2.9.3.windows.2



  reply	other threads:[~2016-09-20  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  8:29 [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Jeff Fan
2016-09-20  8:29 ` Jeff Fan [this message]
2016-09-20  8:29 ` [Patch 2/3] UefiCpuPkg/SecCore: Fix comment typo Jeff Fan
2016-09-20  8:29 ` [Patch 3/3] UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs Jeff Fan
2016-09-20 20:28 ` [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920082911.6908-2-jeff.fan@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox