From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4CCFC1A1DEC for ; Tue, 20 Sep 2016 01:34:06 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP; 20 Sep 2016 01:34:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,366,1470726000"; d="scan'208";a="11204094" Received: from jfan12-desk.ccr.corp.intel.com ([10.239.9.5]) by fmsmga005.fm.intel.com with ESMTP; 20 Sep 2016 01:34:04 -0700 From: Jeff Fan To: edk2-devel@ml01.01.org Cc: Steven Shi , Michael Kinney , Kelly Steele , Feng Tian Date: Tue, 20 Sep 2016 16:29:09 +0800 Message-Id: <20160920082911.6908-2-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20160920082911.6908-1-jeff.fan@intel.com> References: <20160920082911.6908-1-jeff.fan@intel.com> Subject: [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 08:34:06 -0000 ESP should be set to top of eSRAM range that aligns with Flat32.asm. Because CPU BIST data will be located at top of STACK, this issue leads Platform Sec Lib cannot get the correct CPU BIST information. This fix is to address below issue: https://tianocore.acgmultimedia.com/show_bug.cgi?id=123 Cc: Steven Shi Cc: Michael Kinney Cc: Kelly Steele Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S index 2bb503f..f35dbcf 100644 --- a/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S +++ b/QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S @@ -1,6 +1,6 @@ #------------------------------------------------------------------------------ # -# Copyright (c) 2013 - 2015 Intel Corporation. +# Copyright (c) 2013 - 2016 Intel Corporation. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License @@ -263,7 +263,7 @@ L0: # Set up stack pointer # movl ASM_PFX(PcdGet32(PcdEsramStage1Base)), %esp - movl $QUARK_STACK_SIZE_BYTES, %esi + movl $QUARK_ESRAM_MEM_SIZE_BYTES, %esi addl %esi, %esp # ESP = top of stack (stack grows downwards). # -- 2.9.3.windows.2