public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeff Fan <jeff.fan@intel.com>
To: edk2-devel@ml01.01.org
Cc: Michael Kinney <michael.d.kinney@intel.com>,
	Feng Tian <feng.tian@intel.com>
Subject: [Patch 3/3] UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs
Date: Tue, 20 Sep 2016 16:29:11 +0800	[thread overview]
Message-ID: <20160920082911.6908-4-jeff.fan@intel.com> (raw)
In-Reply-To: <20160920082911.6908-1-jeff.fan@intel.com>

Currently, this is ASSERT() if neither SecPlatformInformation2 nor
SecPlatformInformation PPIs are found. This is not correct. Per PI specification
both of them are optional PPI. Platform may not install them.

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
 UefiCpuPkg/SecCore/SecBist.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/SecCore/SecBist.c b/UefiCpuPkg/SecCore/SecBist.c
index 19f3492..ba7d7ca 100644
--- a/UefiCpuPkg/SecCore/SecBist.c
+++ b/UefiCpuPkg/SecCore/SecBist.c
@@ -261,6 +261,8 @@ RepublishSecPlatformInformationPpi (
                  SecInformationDescriptor,
                  &mPeiSecPlatformInformation
                  );
+    } else if (Status == EFI_NOT_FOUND) {
+      return;
     }
   }
 
-- 
2.9.3.windows.2



  parent reply	other threads:[~2016-09-20  8:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20  8:29 [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Jeff Fan
2016-09-20  8:29 ` [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S Jeff Fan
2016-09-20  8:29 ` [Patch 2/3] UefiCpuPkg/SecCore: Fix comment typo Jeff Fan
2016-09-20  8:29 ` Jeff Fan [this message]
2016-09-20 20:28 ` [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920082911.6908-4-jeff.fan@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox