From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Subject: [PATCH v2 00/19] Add HiiImageEx implementations
Date: Mon, 26 Sep 2016 17:30:16 +0800 [thread overview]
Message-ID: <20160926093035.350612-1-ruiyu.ni@intel.com> (raw)
The patch serials also change the BootLogoLib and EDKII Platform Logo
protocol to use the HiiImageEx. The change to the BootLogoLib and
EDKII Platform Logo protocol is incompatible but since the consumers
are limited to only Nt32/ArmVirt/Ovmf so the impact is small.
Nt32Pkg/ArmVirtPkg/OvmfPkg are changed accordingly due to the change
of BootLogoLib.
Compare to v1, v2 added the missing HiiImageDecoder.h, passed the
PatchChecke script, and addressed the following comments raised
by Liming:
1). This is the incompatible change in BootLogoLib. It also impacts
OvmfPkg and ArmVirtPkg. Please highlight this change in cover
letter, and update OvmfPkg and ArmVirtPkg both.
2) HiiDrawImageIdEx() directly calls HiiDrawImageId(). But,
HiiDrawImageId() doesn't support JPEG and PNG. This is a
functional issue in HiiDrawImageIdEx().
3) IGetImage() will call Decoder protocol to get the output
ImageOut. Per UEFI spec, ImageOut is allocated by Decoder
protocol, and free by the caller. Please free it in IGetImage()
The total 19 commits can be reviewed in following url:
https://github.com/niruiyu/edk2/commits/HiiImage
Ruiyu Ni (19):
MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress
MdeModulePkg/HiiDatabase: Move common code to LocatePackageList()
MdeModulePkg/HiiDatabase: Refine HiiNewImage()
MdeModulePkg/HiiDatabase: Refine HiiGetImage()
MdeModulePkg/HiiDatabase: Refine HiiSetImage()
MdeModulePkg/HiiDatabase: Refine HiiDrawImage()
MdemodulePkg/HiiDatabase: Correct typo in comments.
MdePkg/HiiImage.h: Include GraphicsOutput.h
MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG
MdePkg/HiiImageDecoder.h: Add HiiImageDecoder protocol header file
MdeModulePkg/HiiDatabase: Add HiiImageEx implementation.
Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo
ArmVirtPkg/PlatformBds: Do not call BootLogoEnableLogo
OvmfPkg/PlatformBds: Do not call BootLogoEnableLogo
MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in
parameters
MdeModulePkg/Logo: Add LogoDxe module
Nt32Pkg: Use the new LogoDxe driver
ArmVirtPkg: Use the new LogoDxe driver
OvmfPkg: Use the new LogoDxe driver
ArmVirtPkg/ArmVirtQemu.dsc | 7 +-
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 4 +-
ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +-
.../Library/PlatformBootManagerLib/PlatformBm.c | 8 +-
.../PlatformBootManagerLib.inf | 1 -
MdeModulePkg/Include/Library/BootLogoLib.h | 19 +-
MdeModulePkg/Include/Protocol/PlatformLogo.h | 20 +-
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 204 +++----
MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 8 +-
MdeModulePkg/Logo/Logo.c | 156 ++++++
MdeModulePkg/Logo/Logo.idf | 18 +
MdeModulePkg/Logo/LogoDxe.inf | 60 ++
MdeModulePkg/Logo/LogoDxe.uni | 21 +
MdeModulePkg/Logo/LogoDxeExtra.uni | 19 +
MdeModulePkg/MdeModulePkg.dec | 2 +-
.../HiiDatabaseDxe/ConfigKeywordHandler.c | 36 +-
.../Universal/HiiDatabaseDxe/ConfigRouting.c | 60 +-
MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 16 +-
MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 38 +-
.../Universal/HiiDatabaseDxe/HiiDatabase.h | 295 +++++++++-
.../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 7 +-
.../Universal/HiiDatabaseDxe/HiiDatabaseEntry.c | 34 +-
MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 620 ++++++++++-----------
MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c | 423 ++++++++++++++
MdePkg/Include/Protocol/HiiImage.h | 4 +-
MdePkg/Include/Protocol/HiiImageDecoder.h | 200 +++++++
.../PlatformBootManagerLib/PlatformBootManager.c | 4 +-
.../PlatformBootManagerLib.inf | 4 +-
Nt32Pkg/Nt32Pkg.dsc | 7 +-
Nt32Pkg/Nt32Pkg.fdf | 5 +-
.../Library/PlatformBootManagerLib/BdsPlatform.c | 8 +-
.../PlatformBootManagerLib.inf | 1 -
OvmfPkg/OvmfPkgIa32.dsc | 3 +-
OvmfPkg/OvmfPkgIa32.fdf | 4 +-
OvmfPkg/OvmfPkgIa32X64.dsc | 3 +-
OvmfPkg/OvmfPkgIa32X64.fdf | 4 +-
OvmfPkg/OvmfPkgX64.dsc | 3 +-
OvmfPkg/OvmfPkgX64.fdf | 4 +-
38 files changed, 1686 insertions(+), 651 deletions(-)
create mode 100644 MdeModulePkg/Logo/Logo.c
create mode 100644 MdeModulePkg/Logo/Logo.idf
create mode 100644 MdeModulePkg/Logo/LogoDxe.inf
create mode 100644 MdeModulePkg/Logo/LogoDxe.uni
create mode 100644 MdeModulePkg/Logo/LogoDxeExtra.uni
create mode 100644 MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c
create mode 100644 MdePkg/Include/Protocol/HiiImageDecoder.h
--
2.9.0.windows.1
next reply other threads:[~2016-09-26 9:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 9:30 Ruiyu Ni [this message]
2016-09-26 9:30 ` [PATCH v2 01/19] MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 02/19] MdeModulePkg/HiiDatabase: Move common code to LocatePackageList() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 03/19] MdeModulePkg/HiiDatabase: Refine HiiNewImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 04/19] MdeModulePkg/HiiDatabase: Refine HiiGetImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 05/19] MdeModulePkg/HiiDatabase: Refine HiiSetImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 06/19] MdeModulePkg/HiiDatabase: Refine HiiDrawImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 07/19] MdemodulePkg/HiiDatabase: Correct typo in comments Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 08/19] MdePkg/HiiImage.h: Include GraphicsOutput.h Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 09/19] MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 10/19] MdePkg/HiiImageDecoder.h: Add HiiImageDecoder protocol header file Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 11/19] MdeModulePkg/HiiDatabase: Add HiiImageEx implementation Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 12/19] Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 13/19] ArmVirtPkg/PlatformBds: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 12:56 ` Ard Biesheuvel
2016-09-26 9:30 ` [PATCH v2 14/19] OvmfPkg/PlatformBds: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 9:30 ` [PATCH v2 15/19] MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in parameters Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 16/19] MdeModulePkg/Logo: Add LogoDxe module Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 17/19] Nt32Pkg: Use the new LogoDxe driver Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 18/19] ArmVirtPkg: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 12:56 ` Ard Biesheuvel
2016-09-26 9:30 ` [PATCH v2 19/19] OvmfPkg: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-28 8:12 ` [PATCH v2 00/19] Add HiiImageEx implementations Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926093035.350612-1-ruiyu.ni@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox