Re: Miss "IMAGE_FORMAT" type name error when compile EDK2

[Dashing Meng <dashing_meng@163.com>]

On Wed, 28 Sep 2016 19:09:12 -0700
Andrew Fish <afish@apple.com> wrote:

> 
> > On Sep 28, 2016, at 6:43 PM, dashing meng <dashing_meng@163.com> wrote:
> > 
> > Sorry for my web mail, it it always top posting.
> > 
> > It seems the update for edk2 repository deleted the defination of type "IMAGE_FORMAT" in 
> > "MdeModulePkg/Include/Protocol/PlatformLogo.h" few days ago.
> > 
> > See: https://github.com/tianocore/edk2/commit/e0ac9c8a9bd67ab934bca86504706b5400cde558 <https://github.com/tianocore/edk2/commit/e0ac9c8a9bd67ab934bca86504706b5400cde558>
> > 
> > Please fix this error.
> > 
> 
> Please file a bug: https://bugzilla.tianocore.org
> 
> Thanks,
> 
> Andrew Fish
> 
> > Thanks.
> > 
> > Dashing Meng 
> > 
> > 
> > 
> > 
> > 在 2016-09-28 22:38:29，"Andrew Fish" <afish@apple.com> 写道：
> > 
> >> On Sep 28, 2016, at 6:01 AM, dashing meng <dashing_meng@163.com <mailto:dashing_meng@163.com>> wrote:
> >> 
> >> 
> >> Hi,
> >> Everyone.
> >> 
> >> My machine is a Intel P6200 cpu, no vt-x support, 64bit, Debian 8 64bit OS.
> >> 
> >> I am compiling EDK2 with the instruction at: https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions <https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions>
> >> When "Build Hello World!  (and the rest of MdeModulePkg)" by excute "build" command, I encounter the error message
> >> below:
> >>  /src/edk2/MdeModulePkg/Include/Library/ImageDecoderLib.h:22:7: error: unknown type name ‘IMAGE_FORMAT’
> >>    IN  IMAGE_FORMAT                  ImageFormat,
> >> I search the source, search the web, have not found any library file include type name "IMAGE_FORMAT", 
> >> Where can I find the file define the type of "IMAGE_FORMAT"? Anyone has any clue to fix this error?
> >> 
> > 
> > It looks like MdeModulePkg/Include/Protocol/PlatformLogo.h contains the definition of IMAGE_FORMAT and it is an enum. It should be included by MdeModulePkg/Include/Library/ImageDecoderLib.h
> > 
> > 
> > ~/work/src/edk2(master)>git grep -w IMAGE_FORMAT
> > MdeModulePkg/Include/Library/BootLogoLib.h:37:  IN  IMAGE_FORMAT                          ImageFormat,
> > MdeModulePkg/Include/Library/ImageDecoderLib.h:22:  IN  IMAGE_FORMAT                  ImageFormat,
> > MdeModulePkg/Include/Library/ImageDecoderLib.h:52:  IN  IMAGE_FORMAT                  ImageFormat,
> > MdeModulePkg/Include/Protocol/PlatformLogo.h:33:} IMAGE_FORMAT;
> > MdeModulePkg/Include/Protocol/PlatformLogo.h:70:     OUT IMAGE_FORMAT                          *Format,
> > MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c:43:  IN  IMAGE_FORMAT                  ImageFormat,
> > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c:47:  IN  IMAGE_FORMAT                          ImageFormat,
> > MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.c:55:  IN  IMAGE_FORMAT                  ImageFormat,
> > ~/work/src/edk2(master)>git blame -L33,33 MdeModulePkg/Include/Protocol/PlatformLogo.h
> > 6313eb25 (Ruiyu Ni 2015-11-12 05:19:22 +0000 33) } IMAGE_FORMAT;
> > ~/work/src/edk2(master)>git blame -L17,17 MdeModulePkg/Include/Library/ImageDecoderLib.h
> > 345c2b07 (Ruiyu Ni 2015-11-12 05:21:38 +0000 17) #include <Protocol/PlatformLogo.h>
> > 

Thanks.

I file a bug report at: https://bugzilla.tianocore.org/show_bug.cgi?id=133

Bug 133 - Miss type defination of "IMAGE_FORMAT" and "DECODE_IMAGE" in "Include/Library/ImageDecoderLib.h"

-- 
Dashing Meng <dashing_meng@163.com>