From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by ml01.01.org (Postfix) with ESMTP id 44D0B1A1DEB for ; Wed, 28 Sep 2016 19:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-Id:Mime-Version; bh=6V3kM /rRahn5hiJVco6VI9qliuRLdDlL4Qd3goj0m7k=; b=bhRlX2kldKBlboCqPAz9M /T0YBprjFEPR3oII82KaaYKZp3ILR7ufyP9xBRhWjx9VZkRnMnjbArr3hJpaYXe/ zcTe+ZNxXnOyDtt1wbu7+bZV+CwdTmcPaBXxRkMdK8yYBU1OxCm7esUT20bZy5Kd MG0AkkpxlJUjlYVso++vMs= Received: from debian83 (unknown [36.42.35.214]) by smtp9 (Coremail) with SMTP id DcCowAD3B+aJfexXC2qwAQ--.18964S2; Thu, 29 Sep 2016 10:33:46 +0800 (CST) Date: Thu, 29 Sep 2016 10:33:47 +0800 From: Dashing Meng To: Andrew Fish Cc: edk2-devel@lists.01.org Message-Id: <20160929103347.46112fb41dc396974fa5bb41@163.com> In-Reply-To: References: <28cd9226.17fc7.15770e26cf9.Coremail.dashing_meng@163.com> <61ccfed6.4678.157739c18b8.Coremail.dashing_meng@163.com> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CM-TRANSID: DcCowAD3B+aJfexXC2qwAQ--.18964S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxAFyDtw15Gw1UAw1UCrWfZrb_yoW5tr4fpa 4vyFyUJw48Jrs0kF4IkFWxXFW5Kas8Gr4Fq34Yvwn7CFWqqa4kKayqkrn8urWSgr4vy3yD W3y0gr429w1UZrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jotCwUUUUU= X-Originating-IP: [36.42.35.214] X-CM-SenderInfo: xgdvxx5qjbzvlqj6il2tof0z/1tbiGgzzvVaDqCttLwAAsM Subject: Re: Miss "IMAGE_FORMAT" type name error when compile EDK2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 02:33:58 -0000 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit On Wed, 28 Sep 2016 19:09:12 -0700 Andrew Fish wrote: > > > On Sep 28, 2016, at 6:43 PM, dashing meng wrote: > > > > Sorry for my web mail, it it always top posting. > > > > It seems the update for edk2 repository deleted the defination of type "IMAGE_FORMAT" in > > "MdeModulePkg/Include/Protocol/PlatformLogo.h" few days ago. > > > > See: https://github.com/tianocore/edk2/commit/e0ac9c8a9bd67ab934bca86504706b5400cde558 > > > > Please fix this error. > > > > Please file a bug: https://bugzilla.tianocore.org > > Thanks, > > Andrew Fish > > > Thanks. > > > > Dashing Meng > > > > > > > > > > ÔÚ 2016-09-28 22:38:29£¬"Andrew Fish" дµÀ£º > > > >> On Sep 28, 2016, at 6:01 AM, dashing meng > wrote: > >> > >> > >> Hi, > >> Everyone. > >> > >> My machine is a Intel P6200 cpu, no vt-x support, 64bit, Debian 8 64bit OS. > >> > >> I am compiling EDK2 with the instruction at: https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions > >> When "Build Hello World! (and the rest of MdeModulePkg)" by excute "build" command, I encounter the error message > >> below: > >> /src/edk2/MdeModulePkg/Include/Library/ImageDecoderLib.h:22:7: error: unknown type name ¡®IMAGE_FORMAT¡¯ > >> IN IMAGE_FORMAT ImageFormat, > >> I search the source, search the web, have not found any library file include type name "IMAGE_FORMAT", > >> Where can I find the file define the type of "IMAGE_FORMAT"? Anyone has any clue to fix this error? > >> > > > > It looks like MdeModulePkg/Include/Protocol/PlatformLogo.h contains the definition of IMAGE_FORMAT and it is an enum. It should be included by MdeModulePkg/Include/Library/ImageDecoderLib.h > > > > > > ~/work/src/edk2(master)>git grep -w IMAGE_FORMAT > > MdeModulePkg/Include/Library/BootLogoLib.h:37: IN IMAGE_FORMAT ImageFormat, > > MdeModulePkg/Include/Library/ImageDecoderLib.h:22: IN IMAGE_FORMAT ImageFormat, > > MdeModulePkg/Include/Library/ImageDecoderLib.h:52: IN IMAGE_FORMAT ImageFormat, > > MdeModulePkg/Include/Protocol/PlatformLogo.h:33:} IMAGE_FORMAT; > > MdeModulePkg/Include/Protocol/PlatformLogo.h:70: OUT IMAGE_FORMAT *Format, > > MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c:43: IN IMAGE_FORMAT ImageFormat, > > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c:47: IN IMAGE_FORMAT ImageFormat, > > MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.c:55: IN IMAGE_FORMAT ImageFormat, > > ~/work/src/edk2(master)>git blame -L33,33 MdeModulePkg/Include/Protocol/PlatformLogo.h > > 6313eb25 (Ruiyu Ni 2015-11-12 05:19:22 +0000 33) } IMAGE_FORMAT; > > ~/work/src/edk2(master)>git blame -L17,17 MdeModulePkg/Include/Library/ImageDecoderLib.h > > 345c2b07 (Ruiyu Ni 2015-11-12 05:21:38 +0000 17) #include > > Thanks. I file a bug report at: https://bugzilla.tianocore.org/show_bug.cgi?id=133 Bug 133 - Miss type defination of "IMAGE_FORMAT" and "DECODE_IMAGE" in "Include/Library/ImageDecoderLib.h" -- Dashing Meng