From: Peter Jones <pjones@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.
Date: Thu, 29 Sep 2016 14:39:54 -0400 [thread overview]
Message-ID: <20160929183951.vptkqvo6xicfwpxo@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F56481DCC7@ORSMSX113.amr.corp.intel.com>
On Thu, Sep 29, 2016 at 06:38:17PM +0000, Kinney, Michael D wrote:
> Peter,
>
> Please use this form in your patch. The UEFI Spec does allow other error codes than
> those listed in the API to be returned. Using !EFI_ERROR (Status) is safer. EDK II
> Coding Style also requires {} for if statements.
Apologies; obviously you were also saying this in your previous reply,
which I read too quickly during a meeting. Update to follow.
Thanks.
--
Peter
next prev parent reply other threads:[~2016-09-29 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 15:59 [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice Peter Jones
2016-09-29 16:33 ` Kinney, Michael D
2016-09-29 17:45 ` Peter Jones
2016-09-29 18:38 ` Kinney, Michael D
2016-09-29 18:39 ` Peter Jones [this message]
2016-09-29 18:45 ` Peter Jones
2016-09-29 18:48 ` Kinney, Michael D
2016-09-30 1:06 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929183951.vptkqvo6xicfwpxo@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox