From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pjones@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 53A1A1A1E3E
 for <edk2-devel@ml01.01.org>; Thu, 29 Sep 2016 11:40:02 -0700 (PDT)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D96224E024;
 Thu, 29 Sep 2016 18:40:01 +0000 (UTC)
Received: from redhat.com (ovpn-112-7.phx2.redhat.com [10.3.112.7])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u8TIdsBP025133
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 29 Sep 2016 14:39:59 -0400
Date: Thu, 29 Sep 2016 14:39:54 -0400
From: Peter Jones <pjones@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Message-ID: <20160929183951.vptkqvo6xicfwpxo@redhat.com>
References: <E92EE9817A31E24EB0585FDF735412F56481DC1E@ORSMSX113.amr.corp.intel.com>
 <20160929174501.12323-1-pjones@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F56481DCC7@ORSMSX113.amr.corp.intel.com>
MIME-Version: 1.0
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F56481DCC7@ORSMSX113.amr.corp.intel.com>
User-Agent: NeoMutt/20160916 (1.7.0)
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Thu, 29 Sep 2016 18:40:01 +0000 (UTC)
Subject: Re: [PATCH] Pkcs7VerifyDxe: Don't allow Pkcs7Verify to install protocols twice.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 18:40:02 -0000
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On Thu, Sep 29, 2016 at 06:38:17PM +0000, Kinney, Michael D wrote:
> Peter,
> 
> Please use this form in your patch.  The UEFI Spec does allow other error codes than
> those listed in the API to be returned.  Using !EFI_ERROR (Status) is safer.  EDK II
> Coding Style also requires {} for if statements.

Apologies; obviously you were also saying this in your previous reply,
which I read too quickly during a meeting.  Update to follow.

Thanks.
-- 
  Peter