* af468025 breaks my linux build
@ 2016-10-04 20:06 Gabriel L. Somlo
2016-10-04 21:22 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel L. Somlo @ 2016-10-04 20:06 UTC (permalink / raw)
To: edk2-devel-01, ruiyu.ni
Hi,
I'm building with
build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc
on a F24 box, and right now things are breaking with this error
message:
lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg
-I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include
-I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg
-I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include
-I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64
/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c
In file included from
/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0,
from
/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20,
from
/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17,
from <command-line>:0:
/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18:
error: ‘IMG_LOGO’ undeclared here (not in a function)
IMAGE_TOKEN (IMG_LOGO),
GNUmakefile:420: recipe for target
'/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj'
failed
^
/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24:
note: in definition of macro ‘IMAGE_TOKEN’
#define IMAGE_TOKEN(t) t
^
make: ***
[/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj]
Error 1
The place it's complaining about comes from commit af468025
(MdeModulePkg/Logo: Add LogoDxe module).
Thanks (and sorry if this is an already-known issue).
--Gabriel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: af468025 breaks my linux build
2016-10-04 20:06 af468025 breaks my linux build Gabriel L. Somlo
@ 2016-10-04 21:22 ` Laszlo Ersek
2016-10-05 0:41 ` Gabriel L. Somlo
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2016-10-04 21:22 UTC (permalink / raw)
To: Gabriel L. Somlo, edk2-devel-01, ruiyu.ni
On 10/04/16 22:06, Gabriel L. Somlo wrote:
> Hi,
>
> I'm building with
>
> build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc
>
> on a F24 box, and right now things are breaking with this error
> message:
>
>
> lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include
> -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c
> In file included from
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0,
> from
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20,
> from
> /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17,
> from <command-line>:0:
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18:
> error: ‘IMG_LOGO’ undeclared here (not in a function)
> IMAGE_TOKEN (IMG_LOGO),
> GNUmakefile:420: recipe for target
> '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj'
> failed
> ^
> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24:
> note: in definition of macro ‘IMAGE_TOKEN’
> #define IMAGE_TOKEN(t) t
> ^
> make: ***
> [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj]
> Error 1
>
>
> The place it's complaining about comes from commit af468025
> (MdeModulePkg/Logo: Add LogoDxe module).
>
>
> Thanks (and sorry if this is an already-known issue).
Please clean out your Build/ directory, also your Conf/ directory
(except for ReadMe.txt and .gitignore that belong there), and re-run
source edksetup.sh
from a pristine-env shell.
The problem (on your side) is that you don't have the new build rules
for *.idf files under Conf/ (from commit 333ba578fef4d, "BaseTools:
support generating image package from BMP/JPEG/PNG files"), thus
IMG_LOGO, from "MdeModulePkg/Logo/Logo.idf", is not visible to the compiler.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: af468025 breaks my linux build
2016-10-04 21:22 ` Laszlo Ersek
@ 2016-10-05 0:41 ` Gabriel L. Somlo
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel L. Somlo @ 2016-10-05 0:41 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, ruiyu.ni
On Tue, Oct 04, 2016 at 11:22:18PM +0200, Laszlo Ersek wrote:
> On 10/04/16 22:06, Gabriel L. Somlo wrote:
> > Hi,
> >
> > I'm building with
> >
> > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc
> >
> > on a F24 box, and right now things are breaking with this error
> > message:
> >
> >
> > lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg
> > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include
> > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg
> > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include
> > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64
> > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c
> > In file included from
> > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0,
> > from
> > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20,
> > from
> > /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17,
> > from <command-line>:0:
> > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18:
> > error: ‘IMG_LOGO’ undeclared here (not in a function)
> > IMAGE_TOKEN (IMG_LOGO),
> > GNUmakefile:420: recipe for target
> > '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj'
> > failed
> > ^
> > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24:
> > note: in definition of macro ‘IMAGE_TOKEN’
> > #define IMAGE_TOKEN(t) t
> > ^
> > make: ***
> > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj]
> > Error 1
> >
> >
> > The place it's complaining about comes from commit af468025
> > (MdeModulePkg/Logo: Add LogoDxe module).
> >
> >
> > Thanks (and sorry if this is an already-known issue).
>
> Please clean out your Build/ directory, also your Conf/ directory
> (except for ReadMe.txt and .gitignore that belong there), and re-run
>
> source edksetup.sh
>
> from a pristine-env shell.
>
> The problem (on your side) is that you don't have the new build rules
> for *.idf files under Conf/ (from commit 333ba578fef4d, "BaseTools:
> support generating image package from BMP/JPEG/PNG files"), thus
> IMG_LOGO, from "MdeModulePkg/Logo/Logo.idf", is not visible to the compiler.
Thanks, that took care of it (after not paying attention for a few
months, I was about due for running into this problem :)
Cheers,
--Gabriel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-05 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 20:06 af468025 breaks my linux build Gabriel L. Somlo
2016-10-04 21:22 ` Laszlo Ersek
2016-10-05 0:41 ` Gabriel L. Somlo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox