From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-x231.google.com (mail-yw0-x231.google.com [IPv6:2607:f8b0:4002:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BFAB1A1E1F for ; Tue, 4 Oct 2016 17:41:41 -0700 (PDT) Received: by mail-yw0-x231.google.com with SMTP id t193so67811090ywc.2 for ; Tue, 04 Oct 2016 17:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=sE3O4ry9t3GUmVJRQeLUVxVmkMPn0geNny5vquUYtV0=; b=X8lORyeKvb9Iu8xU6PQQ/8OzM20eXPkm7P8fyaKNXdb7f0DccET8MDXGEE8o78yMX6 rQ+9xLD9wTsCyTQBFJDsz8zgg3KF86C3+DioGwdFZDHvzGv2o9tjokh1Dd629bB7ljbs SAGdbj27HyGOmQwzSxUGXNz6XJPxHdmLK17s3N7im9HjKnQQfLPn8a77krfUQ2xoR42A 2LyUONjbIEfB8j3jqrCka/VeJR/OcsxoPyAqjJtJsb2p/3wEtvHZP7ulzsYuwbPuQ02D m4eDV6j3NIgU0o/pqPP+4d2jSJ5ydEFkI1kUoXsh0OHqLktwsKRoVffPuOBp6mO4QZZa a0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sE3O4ry9t3GUmVJRQeLUVxVmkMPn0geNny5vquUYtV0=; b=c/labvbmBmI6sCzNobWtJl8oKD0zdYT3MDHH4afMUVcM+ghJjmiyyxfGmU1UowxQS6 qnFe2pBxCDu8eIdM5BDN11QmXQU3Xp17yHCUjPUbjqfzGhVHG73hp9+rEdrqlta+TnND wQfUiV5hzMJZ690MYwKjdCGeSYaPIV3Trce9v7pS/rlcee0UTBnIXOrmFFQM2D2KJP92 05+eaq68G9bwo8uZEneetuzDtHT10LukvQfaNqzpkkPJKu1VMrBoKT/eg2hNzkvGiSbW xK19IQcCtd3msjNDk0RAt9gHuLM+rqfphVlGYFreFKgXVFNbtitqYwqpyeVpWRSakCf+ AWrw== X-Gm-Message-State: AA6/9RkVMDroHRsz5Pk1IRWli4Y9zBr4w51dxF5JzRhf9CLW+lXjDDVaRnCGJPZ3K5RqfA== X-Received: by 10.37.14.137 with SMTP id 131mr5027549ybo.9.1475628100280; Tue, 04 Oct 2016 17:41:40 -0700 (PDT) Received: from foober.ini.cmu.edu (pool-98-111-199-206.pitbpa.fios.verizon.net. [98.111.199.206]) by smtp.gmail.com with ESMTPSA id h185sm18745167ywe.12.2016.10.04.17.41.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 17:41:39 -0700 (PDT) Date: Tue, 4 Oct 2016 20:41:34 -0400 From: "Gabriel L. Somlo" To: Laszlo Ersek Cc: edk2-devel-01 , ruiyu.ni@intel.com Message-ID: <20161005004133.GA13136@foober.ini.cmu.edu> References: <20161004200603.GF552@HEDWIG.INI.CMU.EDU> <2ead6db9-9a19-534a-2214-f0ee7de00659@redhat.com> MIME-Version: 1.0 In-Reply-To: <2ead6db9-9a19-534a-2214-f0ee7de00659@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.0 (2016-08-17) Subject: Re: af468025 breaks my linux build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 00:41:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Oct 04, 2016 at 11:22:18PM +0200, Laszlo Ersek wrote: > On 10/04/16 22:06, Gabriel L. Somlo wrote: > > Hi, > > > > I'm building with > > > > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc > > > > on a F24 box, and right now things are breaking with this error > > message: > > > > > > lo/KVM-OSX/SCRATCH/edk2/MdeModulePkg > > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include > > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg > > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include > > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64 > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c > > In file included from > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiSpec.h:2192:0, > > from > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/PiDxe.h:20, > > from > > /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/DEBUG/AutoGen.h:17, > > from :0: > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Logo/Logo.c:34:18: > > error: ‘IMG_LOGO’ undeclared here (not in a function) > > IMAGE_TOKEN (IMG_LOGO), > > GNUmakefile:420: recipe for target > > '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj' > > failed > > ^ > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h:2133:24: > > note: in definition of macro ‘IMAGE_TOKEN’ > > #define IMAGE_TOKEN(t) t > > ^ > > make: *** > > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Logo/LogoDxe/OUTPUT/Logo.obj] > > Error 1 > > > > > > The place it's complaining about comes from commit af468025 > > (MdeModulePkg/Logo: Add LogoDxe module). > > > > > > Thanks (and sorry if this is an already-known issue). > > Please clean out your Build/ directory, also your Conf/ directory > (except for ReadMe.txt and .gitignore that belong there), and re-run > > source edksetup.sh > > from a pristine-env shell. > > The problem (on your side) is that you don't have the new build rules > for *.idf files under Conf/ (from commit 333ba578fef4d, "BaseTools: > support generating image package from BMP/JPEG/PNG files"), thus > IMG_LOGO, from "MdeModulePkg/Logo/Logo.idf", is not visible to the compiler. Thanks, that took care of it (after not paying attention for a few months, I was about due for running into this problem :) Cheers, --Gabriel