Re: [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Oct 07, 2016 at 04:15:36PM +0100, Ard Biesheuvel wrote:
> On 7 October 2016 at 16:14, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and
> > PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere
> > in memory can use PlatformPeiLib.
> >
> 
> ... and also, drop some references to PCDs that are in fact not used.
> 
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +----------
> >  1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > index 314789d0a990..2363d9aa966e 100644
> > --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
> > @@ -39,15 +39,6 @@ [Ppis]
> >    gEfiPeiMasterBootModePpiGuid                  # PPI ALWAYS_PRODUCED
> >    gEfiPeiBootInRecoveryModePpiGuid              # PPI SOMETIMES_PRODUCED
> >
> > -[FixedPcd]
> > -  gArmTokenSpaceGuid.PcdFdBaseAddress
> > -  gArmTokenSpaceGuid.PcdFdSize
> > -
> > +[Pcd]
> >    gArmTokenSpaceGuid.PcdFvBaseAddress
> >    gArmTokenSpaceGuid.PcdFvSize
> > -
> > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize
> > -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize
> > -
> > -[depex]
> > -  TRUE

So, especially the depex drop makes me prefer seeing the cleanup as a
separate patch.

Otherwise, looks good to me.

/
    Leif


> > --
> > 2.7.4
> >