From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 857991A1E05 for ; Fri, 7 Oct 2016 08:51:30 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id i130so47775414wmg.1 for ; Fri, 07 Oct 2016 08:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UdY8tGVKf8UV/y/sPWjarJUo0XczkPwWNe1pfBfM90k=; b=JpptdC2uZ/93gNN4VhoJ3cDMkFClnN94lw3eO7DcWFVcRhDBLzk5XHO7K0fZmD9+75 Du5cEfCA4X4X19pFZ9PmVgFgZDeKYSlSjS3SidW3LpNiPR16KtkmPJz6zUbjm46o/Qb2 ZrU8ex6cC/edYOxTSTxErzRpnK0EpvaMWpvyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UdY8tGVKf8UV/y/sPWjarJUo0XczkPwWNe1pfBfM90k=; b=NbDwYJoIZwQT+oIHTKPPrizG7h22MJcbdH3Sdj3cOyILwuzggVE6pHzGaa9FT2g2Jc UhdPKbm7r9QblG2uSglC7/V7i5QtbLwkjh8UeO9z8GzltDNeIzW4mZjaD/IvaWfweSWy rgZ4yLgQCpEqqtGh+FLE1KYp9dBhOTIbm3I6hdQo34W6kF0pzO+iP9jDt026dlEhiPjp aJM/6N15F8a3KZmr5LmE8oZHAz4qu9wNMm+khpJ6JrSVQyGQEjpFjpJWomzDyTJiOU5D 47TNDUfdceGg27Gp7p6zScij0P4bMZccdiYKI1Ob97GocuqqO7Vsdj3XVBKk1QOtF9bO 57Yg== X-Gm-Message-State: AA6/9RlqZ7PK34XGXUP+i+SrxJlAM/s8QiqeGaEh37DE3myOdYHgcLiJBez9Tq4T5Uco73AF X-Received: by 10.194.178.130 with SMTP id cy2mr17144856wjc.138.1475855488889; Fri, 07 Oct 2016 08:51:28 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r135sm1657061wmf.15.2016.10.07.08.51.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 08:51:26 -0700 (PDT) Date: Fri, 7 Oct 2016 16:51:24 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel-01 Message-ID: <20161007155124.GC3471@bivouac.eciton.net> References: <1475853298-28327-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPlatformPkg/PlatformPeiLib: allow patch PCDs for FV base address/size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 15:51:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 07, 2016 at 04:15:36PM +0100, Ard Biesheuvel wrote: > On 7 October 2016 at 16:14, Ard Biesheuvel wrote: > > Allow patchable or dynamic PCDs to be used for PcdFvBaseAddress and > > PcdFvBaseSize, so that platforms whose UEFI image may be loaded anywhere > > in memory can use PlatformPeiLib. > > > > ... and also, drop some references to PCDs that are in fact not used. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ard Biesheuvel > > --- > > ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 11 +---------- > > 1 file changed, 1 insertion(+), 10 deletions(-) > > > > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > > index 314789d0a990..2363d9aa966e 100644 > > --- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf > > @@ -39,15 +39,6 @@ [Ppis] > > gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED > > gEfiPeiBootInRecoveryModePpiGuid # PPI SOMETIMES_PRODUCED > > > > -[FixedPcd] > > - gArmTokenSpaceGuid.PcdFdBaseAddress > > - gArmTokenSpaceGuid.PcdFdSize > > - > > +[Pcd] > > gArmTokenSpaceGuid.PcdFvBaseAddress > > gArmTokenSpaceGuid.PcdFvSize > > - > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > - > > -[depex] > > - TRUE So, especially the depex drop makes me prefer seeing the cleanup as a separate patch. Otherwise, looks good to me. / Leif > > -- > > 2.7.4 > >