From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eu-smtp-delivery-143.mimecast.com (eu-smtp-delivery-143.mimecast.com [146.101.78.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 436581A1E30 for ; Mon, 17 Oct 2016 19:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bKsowzMdKV/JgWcPAsP4Mh7cBufgBirZz+d+Yb120PE=; b=JyQE5/caLoj4IvPph4EMgoDsE9qJEyj9G2y9+J2bM8GEA8oKipv8tWIyYLcsx1HnaWQ6wjTqsOrjFnRMxxx6WG4/74Y541Q+fsmBYBWokisHQXbJdgZPgdmT84V8iLMDmNlG13EtWr5on0FZFa3BJpfJDdu/2aP7oNFW5A95RjI= Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp0247.outbound.protection.outlook.com [213.199.154.247]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-5-LnzNA08oPSOBgm5NdaSJsw-1; Tue, 18 Oct 2016 03:50:32 +0100 Received: from VI1PR08CA0038.eurprd08.prod.outlook.com (10.164.95.48) by AM4PR08MB1105.eurprd08.prod.outlook.com (10.167.91.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Tue, 18 Oct 2016 02:50:30 +0000 Received: from AM1FFO11OLC006.protection.gbl (2a01:111:f400:7e00::193) by VI1PR08CA0038.outlook.office365.com (2a01:111:e400:597a::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11 via Frontend Transport; Tue, 18 Oct 2016 02:50:31 +0000 Received: from nebula.arm.com (217.140.96.140) by AM1FFO11OLC006.mail.protection.outlook.com (10.174.64.134) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.669.7 via Frontend Transport; Tue, 18 Oct 2016 02:50:30 +0000 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Tue, 18 Oct 2016 03:50:17 +0100 Date: Tue, 18 Oct 2016 10:50:15 +0800 From: Dennis Chen To: Ard Biesheuvel CC: edk2-devel-01 , , Leif Lindholm Message-ID: <20161018025013.GA19504@arm.com> References: <1476694460-29877-1-git-send-email-dennis.chen@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140; IPV:CAL; SCL:-1; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(24454002)(23726003)(586003)(36756003)(189998001)(54356999)(97756001)(305945005)(6916009)(86362001)(2906002)(50466002)(50986999)(76176999)(19580405001)(19580395003)(104016004)(106466001)(1076002)(26826002)(4326007)(8936002)(47776003)(92566002)(77096005)(33656002)(7696004)(4001350100001)(110136003)(87936001)(83506001)(7846002)(2950100002)(246002)(356003)(8676002)(626004)(5660300001)(46406003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB1105; H:nebula.arm.com; FPR:; SPF:Pass; PTR:fw-tnat.cambridge.arm.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; AM1FFO11OLC006; 1:g4XOTy2lKSqWKWvimmJvFcH+r4oimDlgCN3vf8drYAnlQl8yd251apAkUjgZHkXI8OxfLEZZk6MpNUYwa5ctazcqC/PvM7ivpce/5pUjraOLbD47IhVbzmLTgtbqQT8lkIoH3imfCV2D3NYcMA9bX9fVcsQ3Q9lwDvAQlJuTDafgVPXLW4bB+0QBzjDGn5SZzfzu15FMZt/iFGO3k+FQWn9mpHu/MEzl+znwkeFCiuoVQo7t7GO3gwpMVRGmFPNHzv1QF1jse2mqcLULdEA+6NmjWPkxO/40ocpSpNyzz7K2NUwNQY7G3Z2c2kw7bc1rIcUrbrPkH5mu4PZFjYDsmhr8EpnHF9ZMLxcXZH3r5pChJ9OsCQweeFCM7KXnGUpoGIXD34Q4nNESq3446FpUt8ZXJoaXsFbsrczWRhsyu/M/d8jcSgknFmcS+Am7bGmOr/wDw9EO5k4IhhdiucXxDCfwXAEO4PeMEJAHwOGAqB2HyyhgUZI1jdnOO3HyiPOp29C8G2exPtUQicsue4YuVdQhA51mRxuWRaRLgPwNK5JJBVDaHw511zo7RHvcGYf6dxT64lrWJYJGBYlwMRbtbg== X-MS-Office365-Filtering-Correlation-Id: 7efb0b39-38fd-4c79-769a-08d3f701864c X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 2:+eakftbDqfQiIUgt6WKdIb5wfDdroSVoO9DHZfICiEjklp0Dg/pTysDQ7VaMXs6VJgi+/r517g0elYWY+7lF75exJeODwwGBR5uwGSMshamN+mSBwmumWhQvXxlGX+ndo9Q3Ss28OW413KobQpRTnmlyCT+D1xW1uO2EanzBRWJ2aOEW+KCg9/JyqnnD1LWBjN6vzlvkJpMRSoGam6etmg==; 3:Hb7O7gHrXM3Xq0xeVa0O5BTfe39RD1P0xj/tr5hB2bI3tK/NMseXBz1aQTrDKm/C5uMnOHv3LCF0hYWMuU5MFBk4L6iJRATw3LDqXOCGp9m6XoEOmtY7g67kVSmdvw77bemHRj9q7chYo8K0ykHeMOh6VHCJN18FmsqZEewTkISatshx0oS8RRQZSVKF2Zz6G2aZnCc57Wa2jloLHU5c5zODMcvquLMP7hHvIbZWatx6LSPhF4zvfh46mYwc1VQcKG/HYL8HiDqZliork5AE3rZNriunajgQr0JcFn1QvL0= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:AM4PR08MB1105; X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 25:RFQh9F+zEIDSOoW1AP8afUVY2sCO4o3xcT6g4b4tiuFTuY+CL2awaHNrAi3ng2sp8pNrdYx8tGbn65jS8PRO3WEH1LzfmhdTqztXcTmTFqSwBXoISwK5ZrwjYENpqOOijd2veestDC4jYHYKWX5ERjRNOBbXtqMV8LkbNytC4xOzxNgnatkCEsa0C0zE6Wmsi76ZRiuzXH/frL96UC++UrLFvj6Yy3ejDZ6gKVd6WTwsSeodX7EtIo74AMQUAIaJFcZrtkVckD3kl6LZ+H36DmbA9kv66PfvNq6HfekCT7qrvGLt81Txist+BM7Va5OyusJo77Jd26iyPDVpPeHD5M6Aeg+x5JRGbF/U8DhIjXOpY+aEFtLAhFx1UUVDEcgkQG6iipdnIrrYkMXF2+hFRhcjYAlD1RScjRNycCrbNz3+HrbJ0wxxcx5H1NDtW+v4+ZOH8NjoOysUkHvnVd/6YLCEtjx7Dsmqa/OQY4EIMhFCz40sgN9o+Nxck6Wf/EmJ8ClftpfIisFz4xvLwg5nCEzLe5WfJJkcUwfjDVJ4WNh++NcgjJy8rRZjo921glsvdD9hMt8ZwW0CB7R25oY/tY+YeKKm62UItMdGumFrpbg+7aXQVIpbXaqulZcTL2CsUwnKCFcDpXphceL9QdQzKwTJA8qh9fjoJSUkuHgTMqQpiBL7jIMkDuINEBiXSqRGiE52axUyZZVjyN8AUYF0FbQgGt1Z630MG9bzG3I0VfNjT6ekZxC8GV7mIBRxguBn1FjR4VGjQpjhVjDI/HYYR7DETKNi51w7a+al21fP1bQ= X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 31:bwgNk/ZHgVg0iwsZ8fyEQuj+Q2J8017cEOORx6sBx12x5RcGTG76Mdl173CKgObcBXJ2CNg0zTgcFlj95HJp9kBtuud8jieHoq4L5/Bl4XSic62F5GkcTUTJBJxCMPpdpSeHJLywkQCwj1DVpN4wg4z2mKs3GN4Vg3K7LWxTSr59JsjrYqC50xdLq5J1aN4fEpMGIjfXeq59mnjDayuvAuLwnHV+kV7y/YjAVwXy9A3P6M6IP8NkLhX6F1b3IYx8REWPRcHYEJSKsCH2RIu6tw==; 20:dKsub7M5xQMLjA6G72L+egzUzCnUuEnPUY2zUuEazCOoslTBWcyPb2IZ/YAwHHKzwC/HC6H4rUL8Hgp2IvRntA8FPDWEiyzRqCDiFRO1FmFOhCD3MjA6cAaDl3fb8quVcLCIbSIW+Dq1uvEJEw1rucJLwtZg9T8sxAdSsC1kPDsDx/J1Y4IOgifSZh6sWGIZJyYw5GP5uDoWuVsrw7A8QI4DThR9yyE2JYkvNQKPa5c9bRJoRABNeYok/wNCS4vW NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13013025)(13020025)(8121501046)(13023025)(13024025)(5005006)(3002001)(10201501046)(6055026); SRVR:AM4PR08MB1105; BCL:0; PCL:0; RULEID:; SRVR:AM4PR08MB1105; X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 4:jMBVCr/Cw9leQ4ilG83SsusvZvQs1odmFv9kn+zUBHPNfykoYamE3R2Zwe5FEdD2nICzCsGxlZwFdnKkMKFywbav0hHwx3zIGngFUwomqFq4/Y3N2rfy38i222F2XiWWl/4jhZSwkuKq/pZOhKp9DpGoG2xoK/CeZ/aw3y/beaCcPzB8LYeboYUWecsLIJJ4ez3TiW07Bt/pRrkg/QJTbEOINC0zFBeq5lfmoyHKaJPNvl4l0ngVTtSCsZXOUZCLw/1bJNVyEksxV2EBTbDs0+reur4bbgt9FikDykD8NqghzZi0O37G05EeEq7AaLyLB4RpJPF7O1/Cw1hYN2tHwx5q9zuYHR4wUyCeaWlKrIUR6ZNX8aIkbr6xLed/NeR/00GqNhlANw4uIHczqW5ilyrWpwRI/LGRCN0PwQl+b4Owegl3QgRaO7Lgs9lrWkqEgUbw4iVv/ksXXsSr+Ww5+uNneybCppW2+2Ok09RBO/kd7nXFwKd0iGjC8xDqtmg10zD3SPvLhw/5dKqAsClQsJKY3lFHwkgEoEUC0rOA9ig= X-Forefront-PRVS: 00997889E7 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR08MB1105; 23:bYHDN2AO9unksLAu0MMEXLe4mJsJH0JkaGeo14FGl?= =?us-ascii?Q?xXWnid0DYtTHcta/MN0EMtwNbd7HI0SdwO0bMsve9yx+VYcNVInLa2KxxKU2?= =?us-ascii?Q?rnYKPiP/YVVasGeJrd++xTxQHebPcqA2PeWHT6fXmgUkBNKcBb7nV24dpO0e?= =?us-ascii?Q?AcVnoYBC2WWt8xDgJOsMMzTslDHY0JQMS/hod01OXZyaHWRkxYG1Dc4X8CBA?= =?us-ascii?Q?iSDC/R9oMCqQkU308st4tiYmucbKf83Z2lcULnYTMlE+xKAsk7pmJ1ZfxBIv?= =?us-ascii?Q?BeegHO+wICSGbgfbH1fjNDBWpbtYR0goFJsrZIE4hfg2qxOgm+ewpXgE0gJX?= =?us-ascii?Q?h2OVGifciBDP2vQjPef67Oer0/VpXQbDCkAiCvrHrL0H+ogqB4geRhYD8C5m?= =?us-ascii?Q?EWYQ+iYjqC8FRmPM0pUqELCfechdfFJqHiC3He++KE9xQtNNwvwTDgmmxMWl?= =?us-ascii?Q?bem+7GPqUnyTDsT98jBjVQy3rVjUgUJvSuRoyR0p7OX3PlXfIOJ9bZWP5rAY?= =?us-ascii?Q?n59oFqMfVtmUCVrla0xEmVTaLdOq3pidz3NZ+z0A+0h+/W7+4DhbmLzm2U+h?= =?us-ascii?Q?rN7pHQrE0zc6CK7PM28O+dDr9itdPXGDGw41y0s1njZzDQfgFrVU4CnDvDR3?= =?us-ascii?Q?rjyJQuPt2ZYbFHsWdLzjdzamyL6QhvOIcua73VcZGJSci4beaVgZgH/il3q3?= =?us-ascii?Q?o0MOLIrsITcQfSe2Szlt54gQtK7rRn2h22FZdiYt42FnTkFAn26+slXVqTrI?= =?us-ascii?Q?xhDqRRGqqpQA2k79PdCjRfMjnnns1MS237UFzUj7NpjI6A0WsEQm9zNxsMVD?= =?us-ascii?Q?vzX+Ys1PTZOk786GR99pnmXcI1U2tVBHMkcNEmxMdftCzjCTJVpVjYCQqeUA?= =?us-ascii?Q?SndR+juglbf+vvm+llmrEVvuwSUbvwzmemXJKsp/+gAp6y2PMePaYUoF2YaW?= =?us-ascii?Q?digqEtaAILpYIWV2vYSQH38FCOqV6gt7a7yFE9aBc6Tnphacu0FBDpL73vSh?= =?us-ascii?Q?EH2DfLjCgfGBIObYFlg5MnobqWDKr7j8bwuTASFlku25hBL4fWH+SwzfNwCA?= =?us-ascii?Q?PVb7GfzXEU33P/qA3QDk/b5RlEjCbs36lE5KNtUssCcfeYJwZ7XYBTdpg67H?= =?us-ascii?Q?5MTgdGxHI/3B9bMYxVIAFzqGV7Ve33+?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 6:1hfYjVkESqfjRJWndHuW+uwb/xU8iYri2EVPRCDMDB1ITYP+CvexwqYZ0NQfWN5foHo3aUddmH7EON3NrhHLKigzlZ3pFunLhDEVEza5b5WHIAW/HR8Q8RgcXAIxTMx+GGPRAtgADUSFvbVwq4yq5Pq8CXKt/lmRVA47NFv2EWPt2uYidbHiCNVlZNexg8Aa2qlzZI/wpkqlOn/CEnmabL2IP4ZgDV+0U75jZPuheQVX0Mm4IENcaPmO+Hqrs0z9pyze//eo0132nVBO8MebqfRxduUatZ6dqSwyuhvEOOpxtxGuOVX4g0EBW7HWn07717srinS+rF34xx4KGCvs240qe3cg3sqR8y7Bi5MD8bg=; 5:OTt4gyC87j2HAJHlQNWIsv0fJUtTW/dMQnEq4b600xotmORPUaOChgf+qVMtMVMdWadOoFLQdcniAM9LHdY0TEYFrypb7a9FjvD+KOxbiNlUOsruU44jyIN4Z0axcZZXg0KRyyCanvF1+vcnDdH9Vg==; 24:3J9ur3dTCG0hG5C0YHquUQaXmjQCOb4IjVBVVnKWF94NLWP+rX+d0e8L/ahpbBw0+2Eo6az4hCOIzVftZuBDXQjQwLmgUhbbSdSRHwtVMtA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB1105; 7:LWfCPn7Ra6nnbaREusQt2AVR4cczFyjP8+IFcFTiNYVezcGsBLs54C6QBu8SBUDAT5cQyzm/MGMOki3vGBBx7ah5latZTDepkee7gnLaYWJmvM+SGaXiTM97BxrapzfLWXteP4wg6mYvM9rEVqUiP6vZYEymFV3i3IQjY/q0IjOOe5tMSi5Mm/zKyGK64s/VshnNjf7kOR1co6/P0thJA42sRsTB0mQtH9r1dll39Evnw08702eKM5UrrJGApdkUBbBCfLVfyISGeYA+3En1Ne2lgdeMp7zmpMpmD2XretglXu80Z3adUw9mbL2mWUnmW+Xn+dRCkHyJBBXlg4yiC6iNoamlvAs3gQjsWw4VGzM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2016 02:50:30.7217 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB1105 X-MC-Unique: LnzNA08oPSOBgm5NdaSJsw-1 Subject: Re: [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 02:50:36 -0000 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello Ard, On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote: > On 17 October 2016 at 09:54, Dennis Chen wrote: > > Since ACPI spec defines the GIC base addresses (CPU interface, > > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > > define these corresponding base address variables as 64-bit instead of > > 32-bit. This patch redefines them according to the ACPI spec. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Signed-off-by: Dennis Chen >=20 > After a closer look, I noticed the following: >=20 > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase= , > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase= , > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase= , > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicInterruptInterfaceBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicInterruptInterfaceBase, > ArmPkg/Include/Library/ArmGicLib.h: IN INTN > GicInterruptInterfaceBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicDistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicRedistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicDistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicRedistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicDistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicRedistributorBase, > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase= , > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterf= aceBase > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicInterruptInterfaceBase > ArmPkg/Include/Library/ArmGicLib.h: IN UINTN > GicInterruptInterfaceBase, >=20 > so I think we need to clean up the use of these values more widely > than we have done up till now > I am not very sure if we still need to support UEFI on 32-bit ARM platform,= as Leif mentioned if we use INTN or UINTN that will be more generic to embrace both 32 &64-bi= t platform, at least in form of. Currently we are only focused on 64-bit platform, let's wait fo= r Leif's comment then I can re-work my patch to adapt it after we have reached a wider agreement. Thanks, Dennis=20 >=20 > Leif: I was wondering if EFI_PHYSICAL_ADDRESS would be more > appropriate for MMIO base addresses? >=20