From: Dennis Chen <dennis.chen@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>, <nd@arm.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit
Date: Tue, 18 Oct 2016 17:26:53 +0800 [thread overview]
Message-ID: <20161018092651.GA20322@arm.com> (raw)
In-Reply-To: <CAKv+Gu87rwk=1ZhrB0p6MJJH1h8mJqaWAjgYySVTTAeq0eNE3w@mail.gmail.com>
Hello Ard,
On Tue, Oct 18, 2016 at 09:40:42AM +0100, Ard Biesheuvel wrote:
> On 18 October 2016 at 03:50, Dennis Chen <dennis.chen@arm.com> wrote:
> > Hello Ard,
> >
> > On Mon, Oct 17, 2016 at 06:09:00PM +0100, Ard Biesheuvel wrote:
> >> On 17 October 2016 at 09:54, Dennis Chen <dennis.chen@arm.com> wrote:
> >> > Since ACPI spec defines the GIC base addresses (CPU interface,
> >> > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should
> >> > define these corresponding base address variables as 64-bit instead of
> >> > 32-bit. This patch redefines them according to the ACPI spec.
> >> >
> >> > Contributed-under: TianoCore Contribution Agreement 1.0
> >> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >> > Signed-off-by: Dennis Chen <dennis.chen@arm.com>
> >>
> >> After a closer look, I noticed the following:
> >>
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicInterruptInterfaceBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicInterruptInterfaceBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN
> >> GicInterruptInterfaceBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicRedistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicRedistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicRedistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicInterruptInterfaceBase
> >> ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
> >> GicInterruptInterfaceBase,
> >>
> >> so I think we need to clean up the use of these values more widely
> >> than we have done up till now
> >>
> > I am not very sure if we still need to support UEFI on 32-bit ARM platform, as Leif mentioned
> > if we use INTN or UINTN that will be more generic to embrace both 32 &64-bit platform, at least
> > in form of. Currently we are only focused on 64-bit platform, let's wait for Leif's comment then
> > I can re-work my patch to adapt it after we have reached a wider agreement.
> >
>
> Hi Dennis,
>
> My primary concern is the sloppiness regarding INTN/UINTN, so it seem
> a major cleanup is due. I'd prefer using UINT64 everywhere: we can
> still assert that an UINT64 *value* does not exceed MAX_UINTN if we
> want to
>
Indeed, INTN/UINTN usage is very inconsistent in that header file. I suppose you have
considered the 32-bit case when you say you prefer using UNIT64 everywhere, thus I have
no objection for that since I always work on 64-bit area. I will hold on this patch for a
while and resend the revised patch if no more comments inputted.
Thanks,
Dennis
>
> --
> Ard.
>
prev parent reply other threads:[~2016-10-18 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:54 [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit Dennis Chen
2016-10-17 17:09 ` Ard Biesheuvel
2016-10-18 2:50 ` Dennis Chen
2016-10-18 8:40 ` Ard Biesheuvel
2016-10-18 9:26 ` Dennis Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018092651.GA20322@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox