From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-x22d.google.com (mail-vk0-x22d.google.com [IPv6:2607:f8b0:400c:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 364821A1E4F for ; Wed, 19 Oct 2016 06:39:57 -0700 (PDT) Received: by mail-vk0-x22d.google.com with SMTP id 83so26986303vkd.0 for ; Wed, 19 Oct 2016 06:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kfuN9BINovtvy/EPa7E74wGUVYdnsaDX+pqH8RuELlQ=; b=OLc17aL8HJr9MQbifpbmAVRHoLrkiHqaESPLiYKCxuNWDJkJdRewQpb5yp7MJMPqyk sOsjdlxDpDSDK5x5ePAFUmtjB8A4VrA1mOBAlg+qRiUe2sSNoVpDfJbWMhhYpmc2tGqw MhsHyP97xMKJi3PHkYe2Co5uLt9otuxQBkzmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kfuN9BINovtvy/EPa7E74wGUVYdnsaDX+pqH8RuELlQ=; b=NrAD2/nNZwhrFbWjpezikwuEYOlZCQyNYATBR8ReqKvVPVsDX2Plrp40uEmVxZ0deW bc8Bx5fhaYxtvkaND07zf13vQ/NpJgQnf5YHzTy1jq7zZH8TB96ir6Soka/nnoaPDd48 hEWM8Qz8YlOu2ax1vnvmeAmtVn35EQvUTz4nrKwhJKCYVF35vdAIJ98WBLHG7jAFO/wj MSmejRupvmGpHVXtZQubDAJr5dtndiOIFdbgevFYCRBDUUHj4w0caod7TPGIUiCWeyf+ VbwtPN7xs/cnCj2uLwWEBG7tvGYJoZR9A8xjGjSJ2zT/5/O92GEravFS7xH9zc/OUj5c 61kQ== X-Gm-Message-State: AA6/9RlYSWyVJ5vUYMSZcjPSc4ZmJWPNASlSVuLwU/rAv2Dej8PaUekr70KnWMlX/W2i4YbO X-Received: by 10.194.248.162 with SMTP id yn2mr4346251wjc.203.1476884395885; Wed, 19 Oct 2016 06:39:55 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id ya1sm69313406wjb.23.2016.10.19.06.39.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 06:39:54 -0700 (PDT) Date: Wed, 19 Oct 2016 14:39:53 +0100 From: Leif Lindholm To: Sudeep Holla Cc: edk2-devel@lists.01.org, Yonghong Zhu , Ard Biesheuvel Message-ID: <20161019133952.GI3471@bivouac.eciton.net> References: <1476883474-12969-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 In-Reply-To: <1476883474-12969-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPlatformPkg/ArmVExpressPkg: fix the build adding '0x' prefix to hex value X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 13:39:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 19, 2016 at 02:24:34PM +0100, Sudeep Holla wrote: > Interestingly the build used to succeed even with missing leading '0x' > prefix for a hex value before the commit 0613ccbd1357 > ("CorebootPayloadPkg/PciHostBridgeLib: Fix the wrong PCI resource limit") > > With the above commit, luckily we get > ... > raise BadExpression(ERR_ARRAY_ELE % self._Token) > BadExpression: This must be HEX value for NList or Array: [e6]. > > This patch fixes the above error by adding the missing '0x' prefix to > the hex value. > > Cc: Yonghong Zhu > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Sudeep Holla Reviewed-by: Leif Lindholm Pushed - many thanks! > --- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec > index d375ed3b9772..c774d97541e1 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpressPkg.dec > @@ -67,7 +67,7 @@ > gArmVExpressTokenSpaceGuid.PcdFdtVExpressFvpA15x4|{ 0x72, 0x3b, 0x28, 0x27, 0x90, 0x2f, 0xca, 0x4d, 0x9a, 0xb5, 0x98, 0x48, 0xfb, 0xc2, 0xd4, 0xed }|VOID*|0x0000000A > # HW platforms > gArmVExpressTokenSpaceGuid.PcdFdtVExpressHwA9x4|{ 0xf6, 0x1c, 0xd2, 0x2f, 0xe8, 0xe6, 0xf2, 0x4f, 0xa9, 0xca, 0x3b, 0x9f, 0x00, 0xe9, 0x28, 0x89 }|VOID*|0x0000000B > - gArmVExpressTokenSpaceGuid.PcdFdtVExpressHwA15x2A7x3|{ 0xeb, 0x06, e6, 0xd5, 0xdf, 0x83, 0x90, 0x4e, 0x81, 0xe8, 0xc3, 0xdb, 0x2f, 0x77, 0x17, 0x9a }|VOID*|0x0000000C > + gArmVExpressTokenSpaceGuid.PcdFdtVExpressHwA15x2A7x3|{ 0xeb, 0x06, 0xe6, 0xd5, 0xdf, 0x83, 0x90, 0x4e, 0x81, 0xe8, 0xc3, 0xdb, 0x2f, 0x77, 0x17, 0x9a }|VOID*|0x0000000C > gArmVExpressTokenSpaceGuid.PcdFdtVExpressHwA15|{ 0xc2, 0x47, 0x89, 0x6b, 0x87, 0x42, 0x91, 0x4d, 0x8f, 0xe0, 0xa3, 0x81, 0xea, 0x5b, 0x56, 0x8f }|VOID*|0x0000000D > gArmVExpressTokenSpaceGuid.PcdFdtVExpressHwA5|{ 0x63, 0x76, 0xcc, 0xa2, 0x7c, 0x4d, 0x8a, 0x44, 0xaa, 0xb5, 0x4c, 0x03, 0x4b, 0x6f, 0xda, 0xb7 }|VOID*|0x0000000E > > -- > 2.7.4 >