From: Gary Lin <glin@suse.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 30/33] ShellPkg: Fix typos in comments and variables
Date: Thu, 20 Oct 2016 09:55:14 +0800 [thread overview]
Message-ID: <20161020015514.nmt2zophuw6vwzdy@GaryWorkstation> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515C54A9F816@FMSMSX103.amr.corp.intel.com>
On Wed, Oct 19, 2016 at 08:29:02PM +0000, Carsey, Jaben wrote:
> Is this required to be a patch series? By that I mean that they need to be committed in order...
>
Every patch is independent. I made them a series for convenience.
Thanks,
Gary Lin
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>
> > -----Original Message-----
> > From: Ni, Ruiyu
> > Sent: Wednesday, October 19, 2016 12:52 AM
> > To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>
> > Subject: RE: [PATCH 30/33] ShellPkg: Fix typos in comments and variables
> > Importance: High
> >
> >
> >
> > Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > > -----Original Message-----
> > > From: Gary Lin [mailto:glin@suse.com]
> > > Sent: Wednesday, October 19, 2016 3:02 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>
> > > Subject: [PATCH 30/33] ShellPkg: Fix typos in comments and variables
> > >
> > > - funciton -> function
> > > - paramter -> parameter
> > > - supresses -> suppresses
> > > - Seperator -> Separator
> > > - permenant -> permanent
> > >
> > > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Gary Lin <glin@suse.com>
> > > ---
> > > ShellPkg/Include/Library/ShellCEntryLib.h | 2 +-
> > > ShellPkg/Include/Library/ShellCommandLib.h | 2 +-
> > > ShellPkg/Include/Protocol/EfiShellEnvironment2.h | 2 +-
> > > ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c | 2 +-
> > > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 10
> > +++++-
> > > ----
> > >
> > >
> > ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib
> > > .c | 2 +-
> > > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 8
> > > ++++----
> > > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c | 8
> > > ++++----
> > > 8 files changed, 18 insertions(+), 18 deletions(-)
> > >
> > > diff --git a/ShellPkg/Include/Library/ShellCEntryLib.h
> > > b/ShellPkg/Include/Library/ShellCEntryLib.h
> > > index dfbb16f..e4983f8 100644
> > > --- a/ShellPkg/Include/Library/ShellCEntryLib.h
> > > +++ b/ShellPkg/Include/Library/ShellCEntryLib.h
> > > @@ -1,5 +1,5 @@
> > > /** @file
> > > - Provides application point extension for "C" style main funciton.
> > > + Provides application point extension for "C" style main function.
> > >
> > > Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
> > > This program and the accompanying materials diff --git
> > > a/ShellPkg/Include/Library/ShellCommandLib.h
> > > b/ShellPkg/Include/Library/ShellCommandLib.h
> > > index 3ee8200..5ff1e4f 100644
> > > --- a/ShellPkg/Include/Library/ShellCommandLib.h
> > > +++ b/ShellPkg/Include/Library/ShellCommandLib.h
> > > @@ -2,7 +2,7 @@
> > > Provides interface to shell internal functions for shell commands.
> > >
> > > This library is for use ONLY by shell commands linked into the shell
> > > application.
> > > - This library will not funciton if it is used for UEFI Shell 2.0 Applications.
> > > + This library will not function if it is used for UEFI Shell 2.0 Applications.
> > >
> > > Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
> > > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> diff -
> > -
> > > git a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> > > b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> > > index 1aa1b7e..ac6c6a0 100644
> > > --- a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> > > +++ b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> > > @@ -124,7 +124,7 @@ GUID for the shell environment2 extension (main
> > > GUID above).
> > > @param[in] ParentImageHandle Handle of the image executing this
> > > operation.
> > > @param[in] CommandLine The string command line to execute.
> > > @param[in] DebugOutput TRUE indicates that errors should be
> > printed
> > > directly.
> > > - FALSE supresses error messages.
> > > + FALSE suppresses error messages.
> > >
> > > @retval EFI_SUCCESS The command line executed and completed.
> > > @retval EFI_ABORTED The operation aborted.
> > > diff --git a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c
> > > b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c
> > > index 525c1f1..faed230 100644
> > > --- a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c
> > > +++ b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c
> > > @@ -1,5 +1,5 @@
> > > /** @file
> > > - Provides application point extension for "C" style main funciton
> > > + Provides application point extension for "C" style main function
> > >
> > > Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR>
> > > This program and the accompanying materials diff --git
> > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > > index 00a4c10..e07304c 100644
> > > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > > @@ -130,7 +130,7 @@ IsDriverProt (
> > >
> > > @param[in] TheHandle The handles to show info on.
> > > @param[in] Language Language string per UEFI specification.
> > > - @param[in] Seperator Separator string between information blocks.
> > > + @param[in] Separator Separator string between information blocks.
> > > @param[in] Verbose TRUE for extra info, FALSE otherwise.
> > > @param[in] ExtraInfo TRUE for extra info, FALSE otherwise.
> > >
> > > @@ -141,7 +141,7 @@ CHAR16*
> > > GetProtocolInfoString(
> > > IN CONST EFI_HANDLE TheHandle,
> > > IN CONST CHAR8 *Language,
> > > - IN CONST CHAR16 *Seperator,
> > > + IN CONST CHAR16 *Separator,
> > > IN CONST BOOLEAN Verbose,
> > > IN CONST BOOLEAN ExtraInfo
> > > )
> > > @@ -169,7 +169,7 @@ GetProtocolInfoString(
> > > if (Temp != NULL) {
> > > ASSERT((RetVal == NULL && Size == 0) || (RetVal != NULL));
> > > if (Size != 0) {
> > > - StrnCatGrow(&RetVal, &Size, Seperator, 0);
> > > + StrnCatGrow(&RetVal, &Size, Separator, 0);
> > > }
> > > StrnCatGrow(&RetVal, &Size, L"%H", 0);
> > > StrnCatGrow(&RetVal, &Size, Temp, 0); @@ -185,7 +185,7 @@
> > > GetProtocolInfoString(
> > > StrnCatGrow(&RetVal, &Size, Temp, 0);
> > > StrnCatGrow(&RetVal, &Size, L")\r\n", 0);
> > > } else {
> > > - StrnCatGrow(&RetVal, &Size, Seperator, 0);
> > > + StrnCatGrow(&RetVal, &Size, Separator, 0);
> > > StrnCatGrow(&RetVal, &Size, Temp, 0);
> > > }
> > > FreePool(Temp);
> > > @@ -201,7 +201,7 @@ GetProtocolInfoString(
> > > }
> > >
> > > ASSERT((RetVal == NULL && Size == 0) || (RetVal != NULL));
> > > - StrnCatGrow(&RetVal, &Size, Seperator, 0);
> > > + StrnCatGrow(&RetVal, &Size, Separator, 0);
> > > return (RetVal);
> > > }
> > >
> > > diff --git
> > >
> > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands
> > > Lib.c
> > >
> > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands
> > > Lib.c
> > > index 1491ee9..7948e53 100644
> > > ---
> > >
> > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands
> > > Lib.c
> > > +++
> > >
> > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Command
> > > +++ sLib.c
> > > @@ -99,7 +99,7 @@ ShellLevel2CommandsLibConstructor (
> > > ShellCommandRegisterCommandName(L"vol", ShellCommandRunVol
> > ,
> > > ShellCommandGetManFileNameLevel2, 2, L"", TRUE,
> > gShellLevel2HiiHandle,
> > > STRING_TOKEN(STR_GET_HELP_VOL) );
> > >
> > > //
> > > - // support for permenant (built in) aliases
> > > + // support for permanent (built in) aliases
> > > //
> > > ShellCommandRegisterAlias(L"rm", L"del");
> > > ShellCommandRegisterAlias(L"ls", L"dir"); diff --git
> > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > > index 38625fe..70d9d9a 100644
> > > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> > > @@ -1492,7 +1492,7 @@ ShellCommandRunPing (
> > > }
> > >
> > > //
> > > - // Parse the paramter of count number.
> > > + // Parse the parameter of count number.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-n");
> > > if (ValueStr != NULL) {
> > > @@ -1510,7 +1510,7 @@ ShellCommandRunPing (
> > > SendNumber = DEFAULT_SEND_COUNT;
> > > }
> > > //
> > > - // Parse the paramter of buffer size.
> > > + // Parse the parameter of buffer size.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-l");
> > > if (ValueStr != NULL) {
> > > @@ -1532,7 +1532,7 @@ ShellCommandRunPing (
> > > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS));
> > >
> > > //
> > > - // Parse the paramter of source ip address.
> > > + // Parse the parameter of source ip address.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-s");
> > > if (ValueStr == NULL) {
> > > @@ -1553,7 +1553,7 @@ ShellCommandRunPing (
> > > }
> > > }
> > > //
> > > - // Parse the paramter of destination ip address.
> > > + // Parse the parameter of destination ip address.
> > > //
> > > NonOptionCount = ShellCommandLineGetCount(ParamPackage);
> > > if (NonOptionCount < 2) {
> > > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
> > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
> > > index 90a2604..265258f 100644
> > > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
> > > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
> > > @@ -1177,7 +1177,7 @@ ShellCommandRunPing6 (
> > > BufferSize = 16;
> > >
> > > //
> > > - // Parse the paramter of count number.
> > > + // Parse the parameter of count number.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-n");
> > > ValueStrPtr = ValueStr;
> > > @@ -1194,7 +1194,7 @@ ShellCommandRunPing6 (
> > > }
> > > }
> > > //
> > > - // Parse the paramter of buffer size.
> > > + // Parse the parameter of buffer size.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-l");
> > > ValueStrPtr = ValueStr;
> > > @@ -1215,7 +1215,7 @@ ShellCommandRunPing6 (
> > > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS));
> > >
> > > //
> > > - // Parse the paramter of source ip address.
> > > + // Parse the parameter of source ip address.
> > > //
> > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-s");
> > > ValueStrPtr = ValueStr;
> > > @@ -1229,7 +1229,7 @@ ShellCommandRunPing6 (
> > > }
> > > }
> > > //
> > > - // Parse the paramter of destination ip address.
> > > + // Parse the parameter of destination ip address.
> > > //
> > > NonOptionCount = ShellCommandLineGetCount(ParamPackage);
> > > ValueStr = ShellCommandLineGetRawValue (ParamPackage,
> > > (UINT32)(NonOptionCount-1));
> > > --
> > > 2.10.1
>
>
next prev parent reply other threads:[~2016-10-20 2:15 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 15:15 ` Laszlo Ersek
2016-10-19 15:33 ` Leif Lindholm
2016-10-19 7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19 7:30 ` Gao, Liming
2016-10-19 7:36 ` Zhu, Yonghong
2016-10-19 7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26 3:00 ` Long, Qin
2016-10-19 7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19 7:46 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19 8:19 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37 ` Jordan Justen
2016-10-20 8:16 ` Laszlo Ersek
2016-10-19 7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19 7:08 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:12 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19 7:07 ` Yao, Jiewen
2016-10-19 7:11 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19 7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19 7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19 7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19 8:21 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19 7:21 ` Fu, Siyuan
2016-10-26 0:53 ` Fu, Siyuan
2016-10-19 7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:50 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19 7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27 1:29 ` Zhang, Chao B
2016-11-14 3:12 ` Zhang, Chao B
2016-11-14 4:03 ` Gary Lin
2016-11-14 6:24 ` Gao, Liming
2016-11-14 8:30 ` Gary Lin
2016-10-19 7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 20:29 ` Carsey, Jaben
2016-10-20 1:55 ` Gary Lin [this message]
2016-10-19 7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19 7:46 ` Wu, Hao A
2016-10-19 7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20 1:58 ` Fan, Jeff
2016-10-20 2:08 ` Gary Lin
2016-10-20 2:45 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24 1:33 ` Wei, David
2016-10-19 7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020015514.nmt2zophuw6vwzdy@GaryWorkstation \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox