* [PATCH v2] UefiCpuPkg: Fix typos in comments
@ 2016-10-20 6:53 Gary Lin
2016-10-20 6:54 ` Fan, Jeff
0 siblings, 1 reply; 2+ messages in thread
From: Gary Lin @ 2016-10-20 6:53 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
- excute -> execute
- Retrive -> Retrieve
- possilbe -> possible
- CONTINOUS -> CONTINUOUS
- storgage -> storage
- allcated -> allocated
- triggerred -> triggered
- paramter -> parameter
- perodically -> periodically
- retore -> restore
v2:
- ruturn -> return
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
---
UefiCpuPkg/Include/Library/MtrrLib.h | 2 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 2 +-
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +-
UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 10 +++++-----
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h b/UefiCpuPkg/Include/Library/MtrrLib.h
index 36cd2cd..4973d84 100644
--- a/UefiCpuPkg/Include/Library/MtrrLib.h
+++ b/UefiCpuPkg/Include/Library/MtrrLib.h
@@ -306,7 +306,7 @@ MtrrSetAllMtrrs (
MtrrValidBitsMask & 0xfffffffffffff000ULL
@param[out] VariableMtrr The array to shadow variable MTRRs content
- @return The ruturn value of this paramter indicates the number of
+ @return The return value of this parameter indicates the number of
MTRRs which has been used.
**/
UINT32
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
index 02d5622..e55709c 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
@@ -65,7 +65,7 @@ CommonExceptionHandlerWorker (
//
if (ReservedVectors[ExceptionType].ApicId == GetApicId ()) {
//
- // Old IDT handler has been executed, then retore CPU exception content to
+ // Old IDT handler has been executed, then restore CPU exception content to
// run new exception handler.
//
ArchRestoreExceptionContext (ExceptionType, SystemContext);
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index 50b5b27..b399f1c 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -172,7 +172,7 @@ CheckAndUpdateApsStatus (
/**
Checks APs' status periodically.
- This function is triggerred by timer perodically to check the
+ This function is triggered by timer periodically to check the
state of APs for StartupAllAPs() and StartupThisAP() executed
in non-blocking mode.
diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
index 5aef772..7783b63 100644
--- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
+++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
@@ -606,7 +606,7 @@ MtrrGetMemoryAttributeInVariableMtrrWorker (
@param[in] MtrrValidAddressMask The valid address mask for MTRR
@param[out] VariableMtrr The array to shadow variable MTRRs content
- @return The return value of this paramter indicates the
+ @return The return value of this parameter indicates the
number of MTRRs which has been used.
**/
diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
index 0ccf3a4..f907b30 100644
--- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
+++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
@@ -1,7 +1,7 @@
/** @file
This module produces the EFI_PEI_S3_RESUME2_PPI.
This module works with StandAloneBootScriptExecutor to S3 resume to OS.
- This module will excute the boot script saved during last boot and after that,
+ This module will execute the boot script saved during last boot and after that,
control is passed to OS waking up handler.
Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
@@ -294,7 +294,7 @@ WriteToOsS3PerformanceData (
UINT64 Freq;
//
- // Retrive time stamp count as early as possilbe
+ // Retrieve time stamp count as early as possible
//
Ticker = GetPerformanceCounter ();
@@ -612,12 +612,12 @@ RestoreS3PageTables (
// NOTE: We have to ASSUME the page table generation format, because we do not know whole page table information.
// The whole page table is too large to be saved in SMRAM.
//
- // The assumption is : whole page table is allocated in CONTINOUS memory and CR3 points to TOP page.
+ // The assumption is : whole page table is allocated in CONTINUOUS memory and CR3 points to TOP page.
//
DEBUG ((EFI_D_ERROR, "S3NvsPageTableAddress - %x (%x)\n", (UINTN)S3NvsPageTableAddress, (UINTN)Build4GPageTableOnly));
//
- // By architecture only one PageMapLevel4 exists - so lets allocate storgage for it.
+ // By architecture only one PageMapLevel4 exists - so lets allocate storage for it.
//
PageMap = (PAGE_MAP_AND_DIRECTORY_POINTER *)S3NvsPageTableAddress;
S3NvsPageTableAddress += SIZE_4KB;
@@ -819,7 +819,7 @@ S3ResumeExecuteBootScript (
//
IdtDescriptor = (IA32_DESCRIPTOR *) (UINTN) (AcpiS3Context->IdtrProfile);
//
- // Make sure the newly allcated IDT align with 16-bytes
+ // Make sure the newly allocated IDT align with 16-bytes
//
IdtBuffer = AllocatePages (EFI_SIZE_TO_PAGES((IdtDescriptor->Limit + 1) + 16));
if (IdtBuffer == NULL) {
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] UefiCpuPkg: Fix typos in comments
2016-10-20 6:53 [PATCH v2] UefiCpuPkg: Fix typos in comments Gary Lin
@ 2016-10-20 6:54 ` Fan, Jeff
0 siblings, 0 replies; 2+ messages in thread
From: Fan, Jeff @ 2016-10-20 6:54 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
I will check it in. Thanks!
-----Original Message-----
From: Gary Lin [mailto:glin@suse.com]
Sent: Thursday, October 20, 2016 2:53 PM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff
Subject: [PATCH v2] UefiCpuPkg: Fix typos in comments
- excute -> execute
- Retrive -> Retrieve
- possilbe -> possible
- CONTINOUS -> CONTINUOUS
- storgage -> storage
- allcated -> allocated
- triggerred -> triggered
- paramter -> parameter
- perodically -> periodically
- retore -> restore
v2:
- ruturn -> return
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
---
UefiCpuPkg/Include/Library/MtrrLib.h | 2 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 2 +-
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +-
UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 10 +++++-----
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/UefiCpuPkg/Include/Library/MtrrLib.h b/UefiCpuPkg/Include/Library/MtrrLib.h
index 36cd2cd..4973d84 100644
--- a/UefiCpuPkg/Include/Library/MtrrLib.h
+++ b/UefiCpuPkg/Include/Library/MtrrLib.h
@@ -306,7 +306,7 @@ MtrrSetAllMtrrs (
MtrrValidBitsMask & 0xfffffffffffff000ULL
@param[out] VariableMtrr The array to shadow variable MTRRs content
- @return The ruturn value of this paramter indicates the number of
+ @return The return value of this parameter indicates the number of
MTRRs which has been used.
**/
UINT32
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
index 02d5622..e55709c 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiDxeSmmCpuException.c
@@ -65,7 +65,7 @@ CommonExceptionHandlerWorker (
//
if (ReservedVectors[ExceptionType].ApicId == GetApicId ()) {
//
- // Old IDT handler has been executed, then retore CPU exception content to
+ // Old IDT handler has been executed, then restore CPU
+ exception content to
// run new exception handler.
//
ArchRestoreExceptionContext (ExceptionType, SystemContext); diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index 50b5b27..b399f1c 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -172,7 +172,7 @@ CheckAndUpdateApsStatus (
/**
Checks APs' status periodically.
- This function is triggerred by timer perodically to check the
+ This function is triggered by timer periodically to check the
state of APs for StartupAllAPs() and StartupThisAP() executed
in non-blocking mode.
diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
index 5aef772..7783b63 100644
--- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
+++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c
@@ -606,7 +606,7 @@ MtrrGetMemoryAttributeInVariableMtrrWorker (
@param[in] MtrrValidAddressMask The valid address mask for MTRR
@param[out] VariableMtrr The array to shadow variable MTRRs content
- @return The return value of this paramter indicates the
+ @return The return value of this parameter indicates the
number of MTRRs which has been used.
**/
diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
index 0ccf3a4..f907b30 100644
--- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
+++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
@@ -1,7 +1,7 @@
/** @file
This module produces the EFI_PEI_S3_RESUME2_PPI.
This module works with StandAloneBootScriptExecutor to S3 resume to OS.
- This module will excute the boot script saved during last boot and after that,
+ This module will execute the boot script saved during last boot and
+ after that,
control is passed to OS waking up handler.
Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> @@ -294,7 +294,7 @@ WriteToOsS3PerformanceData (
UINT64 Freq;
//
- // Retrive time stamp count as early as possilbe
+ // Retrieve time stamp count as early as possible
//
Ticker = GetPerformanceCounter ();
@@ -612,12 +612,12 @@ RestoreS3PageTables (
// NOTE: We have to ASSUME the page table generation format, because we do not know whole page table information.
// The whole page table is too large to be saved in SMRAM.
//
- // The assumption is : whole page table is allocated in CONTINOUS memory and CR3 points to TOP page.
+ // The assumption is : whole page table is allocated in CONTINUOUS memory and CR3 points to TOP page.
//
DEBUG ((EFI_D_ERROR, "S3NvsPageTableAddress - %x (%x)\n", (UINTN)S3NvsPageTableAddress, (UINTN)Build4GPageTableOnly));
//
- // By architecture only one PageMapLevel4 exists - so lets allocate storgage for it.
+ // By architecture only one PageMapLevel4 exists - so lets allocate storage for it.
//
PageMap = (PAGE_MAP_AND_DIRECTORY_POINTER *)S3NvsPageTableAddress;
S3NvsPageTableAddress += SIZE_4KB;
@@ -819,7 +819,7 @@ S3ResumeExecuteBootScript (
//
IdtDescriptor = (IA32_DESCRIPTOR *) (UINTN) (AcpiS3Context->IdtrProfile);
//
- // Make sure the newly allcated IDT align with 16-bytes
+ // Make sure the newly allocated IDT align with 16-bytes
//
IdtBuffer = AllocatePages (EFI_SIZE_TO_PAGES((IdtDescriptor->Limit + 1) + 16));
if (IdtBuffer == NULL) {
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-20 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-20 6:53 [PATCH v2] UefiCpuPkg: Fix typos in comments Gary Lin
2016-10-20 6:54 ` Fan, Jeff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox