public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
To: edk2-devel@lists.01.org
Cc: Maurice Ma <maurice.ma@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Giri P Mudusuru <giri.p.mudusuru@intel.com>
Subject: [PATCH] IntelFsp2Pkg: Removing FSP Data Table
Date: Fri, 21 Oct 2016 06:15:55 +0530	[thread overview]
Message-ID: <20161021004555.15076-1-satya.p.yarlagadda@intel.com> (raw)

FSP Base address is part of FSP_INFO_HEADER and we don't need additional
table to report the base address of FSP components. we expect Boot
loaders to parse the FSP INFO Header to get the base address. Also, this
the FSP_DATA_TABLE is not defined in the FSP EAS and we don't see a need
for it.

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
---
 IntelFsp2Pkg/Include/FspDataTable.h                | 32 ----------------------
 .../Library/BaseFspCommonLib/FspCommonLib.c        |  1 -
 2 files changed, 33 deletions(-)
 delete mode 100644 IntelFsp2Pkg/Include/FspDataTable.h

diff --git a/IntelFsp2Pkg/Include/FspDataTable.h b/IntelFsp2Pkg/Include/FspDataTable.h
deleted file mode 100644
index 3c79f34..0000000
--- a/IntelFsp2Pkg/Include/FspDataTable.h
+++ /dev/null
@@ -1,32 +0,0 @@
-/** @file
-  The header file of FSP data table
-
-  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD License
-  which accompanies this distribution.  The full text of the license may be found at
-  http://opensource.org/licenses/bsd-license.php.
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef _FSP_DATA_TABLE_H_
-#define _FSP_DATA_TABLE_H_
-
-#pragma pack(1)
-
-#define FSP_DATA_SIGNATURE  SIGNATURE_32 ('F', 'S', 'P', 'D')
-
-typedef struct  {
-  UINT32  Signature;
-  UINT32  Length;
-  UINT32  FsptBase;
-  UINT32  FspmBase;
-  UINT32  FspsBase;
-} FSP_DATA_TABLE;
-
-#pragma pack()
-
-#endif
diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
index a9c8da6..2f2981c 100644
--- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
@@ -17,7 +17,6 @@
 #include <Library/PcdLib.h>
 #include <FspGlobalData.h>
 #include <FspEas.h>
-#include <FspDataTable.h>
 #include <Library/FspSwitchStackLib.h>
 
 #pragma pack(1)
-- 
2.10.0.windows.1



             reply	other threads:[~2016-10-21  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  0:45 Satya Yarlagadda [this message]
2016-10-21  0:59 ` [PATCH] IntelFsp2Pkg: Removing FSP Data Table Yao, Jiewen
2016-10-21  2:04 ` Mudusuru, Giri P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021004555.15076-1-satya.p.yarlagadda@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox