[PATCH 00/19] OvmfPkg, ArmVirtPkg: leave deprecated interfaces behind

[Laszlo Ersek <lersek@redhat.com>]

This series intends to solve the following BZs:

  <https://bugzilla.tianocore.org/show_bug.cgi?id=166> -- OvmfPkg: Add
  the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC
  files

  <https://bugzilla.tianocore.org/show_bug.cgi?id=165> -- ArmVirtPkg:
  Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package
  DSC files

Public branch:
<https://github.com/lersek/edk2/commits/no_deprec_ovmf_bz166_armvirt_bz165>.

The DISABLE_NEW_DEPRECATED_INTERFACES feature test macro disables the
following MdePkg library class APIs:

  BaseLib:
  - StrCpy, StrnCpy, StrCat, StrnCat, UnicodeStrToAsciiStr,
  - AsciiStrCpy, AsciiStrnCpy, AsciiStrCat, AsciiStrnCat,
    AsciiStrToUnicodeStr.

  PcdLib:
  - PcdSet8, PcdSet16, PcdSet32, PcdSet64, PcdSetPtr, PcdSetBool,
  - PcdSetEx8, PcdSetEx16, PcdSetEx32, PcdSetEx64, PcdSetExPtr,
    PcdSetExBool.

  UefiLib:
  - GetVariable, GetEfiGlobalVariable.

The series gradually weans the OvmfPkg and ArmVirtPkg modules off these.
For the 32-bit ARM builds of ArmVirtPkg platforms, I had to dip my toes
into ArmPkg a little bit, due to dependencies.

I couldn't build-test some changes (for example, the only compiler
toolchains I have access to at the moment are GCC48 for Ia32/X64, and
GCC5 for ARM/AARCH64). Some changes I could build, but not functionally
test (Xen en bloc, 32-bit ARM, RAM-emulated variables in OVMF, -bios
flag). For all of these, I liberally sprinkled the patches with Cc's and
Notes sections, asking for help. I did make an honest effort to build
the ArmVirt and OVMF platforms in as many configurations (-D ...) as I
could think of, perusing the various !if directives in the DSC files.

I recommend the "--word-diff" option of git-show, as a tool to assist
with the review.

Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Gary Lin <glin@suse.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>

Thanks
Laszlo

Laszlo Ersek (19):
  MdePkg/DebugLib.h: add ASSERT_RETURN_ERROR()
  OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls
  OvmfPkg/XenBusDxe: eliminate AsciiStrCat() calls
  OvmfPkg/EmuVariableFvbRuntimeDxe: eliminate unchecked PcdSetXX() calls
  OvmfPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls
  OvmfPkg/SmbiosVersionLib: eliminate unchecked PcdSetXX() calls
  OvmfPkg/PlatformDxe: eliminate unchecked PcdSetXX() calls
  OvmfPkg/PlatformPei: eliminate unchecked PcdSetXX() calls
  OvmfPkg/QemuFlashFvbServicesRuntimeDxe: eliminate unchecked PcdSetXX()
    calls
  OvmfPkg: disable deprecated interfaces
  ArmVirtPkg/ArmVirtGicArchLib: eliminate unchecked PcdSetXX() calls
  ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX()
    calls
  ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls
  ArmVirtPkg/ArmVirtTimerFdtClientLib: eliminate unchecked PcdSetXX()
    calls
  ArmVirtPkg/FdtPciPcdProducerLib: eliminate unchecked PcdSetXX() calls
  ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX()
    calls
  ArmPkg/ArmDisassemblerLib: replace AsciiStrCat() with AsciiStrCatS()
  ArmPkg/DefaultExceptionHandlerLib: replace AsciiStrCat() with
    AsciiStrCatS()
  ArmVirtPkg: disable deprecated interfaces

 ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c                     | 22 +++++-----
 ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c                   | 20 ++++-----
 ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c |  5 ++-
 ArmVirtPkg/ArmVirt.dsc.inc                                              |  6 +++
 ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.c                | 13 ++++--
 ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c  |  4 +-
 ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c                            | 18 ++++----
 ArmVirtPkg/Library/ArmVirtTimerFdtClientLib/ArmVirtTimerFdtClientLib.c  | 13 ++++--
 ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c          | 10 +++--
 ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c                  |  6 ++-
 MdePkg/Include/Library/DebugLib.h                                       | 27 ++++++++++++
 OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c                                  | 12 ++++--
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c                    | 14 +++++--
 OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.c               | 10 +++--
 OvmfPkg/OvmfPkgIa32.dsc                                                 |  7 ++++
 OvmfPkg/OvmfPkgIa32X64.dsc                                              |  7 ++++
 OvmfPkg/OvmfPkgX64.dsc                                                  |  7 ++++
 OvmfPkg/PlatformDxe/Platform.c                                          |  8 +++-
 OvmfPkg/PlatformPei/MemDetect.c                                         | 11 +++--
 OvmfPkg/PlatformPei/Platform.c                                          | 44 +++++++++++++-------
 OvmfPkg/PlatformPei/Xen.c                                               |  5 ++-
 OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c                 | 13 ++++--
 OvmfPkg/XenBusDxe/XenBusDxe.inf                                         |  1 +
 OvmfPkg/XenBusDxe/XenStore.c                                            | 22 +++++-----
 24 files changed, 213 insertions(+), 92 deletions(-)

-- 
2.9.2