From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glin@suse.com>
Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id D65401A1E05
 for <edk2-devel@ml01.01.org>; Sun, 23 Oct 2016 21:44:46 -0700 (PDT)
Received: from nwb-ext-pat.microfocus.com ([10.120.13.103])
 by smtp.nue.novell.com with ESMTP (TLS encrypted);
 Mon, 24 Oct 2016 06:44:44 +0200
Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.201])
 by nwb-ext-pat.microfocus.com with ESMTP (TLS encrypted);
 Mon, 24 Oct 2016 05:44:13 +0100
Date: Mon, 24 Oct 2016 12:44:06 +0800
From: Gary Lin <glin@suse.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Jordan Justen <jordan.l.justen@intel.com>
Message-ID: <20161024044406.nnd36jtmayhlmrak@GaryWorkstation>
References: <20161021212737.15974-1-lersek@redhat.com>
 <20161021212737.15974-3-lersek@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20161021212737.15974-3-lersek@redhat.com>
User-Agent: Mutt/1.6.2 (2016-07-01)
Subject: Re: [PATCH 02/19] OvmfPkg/XenBusDxe: eliminate AsciiStrCpy() calls
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2016 04:44:47 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 21, 2016 at 11:27:20PM +0200, Laszlo Ersek wrote:
> AsciiStrCpy() is deprecated / disabled under the
> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.
> 

Reviewed-by: Gary Lin <glin@suse.com> and Tested-by: Gary Lin <glin@suse.com>

> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Cc: Gary Lin <glin@suse.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=166
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     not used in my setup, testing would be appreciated
> 
>  OvmfPkg/XenBusDxe/XenStore.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
> index fb00e7393bb1..aa3ff7d3017b 100644
> --- a/OvmfPkg/XenBusDxe/XenStore.c
> +++ b/OvmfPkg/XenBusDxe/XenStore.c
> @@ -1298,11 +1298,8 @@ XenStoreTransactionEnd (
>  {
>    CHAR8 AbortStr[2];
>  
> -  if (Abort) {
> -    AsciiStrCpy (AbortStr, "F");
> -  } else {
> -    AsciiStrCpy (AbortStr, "T");
> -  }
> +  AbortStr[0] = Abort ? 'F' : 'T';
> +  AbortStr[1] = '\0';
>  
>    return XenStoreSingle (Transaction, XS_TRANSACTION_END, AbortStr, NULL, NULL);
>  }
> -- 
> 2.9.2
> 
> 
>