From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, lersek@redhat.com
Subject: Re: [PATCH 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include
Date: Tue, 25 Oct 2016 13:53:24 +0100 [thread overview]
Message-ID: <20161025125324.GF1161@bivouac.eciton.net> (raw)
In-Reply-To: <1477325206-24646-3-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Oct 24, 2016 at 05:06:42PM +0100, Ard Biesheuvel wrote:
> Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros
> that RVCT does not use or require, given it has its own AsmMacroIoLib.inc
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Not verified, but looks sensible, so:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
...ish
> ---
> ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm
> index 1417c9a78204..882f25b780cd 100644
> --- a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm
> +++ b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm
> @@ -11,10 +11,6 @@
> //
> //
>
> -#include <AsmMacroIoLib.h>
> -#include <Library/ArmCpuLib.h>
> -#include <Chipset/ArmCortexA9.h>
> -
> INCLUDE AsmMacroExport.inc
> INCLUDE AsmMacroIoLib.inc
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-10-25 12:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:06 [PATCH 0/6] ArmPkg: eliminate calls to deprecated functions Ard Biesheuvel
2016-10-24 16:06 ` [PATCH 1/6] ArmPkg: add missing components Ard Biesheuvel
2016-10-25 12:51 ` Leif Lindholm
2016-10-24 16:06 ` [PATCH 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include Ard Biesheuvel
2016-10-25 12:53 ` Leif Lindholm [this message]
2016-10-24 16:06 ` [PATCH 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions Ard Biesheuvel
2016-10-25 10:53 ` Laszlo Ersek
2016-10-25 10:56 ` Ard Biesheuvel
2016-10-25 11:08 ` Ryan Harkin
2016-10-25 11:09 ` Ard Biesheuvel
2016-10-24 16:06 ` [PATCH 4/6] ArmPkg/SemihostFs: " Ard Biesheuvel
2016-10-25 11:11 ` Laszlo Ersek
2016-10-24 16:06 ` [PATCH 5/6] ArmPkg/BdsLib: " Ard Biesheuvel
2016-10-25 11:16 ` Laszlo Ersek
2016-10-24 16:06 ` [PATCH 6/6] ArmPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES Ard Biesheuvel
2016-10-25 11:17 ` Laszlo Ersek
2016-10-25 11:32 ` [PATCH 0/6] ArmPkg: eliminate calls to deprecated functions Ryan Harkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025125324.GF1161@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox