From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 20E0F1A1E6B for ; Tue, 25 Oct 2016 05:53:28 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id b80so162137437wme.1 for ; Tue, 25 Oct 2016 05:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cPZc3auaV2WH+/AakOF7T18pP69+t4g14CfVMVEri7Y=; b=G6Psa3eKpi8/xIi3Sq4zZY/Rr1ySDcyQoulI9psL7cyvXaGnHLMD+nUA46pn32oLVA 65H1NPlO/DGT1vsKiIQ9EpK5nBbC/afoHvff+kN7WXnGQ1ev5YeMO0S0WevDKOcMjXQW zb7eMmmhq1a+ShIKTSnok7tHvTf0Rq2NkTw+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cPZc3auaV2WH+/AakOF7T18pP69+t4g14CfVMVEri7Y=; b=L68prS0si3RXAOhDfucHGHXdDlWxXybIRCS/eUQABcfuH1SizxcGfhL1INeQnCjgOt 7Bny2O0dUh8Kw/a9YTwjDHp4Ioc7EdtzeZmkIiF6LjFjo0KzEVl1Pyj7MuQRi1PwoF2r Hh6JCyaaXruwQpMvJPFAaEcevfSs1tFw9blkjMmLOZhKxmHX0mBgNPw+5l5Dwgz217Oo YMUPIsJCvz6V/xLtQAN3TFi2UDV9Hxi2pxuoawwixuT3TznN/3chrcwDE33cZe5wbOF4 VSN8YeNaXnE50hV8Xv7P3ZW9t/QZHZVj8su6tCnokhqCnEws1EqIL4hUd5Ix3OI0cvB6 2+Wg== X-Gm-Message-State: ABUngvdVEmwAjsTh18UsKX0YFOMIdzghXevQr/ym7BXDjhkbNKimDHdeHFsv4MSFclkNjMB3 X-Received: by 10.28.164.3 with SMTP id n3mr2987713wme.70.1477400006644; Tue, 25 Oct 2016 05:53:26 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n72sm3538220wmd.11.2016.10.25.05.53.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 05:53:26 -0700 (PDT) Date: Tue, 25 Oct 2016 13:53:24 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20161025125324.GF1161@bivouac.eciton.net> References: <1477325206-24646-1-git-send-email-ard.biesheuvel@linaro.org> <1477325206-24646-3-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1477325206-24646-3-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 12:53:28 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 24, 2016 at 05:06:42PM +0100, Ard Biesheuvel wrote: > Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros > that RVCT does not use or require, given it has its own AsmMacroIoLib.inc > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Not verified, but looks sensible, so: Reviewed-by: Leif Lindholm ...ish > --- > ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > index 1417c9a78204..882f25b780cd 100644 > --- a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > +++ b/ArmPkg/Drivers/ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm > @@ -11,10 +11,6 @@ > // > // > > -#include > -#include > -#include > - > INCLUDE AsmMacroExport.inc > INCLUDE AsmMacroIoLib.inc > > -- > 2.7.4 >