From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A34381D88 for ; Fri, 28 Oct 2016 05:41:00 -0700 (PDT) Received: by mail-wm0-x235.google.com with SMTP id e69so98415891wmg.0 for ; Fri, 28 Oct 2016 05:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4/pX7kp0bxST43QWrn8u2zYJXmepBs82Ob36qC8pM+g=; b=IreWBNDDH8ytzOcXFkZYktFY0NcurCc2HeOWMoo9rDjAQPl7xOrP2S+Y1Bc0K1M6uR RkSp16jmVlt+60e2JIaQvp0a3D9pRGD2fgCafuBOwjW+YNmhfAWrSSIV3f3O7MP4BEYy 547bZKOHaanQl7NanachVUqj9CJk6AThvlWZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4/pX7kp0bxST43QWrn8u2zYJXmepBs82Ob36qC8pM+g=; b=cRrUt1TJgeg/PUYnv+pHHWiHbNKfqwTf3FTRM2i6V0k9rmaJEUua/l5m8dwadL34eG xYYTDabuweiDMHazoVBTYOo9ftdO3snTFsMIWVSHoSYd8s/Ey2F3cg8ay+vmHecamCht LLMx6TEH7lwk7P2zHivy4JD0cluPUWLnvEIO/V/zp0Raa9rIWU8XLc6Je5c5OkC1W2ay sCdlkcpwLXrFyWBucdSYoE4yWekRNzyZmA9PlbvGJNsYL5OJnWFCsCX/e6SE8B12+HZu 38gGUfYKly53B4cCqwpUWEnLtINDXsd+m3JwEWSNg6xbB/fvaUs1pCi10wgVP+1sQt+K ux5w== X-Gm-Message-State: ABUngveIZC4Y23uhtDHN61LMUD0kQHicjkQuELpHYi83+GdqMB4l7IDPG0Vysgj/2CdlHipd X-Received: by 10.28.66.218 with SMTP id k87mr2803831wmi.79.1477658458920; Fri, 28 Oct 2016 05:40:58 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w1sm13948054wje.36.2016.10.28.05.40.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 05:40:58 -0700 (PDT) Date: Fri, 28 Oct 2016 13:40:56 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com, ryan.harkin@linaro.org Message-ID: <20161028124056.GI1161@bivouac.eciton.net> References: <1477651478-16830-1-git-send-email-ard.biesheuvel@linaro.org> <1477651478-16830-3-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1477651478-16830-3-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2 2/9] EmbeddedPkg: remove unused PrePiHobListPointerLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 12:41:00 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 28, 2016 at 11:44:31AM +0100, Ard Biesheuvel wrote: > Remove this unused version: all existing platforms use the one under > ArmPlatformPkg instead. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/EmbeddedPkg.dec | 1 - > EmbeddedPkg/EmbeddedPkg.dsc | 1 - > EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c | 69 -------------------- > EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf | 38 ----------- > Omap35xxPkg/Omap35xxPkg.dsc | 1 - > 5 files changed, 110 deletions(-) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > index 775d863c5f64..2c2cf41103c2 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -97,7 +97,6 @@ [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000|UINT32|0x00000009 > gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"Ebl"|VOID*|0x00000034 > > - gEmbeddedTokenSpaceGuid.PcdPrePiHobBase|131072|UINT32|0x00000040 > gEmbeddedTokenSpaceGuid.PcdPrePiStackBase|0|UINT32|0x0000000b > gEmbeddedTokenSpaceGuid.PcdPrePiStackSize|131072|UINT32|0x0000000c > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index cd1f6df06b24..5224bcefa9c7 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -184,7 +184,6 @@ [PcdsFixedAtBuild.common] > gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07 > gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000 > > - gEmbeddedTokenSpaceGuid.PcdPrePiHobBase|0 > gEmbeddedTokenSpaceGuid.PcdPrePiStackBase|0 > gEmbeddedTokenSpaceGuid.PcdPrePiStackSize|0 > > diff --git a/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c b/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c > deleted file mode 100644 > index 9065b1132fda..000000000000 > --- a/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c > +++ /dev/null > @@ -1,69 +0,0 @@ > -/** @file > -* > -* Copyright (c) 2011, ARM Limited. All rights reserved. > -* > -* This program and the accompanying materials > -* are licensed and made available under the terms and conditions of the BSD License > -* which accompanies this distribution. The full text of the license may be found at > -* http://opensource.org/licenses/bsd-license.php > -* > -* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -* > -**/ > - > -#include > -#include > -#include > -#include > - > -// > -// Have to use build system to set the original value in case we are running > -// from FLASH and globals don't work. So if you do a GetHobList() and gHobList > -// and gHobList is NULL the PCD default values are used. > -// > -VOID *gHobList = NULL; > - > - > -/** > - Returns the pointer to the HOB list. > - > - This function returns the pointer to first HOB in the list. > - > - @return The pointer to the HOB list. > - > -**/ > -VOID * > -EFIAPI > -PrePeiGetHobList ( > - VOID > - ) > -{ > - if (gHobList == NULL) { > - return (VOID *)*(UINTN*)PcdGet32 (PcdPrePiHobBase); > - } else { > - return gHobList; > - } > -} > - > - > - > -/** > - Updates the pointer to the HOB list. > - > - @param HobList Hob list pointer to store > - > -**/ > -EFI_STATUS > -EFIAPI > -PrePeiSetHobList ( > - IN VOID *HobList > - ) > -{ > - gHobList = HobList; > - > - // > - // If this code is running from ROM this could fail > - // > - return (gHobList == HobList) ? EFI_SUCCESS: EFI_UNSUPPORTED; > -} > diff --git a/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf b/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf > deleted file mode 100644 > index bfd3c209a13b..000000000000 > --- a/EmbeddedPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf > +++ /dev/null > @@ -1,38 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2011, ARM Limited. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = PrePiHobListPointerLib > - FILE_GUID = 7a6a7fc0-5ee0-11e0-b47f-0002a5d5c51b > - MODULE_TYPE = BASE > - VERSION_STRING = 1.0 > - LIBRARY_CLASS = PrePiHobListPointerLib > - > -# > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC (EBC is for build only) > -# > - > -[Sources] > - PrePiHobListPointer.c > - > -[Packages] > - MdePkg/MdePkg.dec > - EmbeddedPkg/EmbeddedPkg.dec > - > -[LibraryClasses] > - #DebugLib > - > -[FixedPcd.common] > - gEmbeddedTokenSpaceGuid.PcdPrePiHobBase > diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc > index 580be4d6340c..4a3317f255f6 100644 > --- a/Omap35xxPkg/Omap35xxPkg.dsc > +++ b/Omap35xxPkg/Omap35xxPkg.dsc > @@ -141,7 +141,6 @@ [PcdsFixedAtBuild.common] > > gEmbeddedTokenSpaceGuid.PcdFlashFvMainBase|0 > gEmbeddedTokenSpaceGuid.PcdFlashFvMainSize|0 > - gEmbeddedTokenSpaceGuid.PcdPrePiHobBase|0x80001000 > gEmbeddedTokenSpaceGuid.PcdPrePiStackBase|0x87FE0000 # stack at top of memory > gEmbeddedTokenSpaceGuid.PcdPrePiStackSize|0x20000 # 128K stack > gArmTokenSpaceGuid.PcdCpuVectorBaseAddress|0x80000000 > -- > 2.7.4 >