From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8215F81D72 for ; Fri, 28 Oct 2016 05:47:05 -0700 (PDT) Received: by mail-wm0-x22c.google.com with SMTP id 79so13314594wmy.0 for ; Fri, 28 Oct 2016 05:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dVQswi0PHLvlVqi1Y2+x9C964umI3ZEXDWWYSVUoRnA=; b=f7jjoQLg61BYEdpUiK5Lvus73TaQc5I0aJT/i3bvTILM399V1ezQavCV3qEoInvj8N DtBEJJwluCk2Fyl5KGXj/NKBgWxOpeJA03K+0DG3XOfqpig7bIfbm3HMC1DKKvteGMui 4o5wOhR6zwPsZFAIJp2HEpsfF91G/oNG/iXnw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dVQswi0PHLvlVqi1Y2+x9C964umI3ZEXDWWYSVUoRnA=; b=CYVd4gz4v+5My56tPcILApgjpf6Dy1hIKA681ffHx6cSJaP1LJ4idaGtbkCnmNX9Dj kHX9LSJf56QLQRDfIRzaS2vYd7Oy4QnQL5LtAFUNJ8yU0JipVxrmWwsAqnYasDuc42DM Rt3+dcZxa6GPILoUMlljHTxaBoeNVr6TNs9IikKT4UO65mLM8Pz4fDXXk4ODf1nTGUvh k3puD6Pdd0cKiTJ9ZYHlZSv0pYUe3cTGe1BuQAnEeYx7r4CGnRfOlz5lRhmu7YHdaQ86 wsKkUDquczstl6A9KWwInMWWI7OQKcE3PZX6so+WfMj6mV13N1I29/T8xtpGqym1kIB0 VuOw== X-Gm-Message-State: ABUngvcXp8xJUGl2p9wU+S+uTghDmJ9eCrt1k6WC6R2G5xGx9Z6NI//CWUQ/2NbmflMwzMTf X-Received: by 10.194.88.131 with SMTP id bg3mr13749688wjb.32.1477658824498; Fri, 28 Oct 2016 05:47:04 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id au8sm13975496wjc.12.2016.10.28.05.47.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 05:47:03 -0700 (PDT) Date: Fri, 28 Oct 2016 13:47:02 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com, ryan.harkin@linaro.org Message-ID: <20161028124702.GK1161@bivouac.eciton.net> References: <1477651478-16830-1-git-send-email-ard.biesheuvel@linaro.org> <1477651478-16830-5-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1477651478-16830-5-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 12:47:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 28, 2016 at 11:44:33AM +0100, Ard Biesheuvel wrote: > The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, > so add an intermediate UINTN cast to make this code build again on 32 bit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > --- > EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > index 8226c80ab466..a43ff95d03a3 100644 > --- a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > +++ b/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c > @@ -657,7 +657,7 @@ InitializeDebugAgent ( > *(UINTN *) (((UINT8 *)VectorBase) + Offset) = (UINTN)AsmCommonExceptionEntry; Yes, I know this is just context, but *twitch*. > > // Flush Caches since we updated executable stuff > - InvalidateInstructionCacheRange ((VOID *)PcdGet64(PcdCpuVectorBaseAddress), Length); > + InvalidateInstructionCacheRange ((VOID *)(UINTN)PcdGet64(PcdCpuVectorBaseAddress), Length); > > // setup a timer so gdb can break in via ctrl-c > DebugAgentTimerIntialize (); > -- > 2.7.4 Reviewed-by: Leif Lindholm