From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3732A81D9C for ; Fri, 28 Oct 2016 08:21:33 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id e69so108823484wmg.0 for ; Fri, 28 Oct 2016 08:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Z8fiBw0aLN+yCCujMi5nnG7a6/l9B2mSNHpUN3QAVcs=; b=YxyF5NlzFQ+Nxu0ROmruB9TfQFNOnwx2N62myHR8kIYXXyvDQyER6lHpzhkCXADu00 8A6eNPCCGuxyL+TPsRB5MK4ekHcxa6CEGs0TQGLgKuqU7kOYtOXbYcmuo2a/hfsGeDTQ S3VEDKzmVGuYzuJeL2P4jlJKQBUIATMY5u2LA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Z8fiBw0aLN+yCCujMi5nnG7a6/l9B2mSNHpUN3QAVcs=; b=UvKSPFnP0CP9TrqmKwRaYXvNRfjT1UbkO8B9P2R7ltsxfjA0G1YWa7RiyecvvLFJp5 Nw3cPiLCai7DsVKwEjSgYHWYJaJ0gAPKtHqY84Qxqx8IBHhakn1HmfuLF3xS9q6lHE8o KlDX9T7zSiuzh61lcmsvy+fql/RG0eYbIlbY9kwWDwTJxTtyuacNCVXz0D5WWwgX9dKA 1ajNKtrqfh70hSmcyumRx1G6lWYljRHfMgVxxcoOoeEBY08R1hlGumIoAdXk2hjJW9da mckm+lakYobwSLslT304pBhiz4LR7Uib0ruxn01h82FUM7q8ttioWqtkBwC+JppkPgt7 vYPw== X-Gm-Message-State: ABUngvf2wqXj6SLsyM/NNL9LGjyyLz635RUdlfryhHYtzNiBms87SsrRGcX8OvJ/lPihV9QJ X-Received: by 10.28.46.15 with SMTP id u15mr4331292wmu.61.1477668092323; Fri, 28 Oct 2016 08:21:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id cy7sm14616031wjc.26.2016.10.28.08.21.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 08:21:31 -0700 (PDT) Date: Fri, 28 Oct 2016 16:21:30 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20161028152130.GB1161@bivouac.eciton.net> References: <1477654974-5598-1-git-send-email-ard.biesheuvel@linaro.org> <1477654974-5598-3-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1477654974-5598-3-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/3] ArmPlatformPkg/PrePi RVCT: use relative reference to mSystemMemoryEnd X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 15:21:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 28, 2016 at 12:42:53PM +0100, Ard Biesheuvel wrote: > Bring the RVCT version of the PrePi entry point code in line with the > GCC version, by using a relative rather than an absolute reference to > the mSystemMemoryEnd variable. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm > index 1e9daf563bb6..80c2877cbdbf 100644 > --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm > +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm > @@ -48,7 +48,7 @@ _SetSVCMode > // to install the stacks at the bottom of the Firmware Device (case the FD is located > // at the top of the DRAM) > _SystemMemoryEndInit > - mov32 r1, mSystemMemoryEnd > + adrll r1, mSystemMemoryEnd > ldrd r2, r3, [r1] > teq r3, #0 > moveq r1, r2 > -- > 2.7.4 >