public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeff Fan <jeff.fan@intel.com>
To: edk2-devel@lists.01.org
Cc: Leo Duran <leo.duran@amd.com>,
	Michael Kinney <Michael.d.kinney@intel.com>,
	Feng Tian <feng.tian@intel.com>
Subject: [[POC2] 2/2] UefiCpuPkg/LocalApicLib: Add EFIAPI for GetProcessorLocationByApicId()
Date: Tue,  1 Nov 2016 10:57:00 +0800	[thread overview]
Message-ID: <20161101025700.7108-3-jeff.fan@intel.com> (raw)
In-Reply-To: <20161101025700.7108-1-jeff.fan@intel.com>

We need to add EFIAPI for all interface service including library API.

Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Leo Duran  <leo.duran@amd.com>
Cc: Michael Kinney <Michael.d.kinney@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
 UefiCpuPkg/Include/Library/LocalApicLib.h                  | 1 +
 UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c             | 1 +
 UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/UefiCpuPkg/Include/Library/LocalApicLib.h b/UefiCpuPkg/Include/Library/LocalApicLib.h
index a1611f1..fc980bc 100644
--- a/UefiCpuPkg/Include/Library/LocalApicLib.h
+++ b/UefiCpuPkg/Include/Library/LocalApicLib.h
@@ -424,6 +424,7 @@ GetApicMsiValue (
   @param[out]  Thread        Returns the processor thread ID.
 **/
 VOID
+EFIAPI
 GetProcessorLocationByApicId (
   IN  UINT32  InitialApicId,
   OUT UINT32  *Package  OPTIONAL,
diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
index 8384913..4064049 100644
--- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
+++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
@@ -955,6 +955,7 @@ GetApicMsiValue (
   @param[out]  Thread        Returns the processor thread ID.
 **/
 VOID
+EFIAPI
 GetProcessorLocationByApicId (
   IN  UINT32  InitialApicId,
   OUT UINT32  *Package  OPTIONAL,
diff --git a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
index 1e3c039..9720d26 100644
--- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
+++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
@@ -1050,6 +1050,7 @@ GetApicMsiValue (
   @param[out]  Thread        Returns the processor thread ID.
 **/
 VOID
+EFIAPI
 GetProcessorLocationByApicId (
   IN  UINT32  InitialApicId,
   OUT UINT32  *Package  OPTIONAL,
-- 
2.9.3.windows.2



  parent reply	other threads:[~2016-11-01  2:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01  2:56 [[POC2] 0/2] UefiCpuPkg/LocalApicLib: Rename GetProcessorLocation() Jeff Fan
2016-11-01  2:56 ` [[POC2] 1/2] " Jeff Fan
2016-11-01  2:57 ` Jeff Fan [this message]
2016-11-01  3:07 ` [[POC2] 0/2] " Kinney, Michael D
2016-11-01 14:56   ` Duran, Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101025700.7108-3-jeff.fan@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox