From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH 0/5] EmbeddedPkg: generic support for reusing PCI drivers for platform devices
Date: Tue, 1 Nov 2016 21:45:43 +0000 [thread overview]
Message-ID: <20161101214543.GL1161@bivouac.eciton.net> (raw)
In-Reply-To: <1477937590-10361-1-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Oct 31, 2016 at 06:13:05PM +0000, Ard Biesheuvel wrote:
> After having reviewed PciEmulation.c #6, it is time to implement this in a
> more generic way, taking into account DMA limitations and DMA coherency.
>
> So implement a new platform PCI I/O protocol, and a UEFI_DRIVER module that
> binds to those protocols to expose the PCI I/O abstraction that generic
> AHCI/XHCI etc drivers can talk to.
>
> Tested with AHCI on QEMU.
So, a) I'm really happy to see this - it doesn't solve the
peripherally connected issue with how to provide an interface to
enable UEFI drivers for devices on non-discoverable buses, but it
suggests I've been wrong to see them as the same thing.
And if this means we never have to merge #6 at all, everybody wins.
But b) I'm currently jetlagged and at 2200m altitude, so prepare for
even more silly questions than usual.
> Ard Biesheuvel (5):
> EmbeddedPkg: introduce platform PCI I/O protocol
> EmbeddedPkg: introduce platform PCI I/O registration library
> EmbeddedPkg: implement generic platform PCI I/O driver
> ArmPkg/CpuDxe: set DmaBufferAlignment according to CWG
> EmbeddedPkg/PlatformPciIoDxe: add support for non-coherent DMA
>
> ArmPkg/Drivers/CpuDxe/CpuDxe.c | 4 +-
> EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIo.c | 853 ++++++++++++++++++++
> EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIo.h | 72 ++
> EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIoDxe.c | 271 +++++++
> EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIoDxe.inf | 43 +
> EmbeddedPkg/EmbeddedPkg.dec | 2 +
> EmbeddedPkg/EmbeddedPkg.dsc | 3 +
> EmbeddedPkg/Include/Library/PlatformPciIoDeviceRegistrationLib.h | 46 ++
> EmbeddedPkg/Include/Protocol/PlatformPciIo.h | 74 ++
> EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.c | 115 +++
> EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf | 34 +
> 11 files changed, 1516 insertions(+), 1 deletion(-)
> create mode 100644 EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIo.c
> create mode 100644 EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIo.h
> create mode 100644 EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIoDxe.c
> create mode 100644 EmbeddedPkg/Drivers/PlatformPciIoDxe/PlatformPciIoDxe.inf
> create mode 100644 EmbeddedPkg/Include/Library/PlatformPciIoDeviceRegistrationLib.h
> create mode 100644 EmbeddedPkg/Include/Protocol/PlatformPciIo.h
> create mode 100644 EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.c
> create mode 100644 EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf
>
> --
> 2.7.4
>
prev parent reply other threads:[~2016-11-01 21:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 18:13 [PATCH 0/5] EmbeddedPkg: generic support for reusing PCI drivers for platform devices Ard Biesheuvel
2016-10-31 18:13 ` [PATCH 1/5] EmbeddedPkg: introduce platform PCI I/O protocol Ard Biesheuvel
2016-11-01 21:54 ` Leif Lindholm
2016-11-02 13:29 ` Ard Biesheuvel
2016-11-02 15:42 ` Leif Lindholm
2016-10-31 18:13 ` [PATCH 2/5] EmbeddedPkg: introduce platform PCI I/O registration library Ard Biesheuvel
2016-11-01 21:57 ` Leif Lindholm
2016-11-02 13:30 ` Ard Biesheuvel
2016-11-02 15:39 ` Leif Lindholm
2016-11-07 14:54 ` Evan Lloyd
2016-10-31 18:13 ` [PATCH 3/5] EmbeddedPkg: implement generic platform PCI I/O driver Ard Biesheuvel
2016-11-01 22:22 ` Leif Lindholm
2016-11-02 13:39 ` Ard Biesheuvel
2016-11-02 16:05 ` Leif Lindholm
2016-10-31 18:13 ` [PATCH 4/5] ArmPkg/CpuDxe: set DmaBufferAlignment according to CWG Ard Biesheuvel
2016-11-01 22:32 ` Leif Lindholm
2016-11-02 13:40 ` Ard Biesheuvel
2016-11-02 16:10 ` Leif Lindholm
2016-11-02 16:17 ` Ard Biesheuvel
2016-11-02 16:21 ` Leif Lindholm
2016-11-02 16:23 ` Ard Biesheuvel
2016-10-31 18:13 ` [PATCH 5/5] EmbeddedPkg/PlatformPciIoDxe: add support for non-coherent DMA Ard Biesheuvel
2016-11-01 22:43 ` Leif Lindholm
2016-11-02 13:43 ` Ard Biesheuvel
2016-11-02 16:17 ` Leif Lindholm
2016-11-01 21:45 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101214543.GL1161@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox