Re: [PATCH 2/5] EmbeddedPkg: introduce platform PCI I/O registration library

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Nov 02, 2016 at 01:30:22PM +0000, Ard Biesheuvel wrote:
> On 1 November 2016 at 21:57, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Mon, Oct 31, 2016 at 06:13:07PM +0000, Ard Biesheuvel wrote:
> >> diff --git a/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf b/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf
> >> new file mode 100644
> >> index 000000000000..282db3ab59ab
> >> --- /dev/null
> >> +++ b/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf
> >> @@ -0,0 +1,34 @@
> >> +# @file
> >> +# Copyright (c) 2016, Linaro, Ltd. All rights reserved.<BR>
> >> +#
> >> +# This program and the accompanying materials
> >> +# are licensed and made available under the terms and conditions of the BSD License
> >> +# which accompanies this distribution.  The full text of the license may be found at
> >> +# http://opensource.org/licenses/bsd-license.php
> >> +#
> >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> >> +#
> >> +
> >> +[Defines]
> >> +  INF_VERSION                    = 0x00010017
> >
> > Not 0019?
> >
> 
> What can I say, I'm old school :-)
> 
> On the one hand, I'm happy to change it, but on the other hand, I
> think it is good practice to expose the lowest version number you are
> compatible with, in case anyone wants to backport this.

That's a good point - and something that would be useful to have
official guidelines for.

Andrew, Mike - what's your take on this? Should we have a recommended
"maximum INF_VERSION" for core protocols/libraries?

Regards,

Leif