From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CD33081D3E for ; Wed, 2 Nov 2016 08:40:14 -0700 (PDT) Received: by mail-wm0-x236.google.com with SMTP id a197so148777210wmd.0 for ; Wed, 02 Nov 2016 08:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pmE8CuBdZMSS3ugT9Vur4uknnVoeiZ5frDnVTBiCREQ=; b=BVhUGbwIv3RsukcB7etBEoR6w8MWqRrLfCLFpx3KunOCZABp9C6p+yDU9sZU+im6Dq P1wNNxO27QW+bOODfrBAJUKlZ7HijnBaZPYKLgm7rPNriUIRk8QscW8l/Y38CRJscxCv d7yRWUNlTyHkvPvJBnhziPeJAPbXVMD3k/LLI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pmE8CuBdZMSS3ugT9Vur4uknnVoeiZ5frDnVTBiCREQ=; b=dbUPYDNtitoj0MqAQdPoQ5+R3xqXJZWIKYyFs71QtpGLHEOo/bdXqE1hSdWTxwXR9v 5Hl2YEqiI4r0/ceSxZbe01HAu/ZPyA/CgDgeCgaeLt5Z6MdXpHQvYQrP6vbntk2xDjqh XSRHxM0q87PHTBmsGabODl5Yp1n08i3h9XVauGzRUtypdpBv8GAk5BXXXP5nMfNM6iOc Kxwn9DqzDuYk7zO4Tr2r98Nc1WQzok4W4nPYJHnZsGJn4eFwAWZAkPoflS/F0kVQXlf0 2372sM1/FxxPoQ2YFjKjbL/giGGJptkvZNdwie+355Qe27yCowVByCP95Rf4dy2QV/rf NAzw== X-Gm-Message-State: ABUngveHVph90Z0y68V/6jO8vsS2rkKz4FHxlHLQVLYQLJsHXH1jwaZjcSnnmE4N9gY5tdCA X-Received: by 10.28.154.86 with SMTP id c83mr2971365wme.23.1478101214764; Wed, 02 Nov 2016 08:40:14 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w203sm36941615wmw.16.2016.11.02.08.40.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 08:40:14 -0700 (PDT) Date: Wed, 2 Nov 2016 15:39:31 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel-01 , Andrew Fish , "Kinney, Michael D" Message-ID: <20161102153931.GA27644@bivouac.eciton.net> References: <1477937590-10361-1-git-send-email-ard.biesheuvel@linaro.org> <1477937590-10361-3-git-send-email-ard.biesheuvel@linaro.org> <20161101215704.GN1161@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/5] EmbeddedPkg: introduce platform PCI I/O registration library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 15:40:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 02, 2016 at 01:30:22PM +0000, Ard Biesheuvel wrote: > On 1 November 2016 at 21:57, Leif Lindholm wrote: > > On Mon, Oct 31, 2016 at 06:13:07PM +0000, Ard Biesheuvel wrote: > >> diff --git a/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf b/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf > >> new file mode 100644 > >> index 000000000000..282db3ab59ab > >> --- /dev/null > >> +++ b/EmbeddedPkg/Library/PlatformPciIoDeviceRegistrationLib/PlatformPciIoDeviceRegistrationLib.inf > >> @@ -0,0 +1,34 @@ > >> +# @file > >> +# Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> >> +# > >> +# This program and the accompanying materials > >> +# are licensed and made available under the terms and conditions of the BSD License > >> +# which accompanies this distribution. The full text of the license may be found at > >> +# http://opensource.org/licenses/bsd-license.php > >> +# > >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> +# > >> + > >> +[Defines] > >> + INF_VERSION = 0x00010017 > > > > Not 0019? > > > > What can I say, I'm old school :-) > > On the one hand, I'm happy to change it, but on the other hand, I > think it is good practice to expose the lowest version number you are > compatible with, in case anyone wants to backport this. That's a good point - and something that would be useful to have official guidelines for. Andrew, Mike - what's your take on this? Should we have a recommended "maximum INF_VERSION" for core protocols/libraries? Regards, Leif