[PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs

[PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs

[Ruiyu Ni]

DumpHex() and CatSDumpHex() are public library APIs but don't have
EFIAPI modifier. Add the missing EFIAPI.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/Include/Library/ShellCommandLib.h                 | 2 ++
 ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Include/Library/ShellCommandLib.h b/ShellPkg/Include/Library/ShellCommandLib.h
index 08de133..e9a2c03 100644
--- a/ShellPkg/Include/Library/ShellCommandLib.h
+++ b/ShellPkg/Include/Library/ShellCommandLib.h
@@ -694,6 +694,7 @@ FreeBufferList (
   @param[in] UserData     Pointer to some data.
 **/
 VOID
+EFIAPI
 DumpHex (
   IN UINTN        Indent,
   IN UINTN        Offset,
@@ -711,6 +712,7 @@ DumpHex (
   @param[in] UserData   The data to print out.
 **/
 CHAR16*
+EFIAPI
 CatSDumpHex (
   IN CHAR16  *Buffer,
   IN UINTN   Indent,
diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
index 1391768..a2ebc8f 100644
--- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
+++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
@@ -1,7 +1,7 @@
 /** @file
   Provides interface to shell internal functions for shell commands.
 
-  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
   (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
 
@@ -1715,6 +1715,7 @@ FreeBufferList (
   @param[in] UserData   The data to print out.
 **/
 VOID
+EFIAPI
 DumpHex (
   IN UINTN        Indent,
   IN UINTN        Offset,
@@ -1767,6 +1768,7 @@ DumpHex (
   @param[in] UserData   The data to print out.
 **/
 CHAR16*
+EFIAPI
 CatSDumpHex (
   IN CHAR16  *Buffer,
   IN UINTN   Indent,
-- 
2.9.0.windows.1

Re: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, November 09, 2016 10:59 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public
> library APIs
> Importance: High
> 
> DumpHex() and CatSDumpHex() are public library APIs but don't have
> EFIAPI modifier. Add the missing EFIAPI.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Include/Library/ShellCommandLib.h                 | 2 ++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Include/Library/ShellCommandLib.h
> b/ShellPkg/Include/Library/ShellCommandLib.h
> index 08de133..e9a2c03 100644
> --- a/ShellPkg/Include/Library/ShellCommandLib.h
> +++ b/ShellPkg/Include/Library/ShellCommandLib.h
> @@ -694,6 +694,7 @@ FreeBufferList (
>    @param[in] UserData     Pointer to some data.
>  **/
>  VOID
> +EFIAPI
>  DumpHex (
>    IN UINTN        Indent,
>    IN UINTN        Offset,
> @@ -711,6 +712,7 @@ DumpHex (
>    @param[in] UserData   The data to print out.
>  **/
>  CHAR16*
> +EFIAPI
>  CatSDumpHex (
>    IN CHAR16  *Buffer,
>    IN UINTN   Indent,
> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> index 1391768..a2ebc8f 100644
> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Provides interface to shell internal functions for shell commands.
> 
> -  Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
>    (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
> 
> @@ -1715,6 +1715,7 @@ FreeBufferList (
>    @param[in] UserData   The data to print out.
>  **/
>  VOID
> +EFIAPI
>  DumpHex (
>    IN UINTN        Indent,
>    IN UINTN        Offset,
> @@ -1767,6 +1768,7 @@ DumpHex (
>    @param[in] UserData   The data to print out.
>  **/
>  CHAR16*
> +EFIAPI
>  CatSDumpHex (
>    IN CHAR16  *Buffer,
>    IN UINTN   Indent,
> --
> 2.9.0.windows.1