From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2F27281D9D for ; Wed, 9 Nov 2016 22:58:46 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP; 09 Nov 2016 22:58:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,617,1473145200"; d="scan'208";a="29613941" Received: from ray-dev.ccr.corp.intel.com ([10.239.9.25]) by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2016 22:58:48 -0800 From: Ruiyu Ni To: edk2-devel@lists.01.org Cc: Jaben Carsey Date: Thu, 10 Nov 2016 14:58:46 +0800 Message-Id: <20161110065846.83148-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.9.0.windows.1 Subject: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public library APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 06:58:46 -0000 DumpHex() and CatSDumpHex() are public library APIs but don't have EFIAPI modifier. Add the missing EFIAPI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Include/Library/ShellCommandLib.h | 2 ++ ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Include/Library/ShellCommandLib.h b/ShellPkg/Include/Library/ShellCommandLib.h index 08de133..e9a2c03 100644 --- a/ShellPkg/Include/Library/ShellCommandLib.h +++ b/ShellPkg/Include/Library/ShellCommandLib.h @@ -694,6 +694,7 @@ FreeBufferList ( @param[in] UserData Pointer to some data. **/ VOID +EFIAPI DumpHex ( IN UINTN Indent, IN UINTN Offset, @@ -711,6 +712,7 @@ DumpHex ( @param[in] UserData The data to print out. **/ CHAR16* +EFIAPI CatSDumpHex ( IN CHAR16 *Buffer, IN UINTN Indent, diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c index 1391768..a2ebc8f 100644 --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c @@ -1,7 +1,7 @@ /** @file Provides interface to shell internal functions for shell commands. - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.
+ Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
@@ -1715,6 +1715,7 @@ FreeBufferList ( @param[in] UserData The data to print out. **/ VOID +EFIAPI DumpHex ( IN UINTN Indent, IN UINTN Offset, @@ -1767,6 +1768,7 @@ DumpHex ( @param[in] UserData The data to print out. **/ CHAR16* +EFIAPI CatSDumpHex ( IN CHAR16 *Buffer, IN UINTN Indent, -- 2.9.0.windows.1