public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 29/33] SecurityPkg: Fix typos in comments
Date: Mon, 14 Nov 2016 16:30:38 +0800	[thread overview]
Message-ID: <20161114083038.ptvahgqi3xvjehdd@GaryWorkstation> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B1691@shsmsx102.ccr.corp.intel.com>

On Mon, Nov 14, 2016 at 06:24:50AM +0000, Gao, Liming wrote:
> Lin:
>   We don't plan to clean up all existing codes with EDKII DEBUG_ macros. We expect DEBUG_ macro will be applied with other change together. So, I propose to add this check in PatchCheck.py script. You only need to update your changed lines.  
> 
Ok, sounds like you plan to convert the macro gradually.
I will send a V2 patch.

Thanks,

Gary Lin

> Thanks
> Liming
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Gary Lin
> > Sent: Monday, November 14, 2016 12:04 PM
> > To: Zhang, Chao B <chao.b.zhang@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [PATCH 29/33] SecurityPkg: Fix typos in comments
> > 
> > On Mon, Nov 14, 2016 at 03:12:16AM +0000, Zhang, Chao B wrote:
> > > Hi Gary:
> > >   I see some warnings while running PatchChecy.py with this patch.
> > > Please help to update the patch, run PatchCheck.py(BaseTools/Scripts) &
> > re-send the patch.
> > >
> > 
> > Hi Chao,
> > 
> > PatchCheck.py showed this:
> > 
> > The commit message format passed all checks.
> > Code format is not valid:
> >  * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
> >    File: SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> >    Line:         DEBUG ((EFI_D_ERROR, "Separator Event not Measured.
> > Error!\n"));
> >  * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
> >    File: SecurityPkg/Tcg/TcgDxe/TcgDxe.c
> >    Line:         DEBUG ((EFI_D_ERROR, "Separator Event not Measured.
> > Error!\n"));
> >  * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
> >    File: SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> >    Line:         DEBUG ((EFI_D_ERROR, "Separator Event not Measured.
> > Error!\n"));
> > 
> > My patch only fixes typos (Seperator -> Separator) and I tried to avoid any
> > functional change. I found that EFI_D_ERROR is widely used in SecurityPkg
> > and
> > it'd be better to convert all EFI_D_ERROR into DEBUG_ERROR in another
> > patch.
> > What do you think?
> > 
> > Cheers,
> > 
> > Gary Lin
> > 
> > >
> > >
> > >
> > >
> > > Thanks & Best regards
> > > Chao Zhang
> > >
> > >
> > > -----Original Message-----
> > > From: Gary Lin [mailto:glin@suse.com]
> > > Sent: Wednesday, October 19, 2016 3:02 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Zhang, Chao B
> > > Subject: [PATCH 29/33] SecurityPkg: Fix typos in comments
> > >
> > > - intialized -> initialized
> > > - TURE -> TRUE
> > > - successull -> successfully
> > > - hanlder -> handler
> > > - funciton -> function
> > > - Seperator -> Separator
> > > - Sumbit -> Submit
> > >
> > > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Gary Lin <glin@suse.com>
> > > ---
> > >  SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> > | 2 +-
> > >  SecurityPkg/Include/Library/TcgPpVendorLib.h
> > | 4 ++--
> > >  SecurityPkg/Include/Library/TcgStorageOpalLib.h
> > | 2 +-
> > >  SecurityPkg/Include/Library/TrEEPpVendorLib.h
> > | 4 ++--
> > >  SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c
> > | 6 +++---
> > >
> > SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa2048
> > Sha256GuidedSectionExtractLib.c | 2 +-
> > >
> > SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa2048S
> > ha256GuidedSectionExtractLib.c | 2 +-
> > >  SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> > | 2 +-
> > >  SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > | 2 +-
> > >  SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c
> > | 2 +-
> > >  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c                                                                     | 2
> > +-
> > >  SecurityPkg/Tcg/TcgDxe/TcgDxe.c                                                                       | 2 +-
> > >  SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c                                                                     | 2
> > +-
> > >
> > SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPolic
> > y.c                           | 2 +-
> > >
> > SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileManage
> > r.h                             | 2 +-
> > >  15 files changed, 19 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> > > index ab34de7..93e3273 100644
> > > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> > > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> > > @@ -64,7 +64,7 @@ BOOLEAN
> > >
> > >    This function performs Hash digest on a data buffer of the specified size.
> > >    It can be called multiple times to compute the digest of long or
> > discontinuous data streams.
> > > -  Hash context should be already correctly intialized by HashInit(), and
> > should not be finalized
> > > +  Hash context should be already correctly initialized by HashInit(), and
> > should not be finalized
> > >    by HashFinal(). Behavior with invalid context is undefined.
> > >
> > >    If HashContext is NULL, then return FALSE.
> > > diff --git a/SecurityPkg/Include/Library/TcgPpVendorLib.h
> > b/SecurityPkg/Include/Library/TcgPpVendorLib.h
> > > index 08b3690..284aa9e 100644
> > > --- a/SecurityPkg/Include/Library/TcgPpVendorLib.h
> > > +++ b/SecurityPkg/Include/Library/TcgPpVendorLib.h
> > > @@ -42,8 +42,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> > ANY KIND, EITHER EXPRESS OR IMPLIED.
> > >  #define TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE         0xFFFFFFF1
> > >
> > >  //
> > > -// The return code for Sumbit TPM Request to Pre-OS Environment
> > > -// and Sumbit TPM Request to Pre-OS Environment 2
> > > +// The return code for Submit TPM Request to Pre-OS Environment
> > > +// and Submit TPM Request to Pre-OS Environment 2
> > >  //
> > >  #define TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS
> > 0
> > >  #define TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED
> > 1
> > > diff --git a/SecurityPkg/Include/Library/TcgStorageOpalLib.h
> > b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
> > > index 108affc..9b64a8e 100644
> > > --- a/SecurityPkg/Include/Library/TcgStorageOpalLib.h
> > > +++ b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
> > > @@ -290,7 +290,7 @@ OpalGlobalLockingRangeGenKey(
> > >  /**
> > >
> > >    The function updates the ReadLocked and WriteLocked columns of the
> > Global Locking Range.
> > > -  This funciton is required for a user1 authority, since a user1 authority shall
> > only have access to ReadLocked and WriteLocked columns
> > > +  This function is required for a user1 authority, since a user1 authority
> > shall only have access to ReadLocked and WriteLocked columns
> > >    (not ReadLockEnabled and WriteLockEnabled columns).
> > >
> > >    @param[in]      LockingSpSession    OPAL_SESSION with
> > OPAL_UID_LOCKING_SP to generate key
> > > diff --git a/SecurityPkg/Include/Library/TrEEPpVendorLib.h
> > b/SecurityPkg/Include/Library/TrEEPpVendorLib.h
> > > index d3a0767..f0dcfd9 100644
> > > --- a/SecurityPkg/Include/Library/TrEEPpVendorLib.h
> > > +++ b/SecurityPkg/Include/Library/TrEEPpVendorLib.h
> > > @@ -45,8 +45,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> > ANY KIND, EITHER EXPRESS OR IMPLIED.
> > >  #define TREE_PP_OPERATION_RESPONSE_BIOS_FAILURE         0xFFFFFFF1
> > >
> > >  //
> > > -// The return code for Sumbit TPM Request to Pre-OS Environment
> > > -// and Sumbit TPM Request to Pre-OS Environment 2
> > > +// The return code for Submit TPM Request to Pre-OS Environment
> > > +// and Submit TPM Request to Pre-OS Environment 2
> > >  //
> > >  #define TREE_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS
> > 0
> > >  #define TREE_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED
> > 1
> > > diff --git
> > a/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c
> > b/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c
> > > index 142b546..02a87f9 100644
> > > --- a/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c
> > > +++
> > b/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c
> > > @@ -469,7 +469,7 @@ Done:
> > >    @param[in] DevicePath  Points to device path.
> > >    @param[in] AccessType  The type of user access control.
> > >
> > > -  @retval    TURE        The DevicePath is in the specified List.
> > > +  @retval    TRUE        The DevicePath is in the specified List.
> > >    @retval    FALSE       The DevicePath is not in the specified List.
> > >
> > >  **/
> > > @@ -512,7 +512,7 @@ IsDevicePathInList (
> > >
> > >    @param[in] DevicePath  Points to device path
> > >
> > > -  @retval    TURE        The image pointed by DevicePath is permitted to load.
> > > +  @retval    TRUE        The image pointed by DevicePath is permitted to load.
> > >    @retval    FALSE       The image pointed by DevicePath is forbidden to load.
> > >
> > >  **/
> > > @@ -545,7 +545,7 @@ VerifyDevicePath (
> > >
> > >    @param[in] DevicePath  Points to device path.
> > >
> > > -  @retval    TURE        The image pointed by DevicePath is a boot option.
> > > +  @retval    TRUE        The image pointed by DevicePath is a boot option.
> > >    @retval    FALSE       The image pointed by DevicePath is not a boot option.
> > >
> > >  **/
> > > diff --git
> > a/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa20
> > 48Sha256GuidedSectionExtractLib.c
> > b/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa20
> > 48Sha256GuidedSectionExtractLib.c
> > > index 5f5d242..39768fb 100644
> > > ---
> > a/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa20
> > 48Sha256GuidedSectionExtractLib.c
> > > +++
> > b/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa20
> > 48Sha256GuidedSectionExtractLib.c
> > > @@ -59,7 +59,7 @@ CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };
> > >    @param SectionAttribute   The attribute of the input guided section.
> > >
> > >    @retval EFI_SUCCESS            The size of destination buffer, the size of
> > scratch buffer and
> > > -                                 the attribute of the input section are successull retrieved.
> > > +                                 the attribute of the input section are successfully
> > retrieved.
> > >    @retval EFI_INVALID_PARAMETER  The GUID in InputSection does not
> > match this instance guid.
> > >
> > >  **/
> > > diff --git
> > a/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204
> > 8Sha256GuidedSectionExtractLib.c
> > b/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204
> > 8Sha256GuidedSectionExtractLib.c
> > > index 4733703..ba1c700 100644
> > > ---
> > a/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204
> > 8Sha256GuidedSectionExtractLib.c
> > > +++
> > b/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204
> > 8Sha256GuidedSectionExtractLib.c
> > > @@ -57,7 +57,7 @@ CONST UINT8 mRsaE[] = { 0x01, 0x00, 0x01 };
> > >    @param SectionAttribute   The attribute of the input guided section.
> > >
> > >    @retval EFI_SUCCESS            The size of destination buffer, the size of
> > scratch buffer and
> > > -                                 the attribute of the input section are successull retrieved.
> > > +                                 the attribute of the input section are successfully
> > retrieved.
> > >    @retval EFI_INVALID_PARAMETER  The GUID in InputSection does not
> > match this instance guid.
> > >
> > >  **/
> > > diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> > b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> > > index 30808cd..286f5b6 100644
> > > --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> > > +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c
> > > @@ -881,7 +881,7 @@ TcgIsProtocolSupported(
> > >
> > >    @param     Discovery
> > >
> > > -  @retval    TURE if lock, FALSE if not lock.
> > > +  @retval    TRUE if lock, FALSE if not lock.
> > >  **/
> > >  BOOLEAN
> > >  EFIAPI
> > > diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > > index a0eac33..90cc51a 100644
> > > --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > > +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > > @@ -1055,7 +1055,7 @@ OpalGlobalLockingRangeGenKey(
> > >  /**
> > >
> > >    The function updates the ReadLocked and WriteLocked columns of the
> > Global Locking Range.
> > > -  This funciton is required for a user1 authority, since a user1 authority shall
> > only have access to ReadLocked and WriteLocked columns
> > > +  This function is required for a user1 authority, since a user1 authority
> > shall only have access to ReadLocked and WriteLocked columns
> > >    (not ReadLockEnabled and WriteLockEnabled columns).
> > >
> > >    @param[in]      LockingSpSession    OPAL_SESSION with
> > OPAL_UID_LOCKING_SP to generate key
> > > diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c
> > b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c
> > > index 9bf1ced..bd12d5a 100644
> > > --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c
> > > +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c
> > > @@ -406,7 +406,7 @@ OpalDriverGetDeviceList(
> > >    ReadyToBoot callback to send BlockSid command.
> > >
> > >    @param  Event   Pointer to this event
> > > -  @param  Context Event hanlder private Data
> > > +  @param  Context Event handler private Data
> > >
> > >  **/
> > >  VOID
> > > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> > > index db8d662..804929e 100644
> > > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> > > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> > > @@ -2073,7 +2073,7 @@ OnReadyToBoot (
> > >      for (PcrIndex = 0; PcrIndex < 7; PcrIndex++) {
> > >        Status = MeasureSeparatorEvent (PcrIndex);
> > >        if (EFI_ERROR (Status)) {
> > > -        DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n"));
> > > +        DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n"));
> > >        }
> > >      }
> > >
> > > diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
> > b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
> > > index 0d7e32a..3e6d87b 100644
> > > --- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
> > > +++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
> > > @@ -1160,7 +1160,7 @@ OnReadyToBoot (
> > >      for (PcrIndex = 0; PcrIndex < 8; PcrIndex++) {
> > >        Status = MeasureSeparatorEvent (PcrIndex);
> > >        if (EFI_ERROR (Status)) {
> > > -        DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n"));
> > > +        DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n"));
> > >        }
> > >      }
> > >
> > > diff --git a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> > b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> > > index fb69fa1..fa51b64 100644
> > > --- a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> > > +++ b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c
> > > @@ -1500,7 +1500,7 @@ OnReadyToBoot (
> > >      for (PcrIndex = 0; PcrIndex < 7; PcrIndex++) {
> > >        Status = MeasureSeparatorEvent (PcrIndex);
> > >        if (EFI_ERROR (Status)) {
> > > -        DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n"));
> > > +        DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n"));
> > >        }
> > >      }
> > >
> > > diff --git
> > a/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo
> > licy.c
> > b/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo
> > licy.c
> > > index 9f157f8..8382744 100644
> > > ---
> > a/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo
> > licy.c
> > > +++
> > b/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo
> > licy.c
> > > @@ -409,7 +409,7 @@ CheckNewIdentityPolicy (
> > >  /**
> > >    Save the identity policy and update UI with it.
> > >
> > > -  This funciton will verify the new identity policy, in current implementation,
> > > +  This function will verify the new identity policy, in current
> > implementation,
> > >    the identity policy can be:  T, P & P & P & ..., P | P | P | ...
> > >    Here, "T" means "True", "P" means "Credential Provider", "&" means
> > "and", "|" means "or".
> > >    Other identity policies are not supported.
> > > diff --git
> > a/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileMana
> > ger.h
> > b/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileMana
> > ger.h
> > > index afa420e..6491dc2 100644
> > > ---
> > a/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileMana
> > ger.h
> > > +++
> > b/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileMana
> > ger.h
> > > @@ -254,7 +254,7 @@ AddIdentityPolicyItem (
> > >  /**
> > >    Save the identity policy and update UI with it.
> > >
> > > -  This funciton will verify the new identity policy, in current implementation,
> > > +  This function will verify the new identity policy, in current
> > implementation,
> > >    the identity policy can be:  T, P & P & P & ..., P | P | P | ...
> > >    Here, "T" means "True", "P" means "Credential Provider", "&" means
> > "and", "|" means "or".
> > >    Other identity policies are not supported.
> > > --
> > > 2.10.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 


  reply	other threads:[~2016-11-14  8:31 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19  7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09   ` Ard Biesheuvel
2016-10-19 15:15     ` Laszlo Ersek
2016-10-19 15:33       ` Leif Lindholm
2016-10-19  7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19  7:30   ` Gao, Liming
2016-10-19  7:36   ` Zhu, Yonghong
2016-10-19  7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50   ` Ma, Maurice
2016-10-19  7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41   ` Ma, Maurice
2016-10-19  7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26  3:00   ` Long, Qin
2016-10-19  7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19  7:46   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19  8:19   ` Gao, Liming
2016-10-19  7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37   ` Jordan Justen
2016-10-20  8:16     ` Laszlo Ersek
2016-10-19  7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09   ` Ard Biesheuvel
2016-10-19  7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20  1:08   ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20  1:08   ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19  7:06   ` Yao, Jiewen
2016-10-19  7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19  7:08   ` Yao, Jiewen
2016-10-19  7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19  7:06   ` Yao, Jiewen
2016-10-19  7:12   ` Mudusuru, Giri P
2016-10-19  7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19  7:07   ` Yao, Jiewen
2016-10-19  7:11   ` Mudusuru, Giri P
2016-10-19  7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19  8:20   ` Tian, Feng
2016-10-19  7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19  7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19  8:20   ` Tian, Feng
2016-10-19  7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19  7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19  7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19  7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19  8:21   ` Gao, Liming
2016-10-19  7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19  7:21   ` Fu, Siyuan
2016-10-26  0:53   ` Fu, Siyuan
2016-10-19  7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19  7:50   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19  7:51   ` Ni, Ruiyu
2016-10-19  7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19  7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53   ` Kinney, Michael D
2016-10-19  7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00   ` Kinney, Michael D
2016-10-19  7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27  1:29   ` Zhang, Chao B
2016-11-14  3:12   ` Zhang, Chao B
2016-11-14  4:03     ` Gary Lin
2016-11-14  6:24       ` Gao, Liming
2016-11-14  8:30         ` Gary Lin [this message]
2016-10-19  7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19  7:51   ` Ni, Ruiyu
2016-10-19 20:29     ` Carsey, Jaben
2016-10-20  1:55       ` Gary Lin
2016-10-19  7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19  7:46   ` Wu, Hao A
2016-10-19  7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20  1:58   ` Fan, Jeff
2016-10-20  2:08     ` Gary Lin
2016-10-20  2:45       ` Fan, Jeff
2016-10-19  7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24  1:33   ` Wei, David
2016-10-19  7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161114083038.ptvahgqi3xvjehdd@GaryWorkstation \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox