public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: ryan.harkin@linaro.org, edk2-devel@lists.01.org,
	ard.biesheuvel@linaro.org
Subject: Re: [PATCH v5 0/9] enhance MMC
Date: Mon, 14 Nov 2016 15:53:46 +0000	[thread overview]
Message-ID: <20161114155346.GW27644@bivouac.eciton.net> (raw)
In-Reply-To: <1479019678-12621-1-git-send-email-haojian.zhuang@linaro.org>

Thanks Haojian,

I've started by pushing 1-4, which all had Tested-by and Reviewed-by
already, to edk2/master as 3201075..653bde5.

Continuing with review of 5-9.

Regards,

Leif

On Sun, Nov 13, 2016 at 02:47:49PM +0800, Haojian Zhuang wrote:
> v5:
>   * Remove patch on MediaId.
>   * Squash two PL180 patches together.
> 
> v4:
>   * Fix PL180 hang in some cases. Since the proper variable length
>     isn't set for CMD6 & ACMD51.
> 
> v3:
>   * Fix PL180 hang because of CMD6 & ACMD51 not supported.
> 
> v2:
>   * Fix print error with missing parameter.
>   * Change CMD51 to ACMD51.
>   * Add the protection after CMD55 for SD. If there's no
>     response of CMD55, skip to send ACMD51.
> 
> v1:
>   * Wait OCR busy bit free according to eMMC spec.
>   * Define ECSD structure.
>   * Add interface to set IO bus width and speed.
>   * Support to access multiple blocks.
> 
> Haojian Zhuang (9):
>   MmcDxe: wait OCR busy bit free
>   MmcDxe: move ECSD into CardInfo structure
>   MmcDxe: declare ECSD structure
>   MmcDxe: add SPEC_VERS field in CSD structure
>   MmcDxe: add interface to change io width and speed
>   MmcDxe: set io bus width before reading EXTCSD
>   MmcDxe: set iospeed and bus width in SD stack
>   MmcDxe: expand to support multiple blocks
>   PL180: update for indentifying SD
> 
>  ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c    |  29 +-
>  EmbeddedPkg/Include/Protocol/MmcHost.h           |  29 ++
>  EmbeddedPkg/Universal/MmcDxe/Mmc.h               | 176 +++++++++++-
>  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c        | 177 ++++++++----
>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 347 +++++++++++++++++++++--
>  5 files changed, 664 insertions(+), 94 deletions(-)
> 
> -- 
> 2.7.4
> 


      parent reply	other threads:[~2016-11-14 15:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-13  6:47 [PATCH v5 0/9] enhance MMC Haojian Zhuang
2016-11-13  6:47 ` [PATCH v5 1/9] MmcDxe: wait OCR busy bit free Haojian Zhuang
2016-11-13  6:47 ` [PATCH v5 2/9] MmcDxe: move ECSD into CardInfo structure Haojian Zhuang
2016-11-13  6:47 ` [PATCH v5 3/9] MmcDxe: declare ECSD structure Haojian Zhuang
2016-11-13  6:47 ` [PATCH v5 4/9] MmcDxe: add SPEC_VERS field in CSD structure Haojian Zhuang
2016-11-13  6:47 ` [PATCH v5 5/9] MmcDxe: add interface to change io width and speed Haojian Zhuang
2016-11-14 16:12   ` Leif Lindholm
2016-11-13  6:47 ` [PATCH v5 6/9] MmcDxe: set io bus width before reading EXTCSD Haojian Zhuang
2016-11-14 16:36   ` Leif Lindholm
2016-11-13  6:47 ` [PATCH v5 7/9] MmcDxe: set iospeed and bus width in SD stack Haojian Zhuang
2016-11-14 17:08   ` Leif Lindholm
2016-11-13  6:47 ` [PATCH v5 8/9] MmcDxe: expand to support multiple blocks Haojian Zhuang
2016-11-14 17:15   ` Leif Lindholm
2016-11-13  6:47 ` [PATCH v5 9/9] PL180: update for indentifying SD Haojian Zhuang
2016-11-14 17:27   ` Leif Lindholm
2016-11-14 15:53 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161114155346.GW27644@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox