From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9684081E08 for ; Mon, 14 Nov 2016 07:53:45 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id t79so106049925wmt.0 for ; Mon, 14 Nov 2016 07:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=efCKi8yB+EGD/phqAthU1oTUqLdvpVsP8wcpxoaJyaw=; b=FY/AUpUE4gebKjIcTcjA71LWq+24ntr4Z/fEXpn1OkRWJWE8502YMV7+1LGp5RbO29 qYxpaehOB8g/ZlNXLWENBtQp1Q1OYaJYusXjzeFU7a8kypRoMZIWupHNHpNnMLK6O306 4KKmWf4CTSaS2qPr6lBZn43e6fvpkGk671WMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=efCKi8yB+EGD/phqAthU1oTUqLdvpVsP8wcpxoaJyaw=; b=Yj4N28+hvqrrJ80B5NcBekHucPTGdc1HsV25Qt17fbwfDMdJjUggrSPqe/aqOqZkO6 7vGPfkRZ1vOBGc3I4gKwj25zP6u92U1R9Xs1ASAIeg+ULzp91mmC0lV45/7aUgHMVRJE a/TRRUWe99L5E9Xrvd+jTe6as95MByt7xldKnUrKGCTLYdwG9WOQGH2cdpPcYZt8jahy hahEVoDTz55xxRvR5ckD7dmYxwKlmlilOGJ4Q/sY0rjsbgwL0iu/N2C9QT1gLOS9dBdU UqwSMZWjxPg2mIbM6vqZJHkT0KgtN07mfYPmXGTMAfswUhTlG1antCF2N972m0FMu/zt fMQg== X-Gm-Message-State: ABUngvcLoi+CLYqk+os6vGSyzvuGWU/ftSz6GKWy97X9WJmk9BBv/XPsZ3giFgPXhDxvZVtV X-Received: by 10.28.148.6 with SMTP id w6mr11553300wmd.43.1479138828841; Mon, 14 Nov 2016 07:53:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 138sm1254682wms.20.2016.11.14.07.53.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2016 07:53:48 -0800 (PST) Date: Mon, 14 Nov 2016 15:53:46 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: ryan.harkin@linaro.org, edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20161114155346.GW27644@bivouac.eciton.net> References: <1479019678-12621-1-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1479019678-12621-1-git-send-email-haojian.zhuang@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v5 0/9] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 15:53:45 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Haojian, I've started by pushing 1-4, which all had Tested-by and Reviewed-by already, to edk2/master as 3201075..653bde5. Continuing with review of 5-9. Regards, Leif On Sun, Nov 13, 2016 at 02:47:49PM +0800, Haojian Zhuang wrote: > v5: > * Remove patch on MediaId. > * Squash two PL180 patches together. > > v4: > * Fix PL180 hang in some cases. Since the proper variable length > isn't set for CMD6 & ACMD51. > > v3: > * Fix PL180 hang because of CMD6 & ACMD51 not supported. > > v2: > * Fix print error with missing parameter. > * Change CMD51 to ACMD51. > * Add the protection after CMD55 for SD. If there's no > response of CMD55, skip to send ACMD51. > > v1: > * Wait OCR busy bit free according to eMMC spec. > * Define ECSD structure. > * Add interface to set IO bus width and speed. > * Support to access multiple blocks. > > Haojian Zhuang (9): > MmcDxe: wait OCR busy bit free > MmcDxe: move ECSD into CardInfo structure > MmcDxe: declare ECSD structure > MmcDxe: add SPEC_VERS field in CSD structure > MmcDxe: add interface to change io width and speed > MmcDxe: set io bus width before reading EXTCSD > MmcDxe: set iospeed and bus width in SD stack > MmcDxe: expand to support multiple blocks > PL180: update for indentifying SD > > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 +- > EmbeddedPkg/Include/Protocol/MmcHost.h | 29 ++ > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 176 +++++++++++- > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 177 ++++++++---- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 347 +++++++++++++++++++++-- > 5 files changed, 664 insertions(+), 94 deletions(-) > > -- > 2.7.4 >