From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FB2981E0C for ; Mon, 14 Nov 2016 08:12:55 -0800 (PST) Received: by mail-wm0-x22f.google.com with SMTP id a197so106809778wmd.0 for ; Mon, 14 Nov 2016 08:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MvLG0ipO7T8J7pnj0AGKkTOrmnZd6iSkWy1BFMsUics=; b=Hdt0jIfSAXXMxm265Ur8Splq/+4krrQCt2XLrKu0vSPcziN/la+jxq25dSiafGXvPv OwBDi4MkDfFaZaZbmoNX/zCzunggxeJrVRBv3yG2owSAd0vUsj2ZSX26qKDQZY2kjBXS Ul7jLgFIwGWXCsNPOeHkkpv8A3TroFDoO6AK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MvLG0ipO7T8J7pnj0AGKkTOrmnZd6iSkWy1BFMsUics=; b=N86cjmH4S/3DlZlMwNgSDCHuzcccCuS9e0s0oZ+x44fDLuLQwfk8bUyOs98B9PqwD5 F3DHTzP6wVhGzvcqpkcIMspAz6fJgPHnoKhw41TQ5SLyb/6Agwx7hmDXaw7T/Zg3Sur1 lfWDQrZWeULch5l8R4eNq+H/T7S1DGuVBOuKX+Qr50Y46JBngHR7kK2Kb2t4oGi91hS3 1f8mQqM6QroV06U4CXOKxDxT5tgJbSMhy40W+2nUYU2L+m1PQTtyvEc7/U2rVSZmpCnj oAuUsrQ0hah55c72v91rowybLz2IDlJCL8x/XJ8R7J5RNVnEB2fOwaL/rAqH95xCs5V1 TXYw== X-Gm-Message-State: ABUngvf9a+Rdcj+c6IxySzH/fab4NII5XNPY87upKAJ3BqfENpXsOkOKekPbuIfSv1zL3hQz X-Received: by 10.194.203.135 with SMTP id kq7mr14353878wjc.26.1479139978519; Mon, 14 Nov 2016 08:12:58 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y4sm29571388wjp.0.2016.11.14.08.12.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2016 08:12:58 -0800 (PST) Date: Mon, 14 Nov 2016 16:12:56 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: ryan.harkin@linaro.org, edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20161114161255.GX27644@bivouac.eciton.net> References: <1479019678-12621-1-git-send-email-haojian.zhuang@linaro.org> <1479019678-12621-6-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1479019678-12621-6-git-send-email-haojian.zhuang@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v5 5/9] MmcDxe: add interface to change io width and speed X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 16:12:55 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 13, 2016 at 02:47:54PM +0800, Haojian Zhuang wrote: > By default, MMC is initialized with 1-bit mode and less than 400KHz bus > clock. It causes MMC working inefficiently. > > Add the interface to change the bus width and speed. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang > Tested-by: Ryan Harkin So, I have no objections to this one, but on its own it provides no new functionality, and the definition it introduces is changed in the next patch. Can you squash this into 6/9 and add a line to the commit message please? / Leif > --- > EmbeddedPkg/Include/Protocol/MmcHost.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/EmbeddedPkg/Include/Protocol/MmcHost.h b/EmbeddedPkg/Include/Protocol/MmcHost.h > index 89f2e80..a242291 100644 > --- a/EmbeddedPkg/Include/Protocol/MmcHost.h > +++ b/EmbeddedPkg/Include/Protocol/MmcHost.h > @@ -131,6 +131,12 @@ typedef EFI_STATUS (EFIAPI *MMC_WRITEBLOCKDATA) ( > IN UINT32 *Buffer > ); > > +typedef EFI_STATUS (EFIAPI *MMC_SETIOS) ( > + IN EFI_MMC_HOST_PROTOCOL *This, > + IN UINT32 BusClockRate, > + IN UINT32 BusWidth > + ); > + > > struct _EFI_MMC_HOST_PROTOCOL { > > @@ -147,6 +153,8 @@ struct _EFI_MMC_HOST_PROTOCOL { > MMC_READBLOCKDATA ReadBlockData; > MMC_WRITEBLOCKDATA WriteBlockData; > > + MMC_SETIOS SetIos; > + > }; > > #define MMC_HOST_PROTOCOL_REVISION 0x00010001 // 1.1 > -- > 2.7.4 >