* [PATCH] ShellPkg: #ifndef of header files should have postfix underscore
@ 2016-11-15 1:57 Ruiyu Ni
2016-11-15 2:31 ` Bi, Dandan
0 siblings, 1 reply; 3+ messages in thread
From: Ruiyu Ni @ 2016-11-15 1:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
ShellPkg/Include/Protocol/EfiShell.h | 4 ++--
ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 4 ++--
ShellPkg/Include/Protocol/EfiShellParameters.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/ShellPkg/Include/Protocol/EfiShell.h b/ShellPkg/Include/Protocol/EfiShell.h
index 4fb8f23..8e3c2fe 100644
--- a/ShellPkg/Include/Protocol/EfiShell.h
+++ b/ShellPkg/Include/Protocol/EfiShell.h
@@ -13,8 +13,8 @@
**/
-#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_PROTOCOL_H__WRAPPER__
#include <Protocol/Shell.h>
diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
index 43cb688..50f9398 100644
--- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
+++ b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
@@ -13,8 +13,8 @@
**/
-#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
#include <Protocol/ShellDynamicCommand.h>
diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h b/ShellPkg/Include/Protocol/EfiShellParameters.h
index ba8bd1a..184b029 100644
--- a/ShellPkg/Include/Protocol/EfiShellParameters.h
+++ b/ShellPkg/Include/Protocol/EfiShellParameters.h
@@ -12,8 +12,8 @@
**/
-#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
#include <Protocol/ShellParameters.h>
--
2.9.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore
2016-11-15 1:57 [PATCH] ShellPkg: #ifndef of header files should have postfix underscore Ruiyu Ni
@ 2016-11-15 2:31 ` Bi, Dandan
2016-11-15 15:59 ` Carsey, Jaben
0 siblings, 1 reply; 3+ messages in thread
From: Bi, Dandan @ 2016-11-15 2:31 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Ni, Ruiyu
Sent: Tuesday, November 15, 2016 9:57 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
ShellPkg/Include/Protocol/EfiShell.h | 4 ++--
ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 4 ++--
ShellPkg/Include/Protocol/EfiShellParameters.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/ShellPkg/Include/Protocol/EfiShell.h b/ShellPkg/Include/Protocol/EfiShell.h
index 4fb8f23..8e3c2fe 100644
--- a/ShellPkg/Include/Protocol/EfiShell.h
+++ b/ShellPkg/Include/Protocol/EfiShell.h
@@ -13,8 +13,8 @@
**/
-#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER -#define __EFI_SHELL_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ #define
+__EFI_SHELL_PROTOCOL_H__WRAPPER__
#include <Protocol/Shell.h>
diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
index 43cb688..50f9398 100644
--- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
+++ b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
@@ -13,8 +13,8 @@
**/
-#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
#include <Protocol/ShellDynamicCommand.h>
diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h b/ShellPkg/Include/Protocol/EfiShellParameters.h
index ba8bd1a..184b029 100644
--- a/ShellPkg/Include/Protocol/EfiShellParameters.h
+++ b/ShellPkg/Include/Protocol/EfiShellParameters.h
@@ -12,8 +12,8 @@
**/
-#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
#include <Protocol/ShellParameters.h>
--
2.9.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore
2016-11-15 2:31 ` Bi, Dandan
@ 2016-11-15 15:59 ` Carsey, Jaben
0 siblings, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2016-11-15 15:59 UTC (permalink / raw)
To: Bi, Dandan, Ni, Ruiyu, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bi,
> Dandan
> Sent: Monday, November 14, 2016 6:31 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg: #ifndef of header files should have
> postfix underscore
> Importance: High
>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>
> Thanks,
> Dandan
>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, November 15, 2016 9:57 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix
> underscore
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Include/Protocol/EfiShell.h | 4 ++--
> ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 4 ++--
> ShellPkg/Include/Protocol/EfiShellParameters.h | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/ShellPkg/Include/Protocol/EfiShell.h
> b/ShellPkg/Include/Protocol/EfiShell.h
> index 4fb8f23..8e3c2fe 100644
> --- a/ShellPkg/Include/Protocol/EfiShell.h
> +++ b/ShellPkg/Include/Protocol/EfiShell.h
> @@ -13,8 +13,8 @@
>
> **/
>
> -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER -#define
> __EFI_SHELL_PROTOCOL_H__WRAPPER
> +#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ #define
> +__EFI_SHELL_PROTOCOL_H__WRAPPER__
>
> #include <Protocol/Shell.h>
>
> diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
> b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
> index 43cb688..50f9398 100644
> --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
> +++ b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
> @@ -13,8 +13,8 @@
>
> **/
>
> -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
> -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
> +#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
> +#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
>
> #include <Protocol/ShellDynamicCommand.h>
>
> diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h
> b/ShellPkg/Include/Protocol/EfiShellParameters.h
> index ba8bd1a..184b029 100644
> --- a/ShellPkg/Include/Protocol/EfiShellParameters.h
> +++ b/ShellPkg/Include/Protocol/EfiShellParameters.h
> @@ -12,8 +12,8 @@
>
> **/
>
> -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
> -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
> +#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
> +#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
>
> #include <Protocol/ShellParameters.h>
>
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-15 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 1:57 [PATCH] ShellPkg: #ifndef of header files should have postfix underscore Ruiyu Ni
2016-11-15 2:31 ` Bi, Dandan
2016-11-15 15:59 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox