From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 3/3] OvmfPkg: revert "use relaxed AP SMM synchronization mode"
Date: Tue, 15 Nov 2016 03:43:08 +0100 [thread overview]
Message-ID: <20161115024308.30612-4-lersek@redhat.com> (raw)
In-Reply-To: <20161115024308.30612-1-lersek@redhat.com>
This reverts commit 9b1e378811ff730fe4e5bbbba294ea74ef76a915 ("OvmfPkg:
use relaxed AP SMM synchronization mode").
With QEMU's broadcast SMI ability, that patch is superfluous. Reverting
the AP sync mode to the "traditional" default even eliminates some obscure
corner case issues; see the discussion rooted at
<https://lists.01.org/pipermail/edk2-devel/2016-November/004487.html>.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=230
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/OvmfPkgIa32.dsc | 1 -
OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
OvmfPkg/OvmfPkgX64.dsc | 1 -
3 files changed, 3 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 422b73c22c0e..6f3b0234f2cc 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -433,7 +433,6 @@ [PcdsFixedAtBuild]
!endif
!if $(SMM_REQUIRE) == TRUE
- gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmSyncMode|0x01
gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
!endif
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index c04486537ef0..729f81511720 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -439,7 +439,6 @@ [PcdsFixedAtBuild.X64]
!endif
!if $(SMM_REQUIRE) == TRUE
- gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmSyncMode|0x01
gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
!endif
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 230a26ba576a..c440fc1b264e 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -438,7 +438,6 @@ [PcdsFixedAtBuild]
!endif
!if $(SMM_REQUIRE) == TRUE
- gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmSyncMode|0x01
gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000
!endif
--
2.9.2
next prev parent reply other threads:[~2016-11-15 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 2:43 [PATCH 0/3] OvmfPkg: broadcast SMIs and revert to traditional AP sync mode Laszlo Ersek
2016-11-15 2:43 ` [PATCH 1/3] OvmfPkg/SmmControl2Dxe: select broadcast SMI Laszlo Ersek
2016-11-15 2:43 ` [PATCH 2/3] OvmfPkg: revert "any AP in SMM should not wait for the BSP for more than 100 ms" Laszlo Ersek
2016-11-15 2:43 ` Laszlo Ersek [this message]
2016-11-18 12:51 ` [PATCH 0/3] OvmfPkg: broadcast SMIs and revert to traditional AP sync mode Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115024308.30612-4-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox