Re: [PATCH v2 3/4] ArmPkg/ArmDmaLib: clean up abuse of device address

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 15, 2016 at 01:07:37PM +0000, Ard Biesheuvel wrote:
> On 15 November 2016 at 11:34, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> >>>> Since we should never access the device address from the CPU, there is
> >>>> no need to record it in the MAPINFO struct. Instead, record the buffer
> >>>> address in case of double buffering, since we do need to copy the contents
> >>>> (in case of a bus master write) and free the buffer (in all cases) when
> >>>> DmaUnmap() is called.
> >>>>
> >>>> Contributed-under: TianoCore Contribution Agreement 1.0
> >>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>>
> >>> For the fix itself:
> >>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >>>
> >>> However, can we wait for a few Tested-by:s to ensure this fix does not
> >>> reveal any companion bugs?
> >>>
> >>
> >> Perhaps, yes.
> >>
> >> In case anyone is up to doing that, please find the branch here
> >> https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/log/?h=armdmalib-offset
> >>
> >
> > I tested your branch on the usual victims (R0/1/2, FVP Foundation &
> > AEMv8 and TC2) and they all work fine for me.
> >
> > Tested-by: Ryan Harkin <ryan.harkin@linaro.org>

OK, so on the off-hand chance that this does break some non-upstream
drivers, I'll wait for further comments until I'm back from holiday,
28 November, before pushing this.

Additional Tested-by:s would still be appreciated.

Regards,

Leif