public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: Jeff Fan <jeff.fan@intel.com>
Subject: [PATCH 0/4] UefiCpuPkg: correct the fixed address AP stack programming on X64
Date: Thu, 17 Nov 2016 01:17:50 +0100	[thread overview]
Message-ID: <20161117001754.4383-1-lersek@redhat.com> (raw)

Recent commit 845c5be1fd9b ("UefiCpuPkg/MpInitLib: Program AP stack in
fixed address") has regressed the X64 build of OVMF; the 64-bit build of
CpuMpPei wouldn't boot.

Patches #1 and #2 clean up small nits in MpInitLib that I noticed while
analyzing the code.

Patch #3 fixes the regression.

Patch #4 fixes another bug that is currently masked in all builds of
OVMF (because all builds of OVMF include CpuMpPei), but which
nonetheless exists. I found it by code analysis.

Repo:   https://github.com/lersek/edk2.git
Branch: ap_stack_64bit

Cc: Jeff Fan <jeff.fan@intel.com>

Thanks!
Laszlo

Laszlo Ersek (4):
  UefiCpuPkg/DxeMpInitLib: remove duplicate HobLib class dependency
  UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: remove superfluous instruction
  UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: fix fatal typo
  UefiCpuPkg/MpInitLib: support 64-bit AP stack addresses

 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf  | 1 -
 UefiCpuPkg/Library/MpInitLib/MpLib.h           | 4 +++-
 UefiCpuPkg/Library/MpInitLib/MpLib.c           | 8 ++++----
 UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 2 +-
 UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm  | 8 +++-----
 5 files changed, 11 insertions(+), 12 deletions(-)

-- 
2.9.2



             reply	other threads:[~2016-11-17  0:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  0:17 Laszlo Ersek [this message]
2016-11-17  0:17 ` [PATCH 1/4] UefiCpuPkg/DxeMpInitLib: remove duplicate HobLib class dependency Laszlo Ersek
2016-11-17  0:46   ` Fan, Jeff
2016-11-17  0:17 ` [PATCH 2/4] UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: remove superfluous instruction Laszlo Ersek
2016-11-17  0:46   ` Fan, Jeff
2016-11-17  0:17 ` [PATCH 3/4] UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: fix fatal typo Laszlo Ersek
2016-11-17  0:56   ` Fan, Jeff
2016-11-17  0:17 ` [PATCH 4/4] UefiCpuPkg/MpInitLib: support 64-bit AP stack addresses Laszlo Ersek
2016-11-17  1:18   ` Fan, Jeff
2016-11-17 10:01     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117001754.4383-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox