From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD0EC81F3D for ; Wed, 16 Nov 2016 16:17:54 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 548FB624DD; Thu, 17 Nov 2016 00:17:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-80.phx2.redhat.com [10.3.116.80]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAH0Hv0I032650; Wed, 16 Nov 2016 19:17:58 -0500 From: Laszlo Ersek To: edk2-devel-01 Cc: Jeff Fan Date: Thu, 17 Nov 2016 01:17:50 +0100 Message-Id: <20161117001754.4383-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 17 Nov 2016 00:17:59 +0000 (UTC) Subject: [PATCH 0/4] UefiCpuPkg: correct the fixed address AP stack programming on X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 00:17:54 -0000 Recent commit 845c5be1fd9b ("UefiCpuPkg/MpInitLib: Program AP stack in fixed address") has regressed the X64 build of OVMF; the 64-bit build of CpuMpPei wouldn't boot. Patches #1 and #2 clean up small nits in MpInitLib that I noticed while analyzing the code. Patch #3 fixes the regression. Patch #4 fixes another bug that is currently masked in all builds of OVMF (because all builds of OVMF include CpuMpPei), but which nonetheless exists. I found it by code analysis. Repo: https://github.com/lersek/edk2.git Branch: ap_stack_64bit Cc: Jeff Fan Thanks! Laszlo Laszlo Ersek (4): UefiCpuPkg/DxeMpInitLib: remove duplicate HobLib class dependency UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: remove superfluous instruction UefiCpuPkg/MpInitLib/X64/MpFuncs.nasm: fix fatal typo UefiCpuPkg/MpInitLib: support 64-bit AP stack addresses UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 - UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 +++- UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 ++++---- UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 2 +- UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 8 +++----- 5 files changed, 11 insertions(+), 12 deletions(-) -- 2.9.2