From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3FD1981EBA for ; Thu, 17 Nov 2016 19:43:25 -0800 (PST) Received: from nwb-ext-pat.microfocus.com ([10.120.13.103]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 18 Nov 2016 04:43:28 +0100 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.201]) by nwb-ext-pat.microfocus.com with ESMTP (TLS encrypted); Fri, 18 Nov 2016 03:43:05 +0000 Date: Fri, 18 Nov 2016 11:42:59 +0800 From: Gary Lin To: Liming Gao , Laszlo Ersek Cc: edk2-devel@lists.01.org Message-ID: <20161118034259.n5xfainraki2gm7q@GaryWorkstation> References: <1479262207-25836-1-git-send-email-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <1479262207-25836-1-git-send-email-liming.gao@intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Subject: Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 03:43:25 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao Hi Liming and Laszlo, I failed to compile OVMF after applying this patch: "iasl" -p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.aml /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii Compiler aborting due to parser-detected syntax error(s) /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii 375: IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) Error 6126 - syntax error, unexpected PARSEOP_NAMESEG ^ /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii 440: Error 6126 - syntax error, unexpected '}', expecting $end and premature End-Of-File The acpica version in my system is 20160422. Did I missing any update in acpica? Thanks, Gary Lin > --- > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf > index 1187a14..2c604c3 100644 > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > @@ -37,4 +37,8 @@ > > [Packages] > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > + > +[Pcd] > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > index 2c3a314..0397722 100644 > --- a/OvmfPkg/AcpiTables/Dsdt.asl > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF ", 4) { > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort) > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >