* [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console @ 2016-11-16 2:10 Liming Gao 2016-11-16 16:18 ` Laszlo Ersek 2016-11-18 3:42 ` Gary Lin 0 siblings, 2 replies; 5+ messages in thread From: Liming Gao @ 2016-11-16 2:10 UTC (permalink / raw) To: edk2-devel; +Cc: Laszlo Ersek Cc: Laszlo Ersek <lersek@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao <liming.gao@intel.com> --- OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ OvmfPkg/AcpiTables/Dsdt.asl | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf index 1187a14..2c604c3 100644 --- a/OvmfPkg/AcpiTables/AcpiTables.inf +++ b/OvmfPkg/AcpiTables/AcpiTables.inf @@ -37,4 +37,8 @@ [Packages] MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec + +[Pcd] + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl index 2c3a314..0397722 100644 --- a/OvmfPkg/AcpiTables/Dsdt.asl +++ b/OvmfPkg/AcpiTables/Dsdt.asl @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF ", 4) { IO (Decode16, 0x278, 0x278, 0x00, 0x08) IO (Decode16, 0x370, 0x370, 0x00, 0x02) IO (Decode16, 0x378, 0x378, 0x00, 0x08) - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort) + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) IO (Decode16, 0x440, 0x440, 0x00, 0x10) IO (Decode16, 0x678, 0x678, 0x00, 0x08) IO (Decode16, 0x778, 0x778, 0x00, 0x08) -- 2.8.0.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console 2016-11-16 2:10 [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console Liming Gao @ 2016-11-16 16:18 ` Laszlo Ersek 2016-11-18 3:42 ` Gary Lin 1 sibling, 0 replies; 5+ messages in thread From: Laszlo Ersek @ 2016-11-16 16:18 UTC (permalink / raw) To: Liming Gao; +Cc: edk2-devel On 11/16/16 03:10, Liming Gao wrote: > Cc: Laszlo Ersek <lersek@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <liming.gao@intel.com> > --- > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf > index 1187a14..2c604c3 100644 > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > @@ -37,4 +37,8 @@ > > [Packages] > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > + > +[Pcd] > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > index 2c3a314..0397722 100644 > --- a/OvmfPkg/AcpiTables/Dsdt.asl > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF ", 4) { > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort) > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > Reviewed-by: Laszlo Ersek <lersek@redhat.com> Commit ad13d7d2d4a1. Thank you, Liming! Laszlo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console 2016-11-16 2:10 [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console Liming Gao 2016-11-16 16:18 ` Laszlo Ersek @ 2016-11-18 3:42 ` Gary Lin 2016-11-18 4:58 ` Gao, Liming 1 sibling, 1 reply; 5+ messages in thread From: Gary Lin @ 2016-11-18 3:42 UTC (permalink / raw) To: Liming Gao, Laszlo Ersek; +Cc: edk2-devel On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > Cc: Laszlo Ersek <lersek@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <liming.gao@intel.com> Hi Liming and Laszlo, I failed to compile OVMF after applying this patch: "iasl" -p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.aml /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii Compiler aborting due to parser-detected syntax error(s) /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii 375: IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) Error 6126 - syntax error, unexpected PARSEOP_NAMESEG ^ /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii 440: Error 6126 - syntax error, unexpected '}', expecting $end and premature End-Of-File The acpica version in my system is 20160422. Did I missing any update in acpica? Thanks, Gary Lin > --- > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf b/OvmfPkg/AcpiTables/AcpiTables.inf > index 1187a14..2c604c3 100644 > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > @@ -37,4 +37,8 @@ > > [Packages] > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > + > +[Pcd] > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > index 2c3a314..0397722 100644 > --- a/OvmfPkg/AcpiTables/Dsdt.asl > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", "OVMF ", 4) { > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, should use FixedPcdGet16 (PcdDebugIoPort) > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console 2016-11-18 3:42 ` Gary Lin @ 2016-11-18 4:58 ` Gao, Liming 2016-11-18 8:23 ` Gary Lin 0 siblings, 1 reply; 5+ messages in thread From: Gao, Liming @ 2016-11-18 4:58 UTC (permalink / raw) To: Gary Lin, Laszlo Ersek; +Cc: edk2-devel@lists.01.org Lin: Please run . edksetup.sh --reconfig to reset your local configure files. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, November 18, 2016 11:43 AM > To: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to > describe QEMU debug console > > On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > > Cc: Laszlo Ersek <lersek@redhat.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Liming Gao <liming.gao@intel.com> > > Hi Liming and Laszlo, > > I failed to compile OVMF after applying this patch: > > "iasl" - > p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTa > bles/AcpiTables/OUTPUT/./Dsdt.aml > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii > Compiler aborting due to parser-detected syntax error(s) > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii 375: IO (Decode16, FixedPcdGet16 > (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > Error 6126 - syntax error, > unexpected PARSEOP_NAMESEG ^ > > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > es/AcpiTables/OUTPUT/./Dsdt.iiii 440: > Error 6126 - syntax error, unexpected '}', expecting $end and premature > End-Of-File > > The acpica version in my system is 20160422. Did I missing any update in > acpica? > > Thanks, > > Gary Lin > > > --- > > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf > b/OvmfPkg/AcpiTables/AcpiTables.inf > > index 1187a14..2c604c3 100644 > > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > > @@ -37,4 +37,8 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + OvmfPkg/OvmfPkg.dec > > + > > +[Pcd] > > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > > index 2c3a314..0397722 100644 > > --- a/OvmfPkg/AcpiTables/Dsdt.asl > > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", > "OVMF ", 4) { > > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, > should use FixedPcdGet16 (PcdDebugIoPort) > > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 > (PcdDebugIoPort), 0x00, 0x01) > > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > > -- > > 2.8.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console 2016-11-18 4:58 ` Gao, Liming @ 2016-11-18 8:23 ` Gary Lin 0 siblings, 0 replies; 5+ messages in thread From: Gary Lin @ 2016-11-18 8:23 UTC (permalink / raw) To: Gao, Liming; +Cc: Laszlo Ersek, edk2-devel@lists.01.org On Fri, Nov 18, 2016 at 04:58:34AM +0000, Gao, Liming wrote: > Lin: > Please run . edksetup.sh --reconfig to reset your local configure files. > Ah, it worked after I clean up Conf. Thanks, Gary Lin > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Gary Lin > > Sent: Friday, November 18, 2016 11:43 AM > > To: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com> > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to > > describe QEMU debug console > > > > On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > > > Cc: Laszlo Ersek <lersek@redhat.com> > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Liming Gao <liming.gao@intel.com> > > > > Hi Liming and Laszlo, > > > > I failed to compile OVMF after applying this patch: > > > > "iasl" - > > p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTa > > bles/AcpiTables/OUTPUT/./Dsdt.aml > > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > > es/AcpiTables/OUTPUT/./Dsdt.iiii > > Compiler aborting due to parser-detected syntax error(s) > > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > > es/AcpiTables/OUTPUT/./Dsdt.iiii 375: IO (Decode16, FixedPcdGet16 > > (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01) > > Error 6126 - syntax error, > > unexpected PARSEOP_NAMESEG ^ > > > > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl > > es/AcpiTables/OUTPUT/./Dsdt.iiii 440: > > Error 6126 - syntax error, unexpected '}', expecting $end and premature > > End-Of-File > > > > The acpica version in my system is 20160422. Did I missing any update in > > acpica? > > > > Thanks, > > > > Gary Lin > > > > > --- > > > OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++ > > > OvmfPkg/AcpiTables/Dsdt.asl | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf > > b/OvmfPkg/AcpiTables/AcpiTables.inf > > > index 1187a14..2c604c3 100644 > > > --- a/OvmfPkg/AcpiTables/AcpiTables.inf > > > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf > > > @@ -37,4 +37,8 @@ > > > > > > [Packages] > > > MdePkg/MdePkg.dec > > > + OvmfPkg/OvmfPkg.dec > > > + > > > +[Pcd] > > > + gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort > > > > > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl > > > index 2c3a314..0397722 100644 > > > --- a/OvmfPkg/AcpiTables/Dsdt.asl > > > +++ b/OvmfPkg/AcpiTables/Dsdt.asl > > > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ", > > "OVMF ", 4) { > > > IO (Decode16, 0x278, 0x278, 0x00, 0x08) > > > IO (Decode16, 0x370, 0x370, 0x00, 0x02) > > > IO (Decode16, 0x378, 0x378, 0x00, 0x08) > > > - IO (Decode16, 0x402, 0x402, 0x00, 0x01) // QEMU debug console, > > should use FixedPcdGet16 (PcdDebugIoPort) > > > + IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16 > > (PcdDebugIoPort), 0x00, 0x01) > > > IO (Decode16, 0x440, 0x440, 0x00, 0x10) > > > IO (Decode16, 0x678, 0x678, 0x00, 0x08) > > > IO (Decode16, 0x778, 0x778, 0x00, 0x08) > > > -- > > > 2.8.0.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-18 8:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-16 2:10 [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console Liming Gao 2016-11-16 16:18 ` Laszlo Ersek 2016-11-18 3:42 ` Gary Lin 2016-11-18 4:58 ` Gao, Liming 2016-11-18 8:23 ` Gary Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox