Re: [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console

[Gary Lin <glin@suse.com>]

On Fri, Nov 18, 2016 at 04:58:34AM +0000, Gao, Liming wrote:
> Lin:
>    Please run . edksetup.sh --reconfig to reset your local configure files. 
> 
Ah, it worked after I clean up Conf.

Thanks,

Gary Lin

> Thanks
> Liming
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Gary Lin
> > Sent: Friday, November 18, 2016 11:43 AM
> > To: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to
> > describe QEMU debug console
> > 
> > On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote:
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Contributed-under: TianoCore Contribution Agreement 1.0
> > > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > 
> > Hi Liming and Laszlo,
> > 
> > I failed to compile OVMF after applying this patch:
> > 
> > "iasl"  -
> > p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTa
> > bles/AcpiTables/OUTPUT/./Dsdt.aml
> > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl
> > es/AcpiTables/OUTPUT/./Dsdt.iiii
> > Compiler aborting due to parser-detected syntax error(s)
> > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl
> > es/AcpiTables/OUTPUT/./Dsdt.iiii    375:             IO (Decode16, FixedPcdGet16
> > (PcdDebugIoPort), FixedPcdGet16 (PcdDebugIoPort), 0x00, 0x01)
> > Error    6126 -                                                                                  syntax error,
> > unexpected PARSEOP_NAMESEG ^
> > 
> > /home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTabl
> > es/AcpiTables/OUTPUT/./Dsdt.iiii    440:
> > Error    6126 - syntax error, unexpected '}', expecting $end and premature
> > End-Of-File
> > 
> > The acpica version in my system is 20160422. Did I missing any update in
> > acpica?
> > 
> > Thanks,
> > 
> > Gary Lin
> > 
> > > ---
> > >  OvmfPkg/AcpiTables/AcpiTables.inf | 4 ++++
> > >  OvmfPkg/AcpiTables/Dsdt.asl       | 2 +-
> > >  2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/OvmfPkg/AcpiTables/AcpiTables.inf
> > b/OvmfPkg/AcpiTables/AcpiTables.inf
> > > index 1187a14..2c604c3 100644
> > > --- a/OvmfPkg/AcpiTables/AcpiTables.inf
> > > +++ b/OvmfPkg/AcpiTables/AcpiTables.inf
> > > @@ -37,4 +37,8 @@
> > >
> > >  [Packages]
> > >    MdePkg/MdePkg.dec
> > > +  OvmfPkg/OvmfPkg.dec
> > > +
> > > +[Pcd]
> > > +  gUefiOvmfPkgTokenSpaceGuid.PcdDebugIoPort
> > >
> > > diff --git a/OvmfPkg/AcpiTables/Dsdt.asl b/OvmfPkg/AcpiTables/Dsdt.asl
> > > index 2c3a314..0397722 100644
> > > --- a/OvmfPkg/AcpiTables/Dsdt.asl
> > > +++ b/OvmfPkg/AcpiTables/Dsdt.asl
> > > @@ -581,7 +581,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ",
> > "OVMF    ", 4) {
> > >              IO (Decode16, 0x278, 0x278, 0x00, 0x08)
> > >              IO (Decode16, 0x370, 0x370, 0x00, 0x02)
> > >              IO (Decode16, 0x378, 0x378, 0x00, 0x08)
> > > -            IO (Decode16, 0x402, 0x402, 0x00, 0x01)        // QEMU debug console,
> > should use FixedPcdGet16 (PcdDebugIoPort)
> > > +            IO (Decode16, FixedPcdGet16 (PcdDebugIoPort), FixedPcdGet16
> > (PcdDebugIoPort), 0x00, 0x01)
> > >              IO (Decode16, 0x440, 0x440, 0x00, 0x10)
> > >              IO (Decode16, 0x678, 0x678, 0x00, 0x08)
> > >              IO (Decode16, 0x778, 0x778, 0x00, 0x08)
> > > --
> > > 2.8.0.windows.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
>