From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6EC881E89 for ; Tue, 22 Nov 2016 18:36:54 -0800 (PST) Received: by mail-qk0-x242.google.com with SMTP id y205so14555qkb.1 for ; Tue, 22 Nov 2016 18:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=SsGIRsX+NlZKF8ZrFd4q7dP3bO+vvYs7IaEhGLs9gTA=; b=p94Wl17B5iI1+mNwjxrAq/nW6VBRJS6XO28OLsrRJKkNW5FlrJPuVH08a4YfHISZF2 fua3hBLstR91KjF+/s6pGoNHQZhf4lFwSeZblsTrDsyLdQNfQVbi2IuG064d7MjvhmCs 6VRw2WQbYUDjE1rZ6XnJliPaImDkHwmHmC1F9+HimbIGfrJpkDuLUFBP9QsMmp153c6R 6kGHCCs+NVvtstU2DGch0BbA/tWQqn3XcM6jLWGoGkUW5fyMOxystUqLGcufUdBLl8RK knC/IBs/vxEheis2FmxUuSr3IPcgcgqt599sNrTrSAEPqkwlPaYy4WkvKZaTT9CBAGLR D3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=SsGIRsX+NlZKF8ZrFd4q7dP3bO+vvYs7IaEhGLs9gTA=; b=Nt+jIsYvl8zWj8Dx+6OQTIFlMMsA0Wv2cBUhLCduoyZrXOoDctKMNajYQK4BsLOUqb NvFcjFgHDrRuQRkBOceT1aHvgr7fczCLgQKR2ReuWX1ikwPV/eAJB5/L7Q1SmyljebBv kKJjI0lwcJMp8NMmx5tYyClD6I8WNSOMdu/4AkeERJ5OKmwWPQLh+r0bht5Cx1MFFDj7 Cr5Psp9FvAMtaUveKaSHlfEnLcNMZJPkNVIL9wgFC1vw0O1u9VYf/b69Vefwi4JsDNHr ESj1EXzrFxms11oQDQsKXo+B0GBPSsp2gycm3TPT3sLmrZ+CIb0+OUwf2DyradgnKV7X PB+Q== X-Gm-Message-State: AKaTC02uPi0MsjpLzwM5LrdfZ9wsoT8rUr8rMy2TjEnGtNZk45yH+AJZehjXf9bf5CelgQ== X-Received: by 10.55.176.131 with SMTP id z125mr668113qke.286.1479868613930; Tue, 22 Nov 2016 18:36:53 -0800 (PST) Received: from dhcp-adc-twvpn-3-vpnpool-10-154-104-253.vpn.oracle.com.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id 14sm15258473qtp.19.2016.11.22.18.36.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2016 18:36:53 -0800 (PST) Sender: Konrad Rzeszutek From: Konrad Rzeszutek Wilk To: lersek@redhat.com, edk2-devel@ml01.01.org Cc: xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk Date: Tue, 22 Nov 2016 21:36:43 -0500 Message-Id: <20161123023643.7106-2-konrad@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161123023643.7106-1-konrad@kernel.org> References: <9faa1698-7471-3f47-e552-8da23c0f0195@redhat.com> <20161123023643.7106-1-konrad@kernel.org> Subject: [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 02:36:54 -0000 >>From Laszlo: " change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - add a branch (with multiple patterns if necessary) for gcc-4.3 and earlier to exit with an error message / failure (those compiler versions are unsupported)" Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Konrad Rzeszutek Wilk --- v1: First submission v2: Redo it per Laszlo suggestion. OvmfPkg/build.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index eb5eb73..cab7c70 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -83,6 +83,13 @@ case `uname` in Linux*) gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') case $gcc_version in + 4.1.[0-0].*|4.2.*|4.3.*) + echo OvmfPkg requires GCC4.4 or later + exit 1 + ;; + 4.4.*) + TARGET_TOOLS=GCC44 + ;; 4.5.*) TARGET_TOOLS=GCC45 ;; @@ -95,11 +102,11 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*) TARGET_TOOLS=GCC49 ;; *) - TARGET_TOOLS=GCC44 + TARGET_TOOLS=GCC5 ;; esac esac -- 2.9.3