From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE42681ED1 for ; Wed, 23 Nov 2016 17:15:32 -0800 (PST) Received: by mail-qk0-x241.google.com with SMTP id x190so2193679qkb.0 for ; Wed, 23 Nov 2016 17:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=xpurpLk1FgAs1qKEJY+zreRDDhkD+zDK+PftoPrD3EQ=; b=D40ow10JTa6BtwxUiVX8SakpP4MC90DYMDG3L4UDReZ/fzm+gjR9fHA2Db+9GFtUIs Gl+Ec0SrWomT2kL32KmY/OjMEDBVmXE56gQtd8xP07UWSQ6CdvDIPSoCJUBwfywCiCC4 wr08duuMGLUmL7ChvEkpXVjETMAjUYc0DzDdBZtOqoFyExnIK4vx9Slu8lsUVuDCqvsc NP2OluVDsXnrHl/pkKyd5FU8QcVHG0Psi1e2NGsr5qsKi/hdesWOoYFwdwbkdLLfj1NP n2TEggsFv/7BJ5mY8hqt3w7pNGSpohQ+qVjUZ14KI2YnoQ27SfK8+RNYPIql9yMoGNMF FNGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=xpurpLk1FgAs1qKEJY+zreRDDhkD+zDK+PftoPrD3EQ=; b=ODr8UegLsbUy7+POW7tzTpkZ5Xn9VTZNeKfkqDEGaLcw5SZyLaSvQzJivosisIlOZM JudFO7SdpzPmDdm4Co+gpy974dNZ4Exp3qTlAuYiMAGLTVAnS0ENc031dLym86gDaW4l sD6C/nM/lLPDRVdQA7XsfRnCgldAmEDwMrai3EfEqxejjRzGnj3JLjAfmTMCDiSmN1c2 hifdW8VpKRb27HSXY+IJkXaWunSoCLIVa9pgpOSt5n2cOk2MbCpaukffICkjsl59/JKv z+ECsxEk8NEYZZDHxR/Ql+6VDXro4fF9UuWhEZVggdBhe/E5yrWFPbGvkSwmfzFJaN2X E6iA== X-Gm-Message-State: AKaTC03JP0Rj50QQ7W8KagRNTH9reLKCNuSsfvUwNIIuH4WU0FwIV51k40e9l/We7jKHxQ== X-Received: by 10.55.116.135 with SMTP id p129mr6326833qkc.54.1479950132112; Wed, 23 Nov 2016 17:15:32 -0800 (PST) Received: from localhost.localdomain.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id 124sm17727114qki.14.2016.11.23.17.15.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 17:15:31 -0800 (PST) Sender: Konrad Rzeszutek From: Konrad Rzeszutek Wilk To: lersek@redhat.com, edk2-devel@ml01.01.org Cc: xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk Date: Wed, 23 Nov 2016 20:15:23 -0500 Message-Id: <20161124011523.18281-2-konrad@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161124011523.18281-1-konrad@kernel.org> References: <0846b3b6-ef4b-df3a-d516-28995215e1af@redhat.com> <20161124011523.18281-1-konrad@kernel.org> Subject: [PATCH v3] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 01:15:33 -0000 v2: * Changes suggested by Laszlo: - change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - generate error for GCC < 4.4 In v3, also generate error for really GCC < 4.4, like GCC 1. Reviewed-by: Laszlo Ersek Reviewed-by: Jordan Justen Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial v2: Redo it per Laszlo suggestions v3: Fix up commit message per Jordan Also generate error for prehistoric versions of GCC, like 1. --- OvmfPkg/build.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index eb5eb73..95fe8fb 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -83,6 +83,13 @@ case `uname` in Linux*) gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') case $gcc_version in + [1-3].*|4.[0-3].*) + echo OvmfPkg requires GCC4.4 or later + exit 1 + ;; + 4.4.*) + TARGET_TOOLS=GCC44 + ;; 4.5.*) TARGET_TOOLS=GCC45 ;; @@ -95,11 +102,11 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*) TARGET_TOOLS=GCC49 ;; *) - TARGET_TOOLS=GCC44 + TARGET_TOOLS=GCC5 ;; esac esac -- 2.9.3