* [PATCH 1/7] OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-01 18:24 ` Laszlo Ersek
2016-12-01 15:53 ` [PATCH 2/7] QuarkSocPkg: " Leif Lindholm
` (8 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move OvmfPkg to use the MdeModulePkg
versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
OvmfPkg/OvmfPkgX64.dsc | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index d913030..81f7521 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -505,7 +505,7 @@
#
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
@@ -550,7 +550,7 @@
#
MdeModulePkg/Core/Dxe/DxeMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
}
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 8143ea9..f7855b6 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -513,7 +513,7 @@
#
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
@@ -559,7 +559,7 @@
#
MdeModulePkg/Core/Dxe/DxeMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
}
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index d48d603..e933a41 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -512,7 +512,7 @@
#
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
#
@@ -557,7 +557,7 @@
#
MdeModulePkg/Core/Dxe/DxeMain.inf {
<LibraryClasses>
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
}
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 1/7] OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 ` [PATCH 1/7] OvmfPkg: Remove " Leif Lindholm
@ 2016-12-01 18:24 ` Laszlo Ersek
0 siblings, 0 replies; 21+ messages in thread
From: Laszlo Ersek @ 2016-12-01 18:24 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Michael D Kinney,
Kelly Steele, David Wei, Mang Guo, Ard Biesheuvel
On 12/01/16 16:53, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Since the libraries are identical, move OvmfPkg to use the MdeModulePkg
> versions instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
Since you can push, I'll let you. :)
Thanks
Laszlo
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index d913030..81f7521 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -505,7 +505,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -550,7 +550,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 8143ea9..f7855b6 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -513,7 +513,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -559,7 +559,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index d48d603..e933a41 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -512,7 +512,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -557,7 +557,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/7] QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-12-01 15:53 ` [PATCH 1/7] OvmfPkg: Remove " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-01 15:53 ` [PATCH 3/7] BeagleBoardPkg: " Leif Lindholm
` (7 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move iQuarkSocPkg to use the
MdeModulePkg versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
---
QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/QuarkSocPkg/QuarkSocPkg.dsc b/QuarkSocPkg/QuarkSocPkg.dsc
index 42bb5bb..9e37a0b 100644
--- a/QuarkSocPkg/QuarkSocPkg.dsc
+++ b/QuarkSocPkg/QuarkSocPkg.dsc
@@ -116,7 +116,7 @@
#
# Misc
#
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH 3/7] BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-12-01 15:53 ` [PATCH 1/7] OvmfPkg: Remove " Leif Lindholm
2016-12-01 15:53 ` [PATCH 2/7] QuarkSocPkg: " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-01 15:53 ` [PATCH 4/7] EmbeddedPkg: " Leif Lindholm
` (6 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move BeagleBoardPkg to use the
MdeModulePkg versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index f40095a..b074b92 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -141,7 +141,7 @@
[LibraryClasses.common.SEC]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
@@ -163,7 +163,7 @@
[LibraryClasses.common.PEI_CORE]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
[LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH 4/7] EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (2 preceding siblings ...)
2016-12-01 15:53 ` [PATCH 3/7] BeagleBoardPkg: " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-01 15:53 ` [PATCH 5/7] DuetPkg: " Leif Lindholm
` (5 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move EmbeddedPkg to use the
MdeModulePkg versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
index eb7af80..ba4f1ea 100644
--- a/EmbeddedPkg/EmbeddedPkg.dsc
+++ b/EmbeddedPkg/EmbeddedPkg.dsc
@@ -60,7 +60,7 @@
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
EfiFileLib|EmbeddedPkg/Library/EfiFileLib/EfiFileLib.inf
- ReportStatusCodeLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (3 preceding siblings ...)
2016-12-01 15:53 ` [PATCH 4/7] EmbeddedPkg: " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-02 2:01 ` Ni, Ruiyu
2016-12-01 15:53 ` [PATCH 6/7] EmulatorPkg: " Leif Lindholm
` (4 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move DuetPkg to use the MdeModulePkg
versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
DuetPkg/DuetPkgIa32.dsc | 4 ++--
DuetPkg/DuetPkgX64.dsc | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/DuetPkg/DuetPkgIa32.dsc b/DuetPkg/DuetPkgIa32.dsc
index 3b59343..7dd963b 100644
--- a/DuetPkg/DuetPkgIa32.dsc
+++ b/DuetPkg/DuetPkgIa32.dsc
@@ -178,7 +178,7 @@
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
<LibraryClasses>
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
}
@@ -211,7 +211,7 @@
DuetPkg/EfiLdr/EfiLdr.inf {
<LibraryClasses>
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
<LibraryClasses>
diff --git a/DuetPkg/DuetPkgX64.dsc b/DuetPkg/DuetPkgX64.dsc
index c23354a..1b08a95 100644
--- a/DuetPkg/DuetPkgX64.dsc
+++ b/DuetPkg/DuetPkgX64.dsc
@@ -179,7 +179,7 @@
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
<LibraryClasses>
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
}
@@ -212,7 +212,7 @@
DuetPkg/EfiLdr/EfiLdr.inf {
<LibraryClasses>
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
<LibraryClasses>
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 ` [PATCH 5/7] DuetPkg: " Leif Lindholm
@ 2016-12-02 2:01 ` Ni, Ruiyu
0 siblings, 0 replies; 21+ messages in thread
From: Ni, Ruiyu @ 2016-12-02 2:01 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel@lists.01.org
Cc: Justen, Jordan L, Andrew Fish, Laszlo Ersek, Kinney, Michael D,
Steele, Kelly, Wei, David, Guo, Mang, Ard Biesheuvel
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Regards,
Ray
>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Thursday, December 1, 2016 11:53 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Laszlo
>Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Wei,
>David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Subject: [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
>
>LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
>from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
>kept for compatibility.
>
>Since the libraries are identical, move DuetPkg to use the MdeModulePkg
>versions instead.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>---
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/DuetPkg/DuetPkgIa32.dsc b/DuetPkg/DuetPkgIa32.dsc
>index 3b59343..7dd963b 100644
>--- a/DuetPkg/DuetPkgIa32.dsc
>+++ b/DuetPkg/DuetPkgIa32.dsc
>@@ -178,7 +178,7 @@
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
> gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
> <LibraryClasses>
>-
>DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>
>ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
> }
>
>@@ -211,7 +211,7 @@
> DuetPkg/EfiLdr/EfiLdr.inf {
> <LibraryClasses>
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
> IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
> <LibraryClasses>
>diff --git a/DuetPkg/DuetPkgX64.dsc b/DuetPkg/DuetPkgX64.dsc
>index c23354a..1b08a95 100644
>--- a/DuetPkg/DuetPkgX64.dsc
>+++ b/DuetPkg/DuetPkgX64.dsc
>@@ -179,7 +179,7 @@
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F
> gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000042
> <LibraryClasses>
>-
>DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>
>ReportStatusCodeLib|DuetPkg/Library/DxeCoreReportStatusCodeLibFromHob/DxeCoreReportStatusCodeLibFromHob.inf
> }
>
>@@ -212,7 +212,7 @@
> DuetPkg/EfiLdr/EfiLdr.inf {
> <LibraryClasses>
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
> IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf {
> <LibraryClasses>
>--
>2.10.2
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 6/7] EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (4 preceding siblings ...)
2016-12-01 15:53 ` [PATCH 5/7] DuetPkg: " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-01 15:53 ` [PATCH 7/7] Vlv2TbltDevicePkg: " Leif Lindholm
` (3 subsequent siblings)
9 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move EmulatorPkg to use the
MdeModulePkg versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
EmulatorPkg/EmulatorPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index f516adf..b96b9f2 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -101,7 +101,7 @@
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
PeiServicesTablePointerLib|EmulatorPkg/Library/PeiServicesTablePointerLibMagicPage/PeiServicesTablePointerLibMagicPage.inf
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
@@ -281,7 +281,7 @@
SerialPortLib|EmulatorPkg/Library/DxeEmuStdErrSerialPortLib/DxeEmuStdErrSerialPortLib.inf
DxeEmuLib|EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.inf
NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
<LibraryClasses>
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (5 preceding siblings ...)
2016-12-01 15:53 ` [PATCH 6/7] EmulatorPkg: " Leif Lindholm
@ 2016-12-01 15:53 ` Leif Lindholm
2016-12-05 17:32 ` Leif Lindholm
2016-12-01 18:14 ` [PATCH 0/7] Various: Remove EDK2 " Kinney, Michael D
` (2 subsequent siblings)
9 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-01 15:53 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
kept for compatibility.
Since the libraries are identical, move Vlv2TbltDevicePkg to use the
MdeModulePkg versions instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
index 6da2a8a..80d75d1 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
@@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
}
@@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
!endif
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 5b5523f..44ec378 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -332,7 +332,7 @@
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
!else
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
!endif
@@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
}
@@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
!endif
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 54d2b81..40568f6 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -332,7 +332,7 @@
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
!else
- DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
+ DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
!endif
@@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
<LibraryClasses>
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
}
@@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
!endif
!if $(LZMA_ENABLE) == TRUE
- NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
+ NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
!endif
!if $(TARGET) != RELEASE
DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
--
2.10.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 ` [PATCH 7/7] Vlv2TbltDevicePkg: " Leif Lindholm
@ 2016-12-05 17:32 ` Leif Lindholm
2016-12-06 6:28 ` Wei, David
0 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-05 17:32 UTC (permalink / raw)
To: edk2-devel; +Cc: David Wei, Mang Guo
Hi David, Mang - any comments?
All the other parts of the series have now been pushed.
Regards,
Leif
On Thu, Dec 01, 2016 at 03:53:26PM +0000, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Since the libraries are identical, move Vlv2TbltDevicePkg to use the
> MdeModulePkg versions instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index 6da2a8a..80d75d1 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 5b5523f..44ec378 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -332,7 +332,7 @@
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> !else
> - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> !endif
>
> @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 54d2b81..40568f6 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -332,7 +332,7 @@
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> !else
> - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> !endif
>
> @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-05 17:32 ` Leif Lindholm
@ 2016-12-06 6:28 ` Wei, David
2016-12-06 9:22 ` Leif Lindholm
0 siblings, 1 reply; 21+ messages in thread
From: Wei, David @ 2016-12-06 6:28 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel@lists.01.org; +Cc: Guo, Mang, Wei, David
It looks good.
Reviewed-by: David Wei <david.wei@intel.com>
Thanks,
David Wei
-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
Sent: Tuesday, December 06, 2016 1:33 AM
To: edk2-devel@lists.01.org
Cc: Wei, David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
Hi David, Mang - any comments?
All the other parts of the series have now been pushed.
Regards,
Leif
On Thu, Dec 01, 2016 at 03:53:26PM +0000, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Since the libraries are identical, move Vlv2TbltDevicePkg to use the
> MdeModulePkg versions instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index 6da2a8a..80d75d1 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 5b5523f..44ec378 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -332,7 +332,7 @@
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> !else
> - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> !endif
>
> @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 54d2b81..40568f6 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -332,7 +332,7 @@
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> !else
> - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> !endif
>
> @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> <LibraryClasses>
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> }
>
> @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> !endif
> !if $(LZMA_ENABLE) == TRUE
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> !endif
> !if $(TARGET) != RELEASE
> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
2016-12-06 6:28 ` Wei, David
@ 2016-12-06 9:22 ` Leif Lindholm
0 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-06 9:22 UTC (permalink / raw)
To: Wei, David; +Cc: edk2-devel@lists.01.org, Guo, Mang
Many thanks.
Pushed as 46d4b18.
Regards,
Leif
On Tue, Dec 06, 2016 at 06:28:48AM +0000, Wei, David wrote:
> It looks good.
>
> Reviewed-by: David Wei <david.wei@intel.com>
>
> Thanks,
> David Wei
>
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, December 06, 2016 1:33 AM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
> Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> Hi David, Mang - any comments?
>
> All the other parts of the series have now been pushed.
>
> Regards,
>
> Leif
>
> On Thu, Dec 01, 2016 at 03:53:26PM +0000, Leif Lindholm wrote:
> > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> > kept for compatibility.
> >
> > Since the libraries are identical, move Vlv2TbltDevicePkg to use the
> > MdeModulePkg versions instead.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> > 3 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > index 6da2a8a..80d75d1 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > @@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > index 5b5523f..44ec378 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > @@ -332,7 +332,7 @@
> > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> > !else
> > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> > !endif
> >
> > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > index 54d2b81..40568f6 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > @@ -332,7 +332,7 @@
> > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> > !else
> > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> > !endif
> >
> > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > --
> > 2.10.2
> >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (6 preceding siblings ...)
2016-12-01 15:53 ` [PATCH 7/7] Vlv2TbltDevicePkg: " Leif Lindholm
@ 2016-12-01 18:14 ` Kinney, Michael D
2016-12-01 19:38 ` Jordan Justen
2016-12-02 16:13 ` Leif Lindholm
9 siblings, 0 replies; 21+ messages in thread
From: Kinney, Michael D @ 2016-12-01 18:14 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel@lists.01.org, Kinney, Michael D
Cc: Ni, Ruiyu, Ard Biesheuvel, Justen, Jordan L, Andrew Fish,
Laszlo Ersek, Wei, David
Leif,
Yes. You can push QuarkSocPkg patch based on my previous rb.
Thanks,
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Leif
> Lindholm
> Sent: Thursday, December 1, 2016 7:53 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Wei, David <david.wei@intel.com>
> Subject: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg
> legacy libs
>
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Nevertheless, new code should be using the MdeModulePkg versions, so
> change all references in in-tree platforms.
>
> Since the patches are individually independent, I plan to push them
> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> 1 and 2 myself before the whole series is reviewed?
>
> Changes from RFC:
> - Broken down into per-package patches.
> - Received Reviewed-by:s added.
>
> Leif Lindholm (7):
> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 12 files changed, 24 insertions(+), 24 deletions(-)
>
> --
> 2.10.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (7 preceding siblings ...)
2016-12-01 18:14 ` [PATCH 0/7] Various: Remove EDK2 " Kinney, Michael D
@ 2016-12-01 19:38 ` Jordan Justen
2016-12-02 11:27 ` Leif Lindholm
2016-12-02 16:13 ` Leif Lindholm
9 siblings, 1 reply; 21+ messages in thread
From: Jordan Justen @ 2016-12-01 19:38 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel
Cc: Ruiyu Ni, Ard Biesheuvel, Andrew Fish, Michael D Kinney,
Laszlo Ersek, David Wei
For the future, I'd recommend adding Cc's for package owners to the
associated patch commit message.
Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2016-12-01 07:53:19, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Nevertheless, new code should be using the MdeModulePkg versions, so
> change all references in in-tree platforms.
>
> Since the patches are individually independent, I plan to push them
> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> 1 and 2 myself before the whole series is reviewed?
>
> Changes from RFC:
> - Broken down into per-package patches.
> - Received Reviewed-by:s added.
>
> Leif Lindholm (7):
> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 12 files changed, 24 insertions(+), 24 deletions(-)
>
> --
> 2.10.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-01 19:38 ` Jordan Justen
@ 2016-12-02 11:27 ` Leif Lindholm
2016-12-02 11:53 ` Laszlo Ersek
0 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-02 11:27 UTC (permalink / raw)
To: Jordan Justen
Cc: edk2-devel, Ruiyu Ni, Ard Biesheuvel, Andrew Fish,
Michael D Kinney, Laszlo Ersek, David Wei
On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote:
> For the future, I'd recommend adding Cc's for package owners to the
> associated patch commit message.
I guess what you're actually asking for is to have only the parts of
series I want your review on sent to you?
That's a fair point, but having Cc: tags of package maintainers in the
commit log is just noise. And we are indeed seeing a lot of those at
the moment.
This seems like an excellent time to bring back the idea of unifying
the */Contributions.txt and codifying some of this behaviour
better. (None of them mention Cc: - and they are in fact all
bit-identical.)
Rather than derailing this thread, how about I send out a patch that
does just that, and then we can discuss modifications to the document?
> Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Many thanks - I'll apply for your packages.
Regards,
Leif
> On 2016-12-01 07:53:19, Leif Lindholm wrote:
> > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> > kept for compatibility.
> >
> > Nevertheless, new code should be using the MdeModulePkg versions, so
> > change all references in in-tree platforms.
> >
> > Since the patches are individually independent, I plan to push them
> > myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> > 1 and 2 myself before the whole series is reviewed?
> >
> > Changes from RFC:
> > - Broken down into per-package patches.
> > - Received Reviewed-by:s added.
> >
> > Leif Lindholm (7):
> > OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
> > Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
> >
> > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> > DuetPkg/DuetPkgIa32.dsc | 4 ++--
> > DuetPkg/DuetPkgX64.dsc | 4 ++--
> > EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> > EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> > OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> > OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> > QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> > 12 files changed, 24 insertions(+), 24 deletions(-)
> >
> > --
> > 2.10.2
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-02 11:27 ` Leif Lindholm
@ 2016-12-02 11:53 ` Laszlo Ersek
2016-12-02 12:02 ` Leif Lindholm
0 siblings, 1 reply; 21+ messages in thread
From: Laszlo Ersek @ 2016-12-02 11:53 UTC (permalink / raw)
To: Leif Lindholm, Jordan Justen
Cc: edk2-devel, Ruiyu Ni, Ard Biesheuvel, Andrew Fish,
Michael D Kinney, David Wei
On 12/02/16 12:27, Leif Lindholm wrote:
> On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote:
>> For the future, I'd recommend adding Cc's for package owners to the
>> associated patch commit message.
>
> I guess what you're actually asking for is to have only the parts of
> series I want your review on sent to you?
>
> That's a fair point, but having Cc: tags of package maintainers in the
> commit log is just noise.
Strongly disagree, I fully *want* the commit log to capture the fact
that I CC'd X, Y and Z, and if the committed patch doesn't have feedback
tags from them, that's not my fault.
Independently, technically speaking, there's also no other way for
assigning different sets of CC's to different patches in a series, to my
knowledge. There are hacks around it (for example, you can mail out each
patch individually, setting the CC's per mailing, or else edit the CC
headers (not commit message tags) in the formatted patch email), but
none of those stick around when you rebase the work for v2 or v3, and
format and send out the series again.
> And we are indeed seeing a lot of those at
> the moment.
>
> This seems like an excellent time to bring back the idea of unifying
> the */Contributions.txt and codifying some of this behaviour
> better. (None of them mention Cc: - and they are in fact all
> bit-identical.)
Well, my personal guide mentions Cc:
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18
Thanks
Laszlo
> Rather than derailing this thread, how about I send out a patch that
> does just that, and then we can discuss modifications to the document?
>
>> Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> Many thanks - I'll apply for your packages.
>
> Regards,
>
> Leif
>
>> On 2016-12-01 07:53:19, Leif Lindholm wrote:
>>> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
>>> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
>>> kept for compatibility.
>>>
>>> Nevertheless, new code should be using the MdeModulePkg versions, so
>>> change all references in in-tree platforms.
>>>
>>> Since the patches are individually independent, I plan to push them
>>> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
>>> 1 and 2 myself before the whole series is reviewed?
>>>
>>> Changes from RFC:
>>> - Broken down into per-package patches.
>>> - Received Reviewed-by:s added.
>>>
>>> Leif Lindholm (7):
>>> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
>>> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
>>>
>>> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
>>> DuetPkg/DuetPkgIa32.dsc | 4 ++--
>>> DuetPkg/DuetPkgX64.dsc | 4 ++--
>>> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
>>> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
>>> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
>>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
>>> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
>>> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
>>> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
>>> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
>>> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
>>> 12 files changed, 24 insertions(+), 24 deletions(-)
>>>
>>> --
>>> 2.10.2
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-02 11:53 ` Laszlo Ersek
@ 2016-12-02 12:02 ` Leif Lindholm
0 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-02 12:02 UTC (permalink / raw)
To: Laszlo Ersek
Cc: Jordan Justen, edk2-devel, Ruiyu Ni, Ard Biesheuvel, Andrew Fish,
Michael D Kinney, David Wei
On Fri, Dec 02, 2016 at 12:53:45PM +0100, Laszlo Ersek wrote:
> On 12/02/16 12:27, Leif Lindholm wrote:
> > On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote:
> >> For the future, I'd recommend adding Cc's for package owners to the
> >> associated patch commit message.
> >
> > I guess what you're actually asking for is to have only the parts of
> > series I want your review on sent to you?
> >
> > That's a fair point, but having Cc: tags of package maintainers in the
> > commit log is just noise.
>
> Strongly disagree, I fully *want* the commit log to capture the fact
> that I CC'd X, Y and Z, and if the committed patch doesn't have feedback
> tags from them, that's not my fault.
And if it did capture that, I would agree - but it doesn't.
It's in-band text which may or may not have had any effect on the
transmission of email - depending on client version, configuration and
developer workflow.
Nevertheless, this is exactly the discussion I wanted on a different
thread than this as stated below.
> Independently, technically speaking, there's also no other way for
> assigning different sets of CC's to different patches in a series, to my
> knowledge. There are hacks around it (for example, you can mail out each
> patch individually, setting the CC's per mailing, or else edit the CC
> headers (not commit message tags) in the formatted patch email), but
> none of those stick around when you rebase the work for v2 or v3, and
> format and send out the series again.
>
> > And we are indeed seeing a lot of those at
> > the moment.
> >
> > This seems like an excellent time to bring back the idea of unifying
> > the */Contributions.txt and codifying some of this behaviour
> > better. (None of them mention Cc: - and they are in fact all
> > bit-identical.)
>
> Well, my personal guide mentions Cc:
>
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18
And that's an extremely useful resource, but entirely
unofficial. Let's change that.
Regards,
Leif
> Thanks
> Laszlo
>
> > Rather than derailing this thread, how about I send out a patch that
> > does just that, and then we can discuss modifications to the document?
> >
> >> Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> >
> > Many thanks - I'll apply for your packages.
> >
> > Regards,
> >
> > Leif
> >
> >> On 2016-12-01 07:53:19, Leif Lindholm wrote:
> >>> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> >>> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> >>> kept for compatibility.
> >>>
> >>> Nevertheless, new code should be using the MdeModulePkg versions, so
> >>> change all references in in-tree platforms.
> >>>
> >>> Since the patches are individually independent, I plan to push them
> >>> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> >>> 1 and 2 myself before the whole series is reviewed?
> >>>
> >>> Changes from RFC:
> >>> - Broken down into per-package patches.
> >>> - Received Reviewed-by:s added.
> >>>
> >>> Leif Lindholm (7):
> >>> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
> >>>
> >>> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> >>> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> >>> DuetPkg/DuetPkgX64.dsc | 4 ++--
> >>> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> >>> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> >>> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> >>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> >>> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> >>> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> >>> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> >>> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> >>> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> >>> 12 files changed, 24 insertions(+), 24 deletions(-)
> >>>
> >>> --
> >>> 2.10.2
> >>>
> >>> _______________________________________________
> >>> edk2-devel mailing list
> >>> edk2-devel@lists.01.org
> >>> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
` (8 preceding siblings ...)
2016-12-01 19:38 ` Jordan Justen
@ 2016-12-02 16:13 ` Leif Lindholm
2016-12-05 15:38 ` Ard Biesheuvel
9 siblings, 1 reply; 21+ messages in thread
From: Leif Lindholm @ 2016-12-02 16:13 UTC (permalink / raw)
To: edk2-devel
Cc: Ruiyu Ni, Jordan Justen, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Kelly Steele, David Wei, Mang Guo,
Ard Biesheuvel
On Thu, Dec 01, 2016 at 03:53:19PM +0000, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Nevertheless, new code should be using the MdeModulePkg versions, so
> change all references in in-tree platforms.
>
> Since the patches are individually independent, I plan to push them
> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> 1 and 2 myself before the whole series is reviewed?
>
> Changes from RFC:
> - Broken down into per-package patches.
> - Received Reviewed-by:s added.
>
> Leif Lindholm (7):
I have now pushed:
> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
Which have Reviewed-by: (thank you all for those).
The following remain without feedback (and Ard will be back next week,
so expect at least two of those can be resolved then):
> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
Regards,
Leif
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 12 files changed, 24 insertions(+), 24 deletions(-)
>
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-02 16:13 ` Leif Lindholm
@ 2016-12-05 15:38 ` Ard Biesheuvel
2016-12-05 16:02 ` Leif Lindholm
0 siblings, 1 reply; 21+ messages in thread
From: Ard Biesheuvel @ 2016-12-05 15:38 UTC (permalink / raw)
To: Leif Lindholm
Cc: edk2-devel@lists.01.org, Ruiyu Ni, Jordan Justen, Andrew Fish,
Laszlo Ersek, Michael D Kinney, Kelly Steele, David Wei, Mang Guo
On 2 December 2016 at 16:13, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Dec 01, 2016 at 03:53:19PM +0000, Leif Lindholm wrote:
>> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
>> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
>> kept for compatibility.
>>
>> Nevertheless, new code should be using the MdeModulePkg versions, so
>> change all references in in-tree platforms.
>>
>> Since the patches are individually independent, I plan to push them
>> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
>> 1 and 2 myself before the whole series is reviewed?
>>
>> Changes from RFC:
>> - Broken down into per-package patches.
>> - Received Reviewed-by:s added.
>>
>> Leif Lindholm (7):
>
> I have now pushed:
>
>> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
>> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
>> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
>> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> Which have Reviewed-by: (thank you all for those).
>
> The following remain without feedback (and Ard will be back next week,
> so expect at least two of those can be resolved then):
>
>> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
>> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
2016-12-05 15:38 ` Ard Biesheuvel
@ 2016-12-05 16:02 ` Leif Lindholm
0 siblings, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2016-12-05 16:02 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel@lists.01.org, Ruiyu Ni, Jordan Justen, Andrew Fish,
Laszlo Ersek, Michael D Kinney, Kelly Steele, David Wei, Mang Guo
On Mon, Dec 05, 2016 at 03:38:18PM +0000, Ard Biesheuvel wrote:
> > The following remain without feedback (and Ard will be back next week,
> > so expect at least two of those can be resolved then):
> >
> >> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Beagleboard/EmbeddedPkg ones pushed as bb34cc8..2c1cc12.
Regards,
Leif
^ permalink raw reply [flat|nested] 21+ messages in thread